From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: linux-next: build failure after merge of the kgdb tree
Date: Thu, 25 Mar 2010 15:43:07 +1100 [thread overview]
Message-ID: <20100325154307.9cdeae10.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20100323150443.608ad7f0.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]
Hi Jason, Dmitry,
On Tue, 23 Mar 2010 15:04:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the kgdb tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> kernel/debug/kdb/kdb_main.c: In function 'kdb_sr':
> kernel/debug/kdb/kdb_main.c:1822: error: '__sysrq_enabled' undeclared (first use in this function)
>
> Caused by commit ab28988df9667f8dd70c7434c8ca463beb00b300 ("kdb: core for
> kgdb back end (1 of 2)") from the kgdb tree interacting with commit
> edc6e384f9d96e54a6d03068d3b03fa5b56b6449 ("") fromInput: implement SysRq
> as a separate input handler the input tree.
I got this again today (I stopped reverting the input tree commits that I
was reverting for another build problem). The patch below still seems to
work OK.
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 23 Mar 2010 14:45:22 +1100
> Subject: [PATCH] kgdb: update for sysrq handling change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> kernel/debug/kdb/kdb_main.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index f1f9309..bad8e63 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -1819,10 +1819,8 @@ static int kdb_sr(int argc, const char **argv)
> {
> if (argc != 1)
> return KDB_ARGCOUNT;
> - if (!__sysrq_enabled) {
> - kdb_printf("Auto activating sysrq\n");
> - __sysrq_enabled = 1;
> - }
> +
> + sysrq_toggle_support(1);
>
> kdb_trap_printk++;
> handle_sysrq(*argv[1], NULL);
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-03-25 4:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 4:04 linux-next: build failure after merge of the kgdb tree Stephen Rothwell
2010-03-25 4:43 ` Stephen Rothwell [this message]
2010-03-25 4:59 ` Dmitry Torokhov
2010-05-21 0:21 ` Stephen Rothwell
2010-05-21 0:49 ` Jason Wessel
2010-05-21 1:09 ` Stephen Rothwell
2010-05-21 1:23 ` Dmitry Torokhov
2010-05-21 1:28 ` Jason Wessel
2010-05-24 18:17 ` Dmitry Torokhov
2010-05-24 20:04 ` Jason Wessel
2010-05-24 20:34 ` Dmitry Torokhov
2010-05-24 20:50 ` Jason Wessel
2020-05-19 14:05 Stephen Rothwell
2020-05-19 14:58 ` Doug Anderson
2020-05-19 15:52 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325154307.9cdeae10.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dmitry.torokhov@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).