linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: linux-next: build warning after merge of the driver-core.current tree
Date: Thu, 29 Apr 2010 16:43:47 -0700	[thread overview]
Message-ID: <20100429234347.GA16141@kroah.com> (raw)
In-Reply-To: <20100430093534.9fc6ab8f.sfr@canb.auug.org.au>

On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote:
> Hi Grant,
> 
> After merging the driver-core.current tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
> 
> drivers/base/firmware_class.c: In function 'release_firmware':
> drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
> drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
> 
> Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
> ("firmware_class: fix memory leak - free allocated pages").

Thanks, I've fixed this up, the release call should not have 'const'
on it as it is going to touch the pointer passed to it :)

thanks,

greg k-h

  reply	other threads:[~2010-04-30 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-29 23:35 linux-next: build warning after merge of the driver-core.current tree Stephen Rothwell
2010-04-29 23:43 ` Greg KH [this message]
2010-04-29 23:45   ` Greg KH
2010-04-30  0:01     ` Stephen Rothwell
2022-04-21  5:26 Stephen Rothwell
2022-04-21  6:49 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100429234347.GA16141@kroah.com \
    --to=greg@kroah.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).