From: Greg KH <gregkh@suse.de>
To: Marin Mitov <mitov@issp.bas.bg>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
devel@driverdev.osuosl.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for May 4 (staging/dt3155v4l) [PATCH]
Date: Wed, 5 May 2010 10:58:35 -0700 [thread overview]
Message-ID: <20100505175835.GA18610@suse.de> (raw)
In-Reply-To: <201005052031.39043.mitov@issp.bas.bg>
On Wed, May 05, 2010 at 08:31:38PM +0300, Marin Mitov wrote:
> On Tuesday 04 May 2010 10:42:08 pm Randy Dunlap wrote:
> > On 05/04/10 12:12, Greg KH wrote:
> > > On Tue, May 04, 2010 at 11:36:04AM -0700, Randy Dunlap wrote:
> > >> On Tue, 4 May 2010 16:23:05 +1000 Stephen Rothwell wrote:
> > >>
> > >>> Hi all,
> > >>>
> > >>> Changes since 20100503:
> > >>
> > >>
> > >> drivers/staging/dt3155v4l/dt3155v4l.c:73: error: implicit declaration of function 'udelay'
> > >> drivers/staging/dt3155v4l/dt3155v4l.c:616: warning: assignment from incompatible pointer type
> > >> drivers/staging/dt3155v4l/dt3155v4l.c:1270: error: implicit declaration of function 'msleep'
> > >
> > > Ick. What arch was this?
> >
> > That is on x86_64.
> >
> > The config is attached.
> >
> It's my fault, sorry.
>
> Here is a patch solving the problem. Compiles with Randy's config, but does not link
>
> drivers/staging/built-in.o: In function `format_by_fourcc':
> (.text+0x211da): multiple definition of `format_by_fourcc'
> drivers/media/built-in.o:(.text+0x2a744): first defined here
>
> drivers/media/common/saa7146_video.c:struct saa7146_format* format_by_fourcc(struct saa7146_dev *dev, int fourcc)
> drivers/staging/cx25821/cx25821-video.c:struct cx25821_fmt *format_by_fourcc(unsigned int fourcc)
That's not your driver's problem :)
I've queued up your patch, thanks.
greg k-h
prev parent reply other threads:[~2010-05-05 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 6:23 linux-next: Tree for May 4 Stephen Rothwell
2010-05-04 18:26 ` linux-next: Tree for May 4 (media & IR) Randy Dunlap
2010-05-04 18:36 ` linux-next: Tree for May 4 (staging/dt3155v4l) Randy Dunlap
2010-05-04 19:12 ` Greg KH
2010-05-04 19:42 ` Randy Dunlap
2010-05-05 17:31 ` linux-next: Tree for May 4 (staging/dt3155v4l) [PATCH] Marin Mitov
2010-05-05 17:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505175835.GA18610@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mitov@issp.bas.bg \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).