From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: linux-next: build failure after merge of the driver-core tree Date: Tue, 18 May 2010 16:44:09 +1000 Message-ID: <20100518164409.8b19c786.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Tue__18_May_2010_16_44_09_+1000_CD41NQWC/Uw/8UHv" Return-path: Received: from chilli.pcug.org.au ([203.10.76.44]:39119 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756742Ab0ERGoQ (ORCPT ); Tue, 18 May 2010 02:44:16 -0400 Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Wright --Signature=_Tue__18_May_2010_16_44_09_+1000_CD41NQWC/Uw/8UHv Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Greg, After merging the driver-core tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: cc1: warnings being treated as errors In file included from include/linux/kobject.h:21, from include/linux/device.h:17, from arch/powerpc/lib/devres.c:10: include/linux/sysfs.h:97: error: 'struct file' declared inside parameter li= st include/linux/sysfs.h:97: error: its scope is only this definition or decla= ration, which is probably not what you want include/linux/sysfs.h:99: error: 'struct file' declared inside parameter li= st include/linux/sysfs.h:101: error: 'struct file' declared inside parameter l= ist and many more (arch/powerpc is built with -Werror (as do some other architectures)) and lots of similar warnings ... Caused by commit f8e898186196a22756b50b908ecd92123265f8a2 ("sysfs: add struct file* to bin_attr callbacks"). See Rule 1 in Documentation/SubmitChecklist. The header file probably just needs "struct file;" added in the right place. I have reverted that commit for today (and commit 44e425ab9f887ec6d3a7a4481f3b0c99f120de19 ("pci: check caps from sysfs file open to read device dependent config space") that depends on it). --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Tue__18_May_2010_16_44_09_+1000_CD41NQWC/Uw/8UHv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkvyNzkACgkQjjKRsyhoI8xHwQCgtEomCrJs3GaECrRT/MHSdwg+ YisAn1sSfTf/k+SN42x4N4qT1fxnF2DP =iMXG -----END PGP SIGNATURE----- --Signature=_Tue__18_May_2010_16_44_09_+1000_CD41NQWC/Uw/8UHv--