From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, jonas@southpole.se
Subject: Re: linux-next: build warning after merge of the net tree
Date: Wed, 07 Jul 2010 18:23:44 -0700 (PDT) [thread overview]
Message-ID: <20100707.182344.73667250.davem@davemloft.net> (raw)
In-Reply-To: <20100707143045.0c472f5d.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 7 Jul 2010 14:30:45 +1000
> Hi Dave,
>
> After merging the net tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/net/ethoc.c: In function 'ethoc_init_ring':
> drivers/net/ethoc.c:302: warning: assignment makes integer from pointer without a cast
>
> Introduced by commit f8555ad0cfb0ba6cbc8729f337341fb11c82db89 ("ethoc:
> Write bus addresses to registers").
I'll fix this as follows:
--------------------
ethoc: Fix warning in ethoc_init_ring().
Get rid of the pointless back-and-forth casting of dev->mem_start
from long to pointer back to long again.
Also fixes a warning reported by Stephen Rothwell:
drivers/net/ethoc.c: In function 'ethoc_init_ring':
drivers/net/ethoc.c:302: warning: assignment makes integer from pointer without a cast
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ethoc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
index db519a8..5bb6bb7 100644
--- a/drivers/net/ethoc.c
+++ b/drivers/net/ethoc.c
@@ -286,7 +286,7 @@ static inline void ethoc_disable_rx_and_tx(struct ethoc *dev)
ethoc_write(dev, MODER, mode);
}
-static int ethoc_init_ring(struct ethoc *dev, void* mem_start)
+static int ethoc_init_ring(struct ethoc *dev, unsigned long mem_start)
{
struct ethoc_bd bd;
int i;
@@ -670,7 +670,7 @@ static int ethoc_open(struct net_device *dev)
if (ret)
return ret;
- ethoc_init_ring(priv, (void*)dev->mem_start);
+ ethoc_init_ring(priv, dev->mem_start);
ethoc_reset(priv);
if (netif_queue_stopped(dev)) {
--
1.7.1.1
next prev parent reply other threads:[~2010-07-08 1:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 4:30 linux-next: build warning after merge of the net tree Stephen Rothwell
2010-07-08 1:23 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-04 21:44 Stephen Rothwell
2019-12-05 22:57 ` David Miller
2019-12-05 23:48 ` Stephen Rothwell
2019-01-14 4:15 Stephen Rothwell
2018-08-21 22:04 Stephen Rothwell
2018-08-22 19:26 ` Cong Wang
2017-08-22 23:34 Stephen Rothwell
2017-06-13 11:08 Stephen Rothwell
2017-06-13 11:31 ` Ashwanth Goli
2017-01-18 22:56 Stephen Rothwell
2017-01-19 8:26 ` Tariq Toukan
2014-09-18 0:32 Stephen Rothwell
2014-09-18 0:35 ` Randy Dunlap
2014-09-23 14:59 ` Michal Marek
2014-09-23 21:23 ` Stephen Rothwell
2014-09-24 0:36 ` Stephen Rothwell
2014-09-24 1:58 ` David Miller
2011-05-13 1:41 Stephen Rothwell
2011-05-13 3:04 ` David Miller
2011-05-09 3:46 Stephen Rothwell
2011-05-09 4:13 ` David Miller
2010-07-22 2:11 Stephen Rothwell
2010-07-22 4:09 ` David Miller
2010-07-06 4:25 Stephen Rothwell
2010-07-08 0:45 ` David Miller
2010-07-08 1:18 ` David Miller
2010-07-08 4:13 ` Joe Perches
2010-07-11 2:52 ` David Miller
2010-08-31 2:57 ` Stephen Rothwell
2010-08-31 3:14 ` Joe Perches
2010-08-31 3:58 ` Stephen Rothwell
2010-08-31 4:03 ` Joe Perches
2010-08-31 4:46 ` David Miller
2010-08-31 4:45 ` David Miller
2010-08-31 4:42 ` David Miller
2010-03-01 5:47 Stephen Rothwell
2010-03-01 7:02 ` David Miller
2010-02-15 3:32 Stephen Rothwell
2010-02-15 6:21 ` David Miller
2010-02-15 6:51 ` David Miller
2010-02-15 9:36 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707.182344.73667250.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).