From: Dave Chinner <david@fromorbit.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: xfs-masters@oss.sgi.com, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: linux-next: build failure after merge of the xfs tree
Date: Mon, 26 Jul 2010 13:54:42 +1000 [thread overview]
Message-ID: <20100726035442.GD7362@dastard> (raw)
In-Reply-To: <20100726115107.3c3b7303.sfr@canb.auug.org.au>
On Mon, Jul 26, 2010 at 11:51:07AM +1000, Stephen Rothwell wrote:
> Hi David,
>
> After merging the xfs tree, today's linux-next build (powerpc ppc64_defconfig)
> failed like this:
>
> fs/xfs/xfs_inode_item.c: In function 'xfs_inode_item_format':
> fs/xfs/xfs_inode_item.c:319: error: 'nrecs' undeclared (first use in this function)
>
> Caused by commit 0fd7275cc42ab734eaa1a2c747e65479bd1e42af ("xfs: fix gcc
> 4.6 set but not read and unused statement warnings").
Can you check the following patch fixes the problem?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
xfs: fix big endian build
From: Dave Chinner <dchinner@redhat.com>
Commit 0fd7275cc42ab734eaa1a2c747e65479bd1e42af ("xfs: fix gcc 4.6
set but not read and unused statement warnings") failed to convert
some code inside XFS_NATIVE_HOST (big endian host code only) and
hence fails to build on such machines. Fix it.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/xfs_inode_item.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c
index 2d6fcfd..016b60d 100644
--- a/fs/xfs/xfs_inode_item.c
+++ b/fs/xfs/xfs_inode_item.c
@@ -316,7 +316,8 @@ xfs_inode_item_format(
ASSERT((ip->i_df.if_bytes /
(uint)sizeof(xfs_bmbt_rec_t)) > 0);
#ifdef XFS_NATIVE_HOST
- if (nrecs == ip->i_d.di_nextents) {
+ if (ip->i_d.di_nextents == ip->i_df.if_bytes /
+ (uint)sizeof(xfs_bmbt_rec_t)) {
/*
* There are no delayed allocation
* extents, so just point to the
next prev parent reply other threads:[~2010-07-26 3:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 1:51 linux-next: build failure after merge of the xfs tree Stephen Rothwell
2010-07-26 3:54 ` Dave Chinner [this message]
2010-07-26 4:28 ` Stephen Rothwell
2010-10-08 0:08 Stephen Rothwell
2012-05-10 3:01 Stephen Rothwell
2012-05-10 18:32 ` Ben Myers
2012-05-10 18:36 ` Mark Tinguely
2012-05-10 18:43 ` Ben Myers
2013-04-29 1:29 Stephen Rothwell
2013-04-29 1:40 ` Dave Chinner
2013-04-30 18:36 ` Ben Myers
2015-04-20 2:35 Stephen Rothwell
2016-02-09 0:17 Stephen Rothwell
2016-02-09 0:30 ` Eric Sandeen
2016-02-09 0:41 ` Stephen Rothwell
2019-07-01 1:12 Stephen Rothwell
2019-10-28 23:11 Stephen Rothwell
2019-10-28 23:18 ` Darrick J. Wong
2019-10-29 5:56 ` Christoph Hellwig
2019-10-29 6:23 ` Stephen Rothwell
2019-10-29 6:32 ` Christoph Hellwig
2020-07-07 0:27 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726035442.GD7362@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).