Hi all, On Tue, 14 Sep 2010 00:29:32 +1000 Stephen Rothwell wrote: > > After merging the final tree, today's linux-next build (arm > assabet_defconfig and serveral other arm configs) failed like this: > > arch/arm/mm/init.c: In function 'arm_memory_present': > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area' > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap' > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap' > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup' > arch/arm/mm/init.c:606: error: initializer element is not constant > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func') > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input > arch/arm/mm/init.c:252: warning: unused variable 'i' > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm: > Use new accessors") which forgot a closing brace on a new > for_each_memblock() in arm_memory_present(). So this commit is back in tip and the error is back in the builds ... -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/