From: Ingo Molnar <mingo@elte.hu>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Andres Salomon <dilinger@queued.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: build warning after merge of the devicetree tree
Date: Thu, 21 Oct 2010 10:05:26 +0200 [thread overview]
Message-ID: <20101021080526.GB8775@elte.hu> (raw)
In-Reply-To: <20101021032657.GB13335@angua.secretlab.ca>
* Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Oct 21, 2010 at 01:37:26PM +1100, Stephen Rothwell wrote:
> > Hi Grant,
> >
> > After merging the devicetree tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > arch/x86/kernel/irq.c:280: warning: 'struct device_node' declared inside parameter list
> >
> > Introduced by commit 27f4e2b1060be8bc38146fd30986e7c2858e2a5f ("x86/of:
> > define irq functions to allow drivers/of/* to build on x86"). This build
> > has CONFIG_OF not set.
>
> Thanks Stephen. Does the following patch fix things?
>
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 4417f49..23216f7 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -276,12 +276,14 @@ void smp_x86_platform_ipi(struct pt_regs *regs)
>
> EXPORT_SYMBOL_GPL(vector_used_by_percpu_irq);
>
> +#ifdef CONFIG_OF
> unsigned int irq_create_of_mapping(struct device_node *controller,
> const u32 *intspec, unsigned int intsize)
> {
> return intspec[0];
> }
> EXPORT_SYMBOL_GPL(irq_create_of_mapping);
> +#endif
Sigh, 'of' is the most misnamed Linux subsystem in history! 'CONFIG_OF_' always
makes me ask 'config of what?' irq_create_of_mapping ditto.
Why not OFW or OPENFIRMWARE?
Thanks,
Ingo
next prev parent reply other threads:[~2010-10-21 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 2:37 linux-next: build warning after merge of the devicetree tree Stephen Rothwell
2010-10-21 3:26 ` Grant Likely
2010-10-21 8:05 ` Ingo Molnar [this message]
2010-10-21 17:04 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2023-02-20 5:36 Stephen Rothwell
2021-10-26 2:44 Stephen Rothwell
2021-08-24 3:18 Stephen Rothwell
2021-08-24 12:35 ` Rob Herring
2021-09-02 22:34 ` Stephen Rothwell
2021-09-03 0:38 ` Rob Herring
2018-05-09 6:04 Stephen Rothwell
2018-05-09 12:17 ` Rob Herring
2018-05-29 6:04 ` Stephen Rothwell
2018-03-06 1:05 Stephen Rothwell
2018-03-06 2:34 ` Rob Herring
2018-03-06 3:11 ` Stephen Rothwell
2018-03-06 1:03 Stephen Rothwell
2017-04-28 2:45 Stephen Rothwell
2017-05-03 5:44 ` Stephen Rothwell
2017-05-03 12:12 ` Rob Herring
2017-05-03 12:46 ` Stephen Rothwell
2010-07-30 4:54 Stephen Rothwell
2010-07-30 6:10 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021080526.GB8775@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).