From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: linux-next: build failure after merge of the tip tree Date: Thu, 17 Feb 2011 18:11:31 +0100 Message-ID: <20110217171131.GA17058@elte.hu> References: <20110131154259.dca1f7e6.sfr@canb.auug.org.au> <20110217144743.2db26b27.sfr@canb.auug.org.au> <4D5D201A.8090304@suse.cz> <20110217150200.GA32177@sepie.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:35031 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757132Ab1BQRLs (ORCPT ); Thu, 17 Feb 2011 12:11:48 -0500 Content-Disposition: inline In-Reply-To: <20110217150200.GA32177@sepie.suse.cz> Sender: linux-next-owner@vger.kernel.org List-ID: To: Michal Marek Cc: Stephen Rothwell , Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu * Michal Marek wrote: > @@ -340,9 +342,16 @@ static void parse_dep_file(void *map, size_t len) > if (strrcmp(s, "include/generated/autoconf.h") && > strrcmp(s, "arch/um/include/uml-config.h") && > strrcmp(s, ".ver")) { > - printf(" %s \\\n", s); > + /* Do not output the first dependency (the > + * source file), so that kbuild is not confused > + * if a .c file is rewritten into .S or vice > + * versa. > + */ Just a really minor nitpick, please use the standard comment style: /* * Comment ..... * ...... goes here. */ specified in Documentation/CodingStyle. Thanks, Ingo