From: Jean Delvare <khali@linux-fr.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related)
Date: Tue, 15 Mar 2011 10:32:28 +0100 [thread overview]
Message-ID: <20110315103228.30233acc@endymion.delvare> (raw)
In-Reply-To: <4D7F2609.3080508@redhat.com>
On Tue, 15 Mar 2011 09:40:41 +0100, Hans de Goede wrote:
> Hi,
>
> On 03/15/2011 09:24 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/hwmon/sch5627.c: In function 'sch5627_read_virtual_reg':
> > drivers/hwmon/sch5627.c:179: error: implicit declaration of function 'msleep'
> >
> > Caused by commit 19803daeb145 ("hwmon: New driver for SMSC SCH5627").
> > See Rule 1 in Documentation/SubmitChecklist.
> >
> > I have reverted that commit for today.
>
> The attached patch should fix this, Jean can you please add this to your
> tree? Note feel free to merge it into the initial patch adding the sch5627 driver
> if you prefer.
Thanks for the fix, I've merged it in the original patch (to preserve
bisectability) and pushed it for next linux-next.
Stephen, sorry for the inconvenience, both Hans and myself build-tested
the new code on an architecture where <linux/delay.h> gets included
implicitly, so we didn't notice it was missing.
--
Jean Delvare
next prev parent reply other threads:[~2011-03-15 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 8:24 linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related) Stephen Rothwell
2011-03-15 8:40 ` Hans de Goede
2011-03-15 9:32 ` Jean Delvare [this message]
2011-03-15 10:22 ` Stephen Rothwell
2011-03-16 11:30 ` Jean Delvare
2011-03-17 12:18 ` Geert Uytterhoeven
2011-03-17 15:36 ` Jean Delvare
2011-03-16 16:16 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2010-10-06 4:28 Stephen Rothwell
2010-10-06 7:05 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315103228.30233acc@endymion.delvare \
--to=khali@linux-fr.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).