From: Samuel Ortiz <sameo@linux.intel.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Kyungmin Park <kyungmin.park@samsung.com>,
myungjoo.ham@gmail.com
Subject: Re: [PATCH v7] MAX8997/8966 MFD: Add IRQ control feature
Date: Tue, 22 Mar 2011 12:51:35 +0100 [thread overview]
Message-ID: <20110322115134.GF2351@sortiz-mobl> (raw)
In-Reply-To: <1300694904-29856-1-git-send-email-myungjoo.ham@samsung.com>
Hi MyungJoo,
On Mon, Mar 21, 2011 at 05:08:24PM +0900, MyungJoo Ham wrote:
> +static struct irq_chip max8997_irq_chip = {
> + .name = "max8997",
> +#ifdef CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED
> + .irq_bus_lock = max8997_irq_lock,
> + .irq_bus_sync_unlock = max8997_irq_sync_unlock,
> + .irq_mask = max8997_irq_mask,
> + .irq_unmask = max8997_irq_unmask,
> +#else /* CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED */
> + .bus_lock = max8997_irq_lock,
> + .bus_sync_unlock = max8997_irq_sync_unlock,
> + .mask = max8997_irq_mask,
> + .unmask = max8997_irq_unmask,
> +#endif /* CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED */
> +};
You actually don't need to define both pointer sets. Setting the irq_* ones
should be enough for both configs.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-03-22 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 2:59 linux-next: build failure after merge of the final tree (mfd tree related) Stephen Rothwell
2011-03-21 8:08 ` [PATCH v7] MAX8997/8966 MFD: Add IRQ control feature MyungJoo Ham
2011-03-22 11:51 ` Samuel Ortiz [this message]
2011-03-24 6:54 ` [PATCH] " MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322115134.GF2351@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).