From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for May 24 (ratelimits, CONFIG_PRINTK not enabled) Date: Tue, 24 May 2011 11:33:28 -0700 Message-ID: <20110524113328.e3d5867b.randy.dunlap@oracle.com> References: <20110524140212.a4f19769.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:32984 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696Ab1EXSdu (ORCPT ); Tue, 24 May 2011 14:33:50 -0400 In-Reply-To: <20110524140212.a4f19769.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell , Joe Perches , netdev Cc: linux-next@vger.kernel.org, LKML , davem@davemloft.net On Tue, 24 May 2011 14:02:12 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20110523: when CONFIG_PRINTK is not enabled: net/core/filter.c:353: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE' net/core/filter.c:353: warning: parameter names (without types) in function declaration net/core/filter.c:353: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE' net/core/filter.c:353: error: implicit declaration of function '__ratelimit' net/core/filter.c:353: error: '_rs' undeclared (first use in this function) Adding to causes other problems: In file included from linux-next-20110524/include/linux/thread_info.h:53, from linux-next-20110524/include/linux/preempt.h:9, from linux-next-20110524/include/linux/spinlock.h:50, from linux-next-20110524/include/linux/ratelimit.h:5, from linux-next-20110524/include/asm-generic/bug.h:5, from linux-next-20110524/arch/x86/include/asm/bug.h:38, from linux-next-20110524/include/linux/kernel.h:23, from linux-next-20110524/arch/x86/include/asm/percpu.h:44, from linux-next-20110524/arch/x86/include/asm/current.h:5, from linux-next-20110524/arch/x86/include/asm/processor.h:15, from linux-next-20110524/arch/x86/include/asm/atomic.h:6, from linux-next-20110524/include/linux/crypto.h:20, from linux-next-20110524/arch/x86/kernel/asm-offsets.c:8: linux-next-20110524/arch/x86/include/asm/thread_info.h:34: error: expected specifier-qualifier-list before 'mm_segment_t' In file included from linux-next-20110524/include/linux/thread_info.h:53, from linux-next-20110524/include/linux/preempt.h:9, from linux-next-20110524/include/linux/spinlock.h:50, from linux-next-20110524/include/linux/ratelimit.h:5, from linux-next-20110524/include/asm-generic/bug.h:5, from linux-next-20110524/arch/x86/include/asm/bug.h:38, from linux-next-20110524/include/linux/kernel.h:23, from linux-next-20110524/arch/x86/include/asm/percpu.h:44, from linux-next-20110524/arch/x86/include/asm/current.h:5, from linux-next-20110524/arch/x86/include/asm/processor.h:15, from linux-next-20110524/arch/x86/include/asm/atomic.h:6, from linux-next-20110524/include/linux/crypto.h:20, from linux-next-20110524/arch/x86/kernel/asm-offsets.c:8: linux-next-20110524/arch/x86/include/asm/thread_info.h:217: error: expected declaration specifiers or '...' before 'kernel_stack' linux-next-20110524/arch/x86/include/asm/thread_info.h:217: warning: data definition has no type or storage class linux-next-20110524/arch/x86/include/asm/thread_info.h:217: warning: type defaults to 'int' in declaration of 'DECLARE_PER_CPU' linux-next-20110524/arch/x86/include/asm/thread_info.h: In function 'current_thread_info': linux-next-20110524/arch/x86/include/asm/thread_info.h:222: error: implicit declaration of function 'percpu_read_stable' linux-next-20110524/arch/x86/include/asm/thread_info.h:222: error: 'kernel_stack' undeclared (first use in this function) --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***