linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build warnings after merge of the moduleh tree
@ 2011-07-29  5:25 Stephen Rothwell
  2011-07-31  8:24 ` Paul Gortmaker
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2011-07-29  5:25 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: linux-next, linux-kernel, Neil Brown, linux-raid

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/md/persistent-data/dm-block-manager.c:103:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:103:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:109:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:109:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:109:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:670:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:670:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:670:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:692:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:692:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:692:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:698:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:698:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:698:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:816:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:816:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:816:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:824:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:824:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:824:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:881:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:881:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:881:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-block-manager.c:946:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-block-manager.c:946:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-block-manager.c:946:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-space-map-disk.c:662:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-space-map-disk.c:662:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-space-map-disk.c:662:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:146:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:146:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:293:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:293:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:293:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:301:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:301:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:301:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:378:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:378:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:378:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:756:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:756:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:756:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:765:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:765:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:765:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:801:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:801:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:801:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree.c:857:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree.c:857:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree.c:857:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: parameter names (without types) in function declaration

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 29 Jul 2011 15:16:04 +1000
Subject: [PATCH] include export.h to use EXPORT_SYMBOL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/md/persistent-data/dm-block-manager.c  |    1 +
 drivers/md/persistent-data/dm-btree-remove.c   |    2 ++
 drivers/md/persistent-data/dm-btree.c          |    1 +
 drivers/md/persistent-data/dm-space-map-disk.c |    1 +
 4 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/md/persistent-data/dm-block-manager.c b/drivers/md/persistent-data/dm-block-manager.c
index 4ec480c..7b8e84c 100644
--- a/drivers/md/persistent-data/dm-block-manager.c
+++ b/drivers/md/persistent-data/dm-block-manager.c
@@ -9,6 +9,7 @@
 #include <linux/dm-io.h>
 #include <linux/slab.h>
 #include <linux/device-mapper.h>
+#include <linux/export.h>
 
 #define DM_MSG_PREFIX "block manager"
 
diff --git a/drivers/md/persistent-data/dm-btree-remove.c b/drivers/md/persistent-data/dm-btree-remove.c
index 72c9705..e7071f6 100644
--- a/drivers/md/persistent-data/dm-btree-remove.c
+++ b/drivers/md/persistent-data/dm-btree-remove.c
@@ -8,6 +8,8 @@
 #include "dm-btree-internal.h"
 #include "dm-transaction-manager.h"
 
+#include <linux/export.h>
+
 /*
  * Removing an entry from a btree
  * ==============================
diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c
index 55b8bf3..7cad5e8 100644
--- a/drivers/md/persistent-data/dm-btree.c
+++ b/drivers/md/persistent-data/dm-btree.c
@@ -9,6 +9,7 @@
 #include "dm-transaction-manager.h"
 
 #include <linux/device-mapper.h>
+#include <linux/export.h>
 
 #define DM_MSG_PREFIX "btree"
 
diff --git a/drivers/md/persistent-data/dm-space-map-disk.c b/drivers/md/persistent-data/dm-space-map-disk.c
index de31096..26e6e19 100644
--- a/drivers/md/persistent-data/dm-space-map-disk.c
+++ b/drivers/md/persistent-data/dm-space-map-disk.c
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/bitops.h>
 #include <linux/device-mapper.h>
+#include <linux/export.h>
 
 #define DM_MSG_PREFIX "space map disk"
 
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: linux-next: build warnings after merge of the moduleh tree
  2011-07-29  5:25 linux-next: build warnings after merge of the moduleh tree Stephen Rothwell
@ 2011-07-31  8:24 ` Paul Gortmaker
  2011-08-01  0:35   ` Stephen Rothwell
  0 siblings, 1 reply; 7+ messages in thread
From: Paul Gortmaker @ 2011-07-31  8:24 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Neil Brown, linux-raid

[linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 15:25) Stephen Rothwell wrote:

> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
> 
> drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
[...]
> drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
[...]
> drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
[...]
> drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> 
> I have added the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 29 Jul 2011 15:16:04 +1000
> Subject: [PATCH] include export.h to use EXPORT_SYMBOL
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/md/persistent-data/dm-block-manager.c  |    1 +
>  drivers/md/persistent-data/dm-btree-remove.c   |    2 ++
>  drivers/md/persistent-data/dm-btree.c          |    1 +
>  drivers/md/persistent-data/dm-space-map-disk.c |    1 +
>  4 files changed, 5 insertions(+), 0 deletions(-)

This one is a bit more interesting.  The above files (and actually their
parent dir) doesn't exist yet in master/HEAD.  So I can't patch them
yet.  And the MD maintainers can't patch in export.h usage, since they
won't have such a header file.

If you didn't want to temporarily carry it, I can think of two things:
I suppose, since the one single commit that creates export.h is totally
standalone, and harmless/inert in itself, we could perhaps get it pulled
independently if it made life easier for others to align to the right
usage?  Or they can just patch in module.h usage and we can downgrade
them to export.h usage shortly thereafter.

Paul.

> 
> diff --git a/drivers/md/persistent-data/dm-block-manager.c b/drivers/md/persistent-data/dm-block-manager.c
> index 4ec480c..7b8e84c 100644
> --- a/drivers/md/persistent-data/dm-block-manager.c
> +++ b/drivers/md/persistent-data/dm-block-manager.c
> @@ -9,6 +9,7 @@
>  #include <linux/dm-io.h>
>  #include <linux/slab.h>
>  #include <linux/device-mapper.h>
> +#include <linux/export.h>
>  
>  #define DM_MSG_PREFIX "block manager"
>  
> diff --git a/drivers/md/persistent-data/dm-btree-remove.c b/drivers/md/persistent-data/dm-btree-remove.c
> index 72c9705..e7071f6 100644
> --- a/drivers/md/persistent-data/dm-btree-remove.c
> +++ b/drivers/md/persistent-data/dm-btree-remove.c
> @@ -8,6 +8,8 @@
>  #include "dm-btree-internal.h"
>  #include "dm-transaction-manager.h"
>  
> +#include <linux/export.h>
> +
>  /*
>   * Removing an entry from a btree
>   * ==============================
> diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c
> index 55b8bf3..7cad5e8 100644
> --- a/drivers/md/persistent-data/dm-btree.c
> +++ b/drivers/md/persistent-data/dm-btree.c
> @@ -9,6 +9,7 @@
>  #include "dm-transaction-manager.h"
>  
>  #include <linux/device-mapper.h>
> +#include <linux/export.h>
>  
>  #define DM_MSG_PREFIX "btree"
>  
> diff --git a/drivers/md/persistent-data/dm-space-map-disk.c b/drivers/md/persistent-data/dm-space-map-disk.c
> index de31096..26e6e19 100644
> --- a/drivers/md/persistent-data/dm-space-map-disk.c
> +++ b/drivers/md/persistent-data/dm-space-map-disk.c
> @@ -13,6 +13,7 @@
>  #include <linux/slab.h>
>  #include <linux/bitops.h>
>  #include <linux/device-mapper.h>
> +#include <linux/export.h>
>  
>  #define DM_MSG_PREFIX "space map disk"
>  
> -- 
> 1.7.5.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: build warnings after merge of the moduleh tree
  2011-07-31  8:24 ` Paul Gortmaker
@ 2011-08-01  0:35   ` Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2011-08-01  0:35 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: linux-next, linux-kernel, Neil Brown, linux-raid

[-- Attachment #1: Type: text/plain, Size: 2533 bytes --]

On Sun, 31 Jul 2011 04:24:05 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> [linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 15:25) Stephen Rothwell wrote:
> 
> > Hi Paul,
> > 
> > After merging the moduleh tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> > 
> > drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> > 
> > I have added the following patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Fri, 29 Jul 2011 15:16:04 +1000
> > Subject: [PATCH] include export.h to use EXPORT_SYMBOL
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/md/persistent-data/dm-block-manager.c  |    1 +
> >  drivers/md/persistent-data/dm-btree-remove.c   |    2 ++
> >  drivers/md/persistent-data/dm-btree.c          |    1 +
> >  drivers/md/persistent-data/dm-space-map-disk.c |    1 +
> >  4 files changed, 5 insertions(+), 0 deletions(-)
> 
> This one is a bit more interesting.  The above files (and actually their
> parent dir) doesn't exist yet in master/HEAD.  So I can't patch them
> yet.  And the MD maintainers can't patch in export.h usage, since they
> won't have such a header file.
> 
> If you didn't want to temporarily carry it, I can think of two things:
> I suppose, since the one single commit that creates export.h is totally
> standalone, and harmless/inert in itself, we could perhaps get it pulled
> independently if it made life easier for others to align to the right
> usage?  Or they can just patch in module.h usage and we can downgrade
> them to export.h usage shortly thereafter.

I will carry it for now (as a merge fixup on the moduleh tree.  If the
export.h split goes to Linus, then Neil can apply it to his tree, or
Linus can apply it as a merge fixup ehen he merges the latter of the two
trees (as long as someone remember to tell him).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: build warnings after merge of the moduleh tree
  2011-10-12  6:30 Stephen Rothwell
@ 2011-10-13  2:00 ` Paul Gortmaker
  0 siblings, 0 replies; 7+ messages in thread
From: Paul Gortmaker @ 2011-10-13  2:00 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Arend van Spriel, John W. Linville

On Wed, Oct 12, 2011 at 2:30 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Paul,
>
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: parameter names (without types) in function declaration [enabled by default]
>
> Caused by commit 5b435de0d786 ("net: wireless: add brcm80211 drivers")
> from the wireless tree interacting with the module.h split up.
>
> I have added the following patch:

Thanks Stephen, added to the post merge queue with the other post-merge
wireless export.h additions.

Paul.

>
> From 9ea7a8cb92322497a92d464e6e40cd1da20fbcde Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 12 Oct 2011 17:22:53 +1100
> Subject: [PATCH] net: wireless; brcm80211: add export.h
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |    1 +
>  drivers/net/wireless/brcm80211/brcmutil/wifi.c   |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> index bff9dcd..76c78fd 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> @@ -21,6 +21,7 @@
>  #include <linux/pci_ids.h>
>  #include <linux/sched.h>
>  #include <linux/completion.h>
> +#include <linux/export.h>
>  #include <linux/mmc/sdio.h>
>  #include <linux/mmc/sdio_func.h>
>  #include <linux/mmc/card.h>
> diff --git a/drivers/net/wireless/brcm80211/brcmutil/wifi.c b/drivers/net/wireless/brcm80211/brcmutil/wifi.c
> index 509e25c..5616fa8 100644
> --- a/drivers/net/wireless/brcm80211/brcmutil/wifi.c
> +++ b/drivers/net/wireless/brcm80211/brcmutil/wifi.c
> @@ -13,6 +13,8 @@
>  * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
>  * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>  */
> +#include <linux/export.h>
> +
>  #include <brcmu_wifi.h>
>
>  /*
> --
> 1.7.6.3
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: build warnings after merge of the moduleh tree
@ 2011-10-12  6:30 Stephen Rothwell
  2011-10-13  2:00 ` Paul Gortmaker
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2011-10-12  6:30 UTC (permalink / raw)
  To: Paul Gortmaker
  Cc: linux-next, linux-kernel, Arend van Spriel, John W. Linville

[-- Attachment #1: Type: text/plain, Size: 3887 bytes --]

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:43:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:79:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmutil/wifi.c:136:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:348:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:363:1: warning: parameter names (without types) in function declaration [enabled by default]

Caused by commit 5b435de0d786 ("net: wireless: add brcm80211 drivers")
from the wireless tree interacting with the module.h split up.

I have added the following patch:

From 9ea7a8cb92322497a92d464e6e40cd1da20fbcde Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Oct 2011 17:22:53 +1100
Subject: [PATCH] net: wireless; brcm80211: add export.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |    1 +
 drivers/net/wireless/brcm80211/brcmutil/wifi.c   |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
index bff9dcd..76c78fd 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
@@ -21,6 +21,7 @@
 #include <linux/pci_ids.h>
 #include <linux/sched.h>
 #include <linux/completion.h>
+#include <linux/export.h>
 #include <linux/mmc/sdio.h>
 #include <linux/mmc/sdio_func.h>
 #include <linux/mmc/card.h>
diff --git a/drivers/net/wireless/brcm80211/brcmutil/wifi.c b/drivers/net/wireless/brcm80211/brcmutil/wifi.c
index 509e25c..5616fa8 100644
--- a/drivers/net/wireless/brcm80211/brcmutil/wifi.c
+++ b/drivers/net/wireless/brcm80211/brcmutil/wifi.c
@@ -13,6 +13,8 @@
  * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
  * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
+#include <linux/export.h>
+
 #include <brcmu_wifi.h>
 
 /*
-- 
1.7.6.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: linux-next: build warnings after merge of the moduleh tree
  2011-07-29  6:09 Stephen Rothwell
@ 2011-07-31  5:38 ` Paul Gortmaker
  0 siblings, 0 replies; 7+ messages in thread
From: Paul Gortmaker @ 2011-07-31  5:38 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel

[linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 16:09) Stephen Rothwell wrote:

> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/of/of_pci_irq.c:92:1: warning: data definition has no type or storage class
> drivers/of/of_pci_irq.c:92:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> drivers/of/of_pci_irq.c:92:1: warning: parameter names (without types) in function declaration
> 
> This is an interaction with commit 98d9f30c820d ("pci/of: Match PCI
> devices to OF nodes dynamically") which split off part of
> drivers/of/of_pci.c.

Thanks, I've picked this one up as well.

Paul.

> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 29 Jul 2011 16:05:38 +1000
> Subject: [PATCH] pci/of: include export.h for EXPORT_SYMBOL_GPL
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/of/of_pci_irq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/of/of_pci_irq.c b/drivers/of/of_pci_irq.c
> index ac1ec54..9312516 100644
> --- a/drivers/of/of_pci_irq.c
> +++ b/drivers/of/of_pci_irq.c
> @@ -1,6 +1,7 @@
>  #include <linux/kernel.h>
>  #include <linux/of_pci.h>
>  #include <linux/of_irq.h>
> +#include <linux/export.h>
>  #include <asm/prom.h>
>  
>  /**
> -- 
> 1.7.5.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: build warnings after merge of the moduleh tree
@ 2011-07-29  6:09 Stephen Rothwell
  2011-07-31  5:38 ` Paul Gortmaker
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2011-07-29  6:09 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: linux-next, linux-kernel

Hi Paul,

After merging the moduleh tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/of/of_pci_irq.c:92:1: warning: data definition has no type or storage class
drivers/of/of_pci_irq.c:92:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/of/of_pci_irq.c:92:1: warning: parameter names (without types) in function declaration

This is an interaction with commit 98d9f30c820d ("pci/of: Match PCI
devices to OF nodes dynamically") which split off part of
drivers/of/of_pci.c.

I have added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 29 Jul 2011 16:05:38 +1000
Subject: [PATCH] pci/of: include export.h for EXPORT_SYMBOL_GPL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/of/of_pci_irq.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/of/of_pci_irq.c b/drivers/of/of_pci_irq.c
index ac1ec54..9312516 100644
--- a/drivers/of/of_pci_irq.c
+++ b/drivers/of/of_pci_irq.c
@@ -1,6 +1,7 @@
 #include <linux/kernel.h>
 #include <linux/of_pci.h>
 #include <linux/of_irq.h>
+#include <linux/export.h>
 #include <asm/prom.h>
 
 /**
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-10-13  2:00 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-29  5:25 linux-next: build warnings after merge of the moduleh tree Stephen Rothwell
2011-07-31  8:24 ` Paul Gortmaker
2011-08-01  0:35   ` Stephen Rothwell
2011-07-29  6:09 Stephen Rothwell
2011-07-31  5:38 ` Paul Gortmaker
2011-10-12  6:30 Stephen Rothwell
2011-10-13  2:00 ` Paul Gortmaker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).