linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warnings after merge of the moduleh tree
Date: Sun, 31 Jul 2011 01:38:44 -0400	[thread overview]
Message-ID: <20110731053843.GC31842@windriver.com> (raw)
In-Reply-To: <20110729160943.c77bc737188b0cf9dace922a@canb.auug.org.au>

[linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 16:09) Stephen Rothwell wrote:

> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/of/of_pci_irq.c:92:1: warning: data definition has no type or storage class
> drivers/of/of_pci_irq.c:92:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> drivers/of/of_pci_irq.c:92:1: warning: parameter names (without types) in function declaration
> 
> This is an interaction with commit 98d9f30c820d ("pci/of: Match PCI
> devices to OF nodes dynamically") which split off part of
> drivers/of/of_pci.c.

Thanks, I've picked this one up as well.

Paul.

> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 29 Jul 2011 16:05:38 +1000
> Subject: [PATCH] pci/of: include export.h for EXPORT_SYMBOL_GPL
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/of/of_pci_irq.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/of/of_pci_irq.c b/drivers/of/of_pci_irq.c
> index ac1ec54..9312516 100644
> --- a/drivers/of/of_pci_irq.c
> +++ b/drivers/of/of_pci_irq.c
> @@ -1,6 +1,7 @@
>  #include <linux/kernel.h>
>  #include <linux/of_pci.h>
>  #include <linux/of_irq.h>
> +#include <linux/export.h>
>  #include <asm/prom.h>
>  
>  /**
> -- 
> 1.7.5.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

  reply	other threads:[~2011-07-31  5:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  6:09 linux-next: build warnings after merge of the moduleh tree Stephen Rothwell
2011-07-31  5:38 ` Paul Gortmaker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-10-12  6:30 Stephen Rothwell
2011-10-13  2:00 ` Paul Gortmaker
2011-07-29  5:25 Stephen Rothwell
2011-07-31  8:24 ` Paul Gortmaker
2011-08-01  0:35   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110731053843.GC31842@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).