linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Neil Brown <neilb@suse.de>,
	linux-raid@vger.kernel.org
Subject: Re: linux-next: build warnings after merge of the moduleh tree
Date: Mon, 1 Aug 2011 10:35:37 +1000	[thread overview]
Message-ID: <20110801103537.a273ddac48fc81a8f28c2f90@canb.auug.org.au> (raw)
In-Reply-To: <20110731082405.GM31842@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2533 bytes --]

On Sun, 31 Jul 2011 04:24:05 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> [linux-next: build warnings after merge of the moduleh tree] On 29/07/2011 (Fri 15:25) Stephen Rothwell wrote:
> 
> > Hi Paul,
> > 
> > After merging the moduleh tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> > 
> > drivers/md/persistent-data/dm-block-manager.c:103:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-space-map-disk.c:634:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree.c:146:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> [...]
> > drivers/md/persistent-data/dm-btree-remove.c:569:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> > 
> > I have added the following patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Fri, 29 Jul 2011 15:16:04 +1000
> > Subject: [PATCH] include export.h to use EXPORT_SYMBOL
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/md/persistent-data/dm-block-manager.c  |    1 +
> >  drivers/md/persistent-data/dm-btree-remove.c   |    2 ++
> >  drivers/md/persistent-data/dm-btree.c          |    1 +
> >  drivers/md/persistent-data/dm-space-map-disk.c |    1 +
> >  4 files changed, 5 insertions(+), 0 deletions(-)
> 
> This one is a bit more interesting.  The above files (and actually their
> parent dir) doesn't exist yet in master/HEAD.  So I can't patch them
> yet.  And the MD maintainers can't patch in export.h usage, since they
> won't have such a header file.
> 
> If you didn't want to temporarily carry it, I can think of two things:
> I suppose, since the one single commit that creates export.h is totally
> standalone, and harmless/inert in itself, we could perhaps get it pulled
> independently if it made life easier for others to align to the right
> usage?  Or they can just patch in module.h usage and we can downgrade
> them to export.h usage shortly thereafter.

I will carry it for now (as a merge fixup on the moduleh tree.  If the
export.h split goes to Linus, then Neil can apply it to his tree, or
Linus can apply it as a merge fixup ehen he merges the latter of the two
trees (as long as someone remember to tell him).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-08-01  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  5:25 linux-next: build warnings after merge of the moduleh tree Stephen Rothwell
2011-07-31  8:24 ` Paul Gortmaker
2011-08-01  0:35   ` Stephen Rothwell [this message]
2011-07-29  6:09 Stephen Rothwell
2011-07-31  5:38 ` Paul Gortmaker
2011-10-12  6:30 Stephen Rothwell
2011-10-13  2:00 ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110801103537.a273ddac48fc81a8f28c2f90@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).