linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mike Christie <michaelc@cs.wisc.edu>,
	Jens Axboe <jaxboe@fusionio.com>
Subject: linux-next: build warning after merge of the moduleh tree
Date: Mon, 1 Aug 2011 13:23:59 +1000	[thread overview]
Message-ID: <20110801132359.1de051cb8a4a2bdfdad7560c@canb.auug.org.au> (raw)

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

block/bsg-lib.c:75:1: warning: data definition has no type or storage class
block/bsg-lib.c:75:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
block/bsg-lib.c:75:1: warning: parameter names (without types) in function declaration
block/bsg-lib.c:164:1: warning: data definition has no type or storage class
block/bsg-lib.c:164:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
block/bsg-lib.c:164:1: warning: parameter names (without types) in function declaration
block/bsg-lib.c:210:1: warning: data definition has no type or storage class
block/bsg-lib.c:210:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
block/bsg-lib.c:210:1: warning: parameter names (without types) in function declaration
block/bsg-lib.c:244:1: warning: data definition has no type or storage class
block/bsg-lib.c:244:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
block/bsg-lib.c:244:1: warning: parameter names (without types) in function declaration
block/bsg-lib.c:297:1: warning: data definition has no type or storage class
block/bsg-lib.c:297:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
block/bsg-lib.c:297:1: warning: parameter names (without types) in function declaration

This is an interaction with commit aa387cc89567 ("block: add bsg helper
library") from the block tree.  That file should have included module.h
but now would need export.h it seems (just uses EXPORTSYMBOL_GPL).

I applied the following as a merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 1 Aug 2011 13:21:39 +1000
Subject: [PATCH] block: bsg-lib.c needs export.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 block/bsg-lib.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/block/bsg-lib.c b/block/bsg-lib.c
index f8c0a61..b82c11b 100644
--- a/block/bsg-lib.c
+++ b/block/bsg-lib.c
@@ -23,6 +23,7 @@
 #include <linux/slab.h>
 #include <linux/blkdev.h>
 #include <linux/delay.h>
+#include <linux/export.h>
 #include <linux/scatterlist.h>
 #include <linux/bsg-lib.h>
 #include <scsi/scsi_cmnd.h>
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2011-08-01  3:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01  3:23 Stephen Rothwell [this message]
2011-08-02  7:26 ` linux-next: build warning after merge of the moduleh tree Jens Axboe
2011-08-02  8:35   ` Stephen Rothwell
2011-08-02  8:42     ` Jens Axboe
2011-08-18  5:09 Stephen Rothwell
2011-08-18  8:26 ` Rafael J. Wysocki
2011-08-18  9:27   ` Stephen Rothwell
2011-08-18 20:57     ` Rafael J. Wysocki
2011-09-28  7:18 Stephen Rothwell
2011-09-28  7:39 ` Pihet-XID, Jean
2011-10-11  9:21 Stephen Rothwell
2011-10-11 13:16 ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110801132359.1de051cb8a4a2bdfdad7560c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).