Hi Paul, After merging the moduleh tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/iio/adc/ad7746.c:345:8: error: 'S_IWUSR' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:436:8: error: 'S_IRUGO' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:681:19: error: 'THIS_MODULE' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:778:1: warning: data definition has no type or storage class [enabled by default] drivers/staging/iio/adc/ad7746.c:778:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int] drivers/staging/iio/adc/ad7746.c:778:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/staging/iio/adc/ad7746.c:799:15: error: expected declaration specifiers or '...' before string constant drivers/staging/iio/adc/ad7746.c:800:20: error: expected declaration specifiers or '...' before string constant drivers/staging/iio/adc/ad7746.c:801:16: error: expected declaration specifiers or '...' before string constant Caused by commit 83e416f458d5 ("staging: iio: adc: Replace, rewrite ad7745 from scratch") from the staging tree interacting with the module.h split. I added the following patch: From: Stephen Rothwell Date: Tue, 4 Oct 2011 18:18:28 +1100 Subject: [PATCH] staging: iio: adc: add includes of module.h and stat.h fixes these build problems: drivers/staging/iio/adc/ad7746.c:345:8: error: 'S_IWUSR' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:436:8: error: 'S_IRUGO' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:681:19: error: 'THIS_MODULE' undeclared here (not in a function) drivers/staging/iio/adc/ad7746.c:778:1: warning: data definition has no type or storage class [enabled by default] drivers/staging/iio/adc/ad7746.c:778:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int] drivers/staging/iio/adc/ad7746.c:778:1: warning: parameter names (without types) in function declaration [enabled by default] drivers/staging/iio/adc/ad7746.c:799:15: error: expected declaration specifiers or '...' before string constant drivers/staging/iio/adc/ad7746.c:800:20: error: expected declaration specifiers or '...' before string constant drivers/staging/iio/adc/ad7746.c:801:16: error: expected declaration specifiers or '...' before string constant Signed-off-by: Stephen Rothwell --- drivers/staging/iio/adc/ad7746.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/staging/iio/adc/ad7746.c b/drivers/staging/iio/adc/ad7746.c index 0b251ad..3fe0c17 100644 --- a/drivers/staging/iio/adc/ad7746.c +++ b/drivers/staging/iio/adc/ad7746.c @@ -13,6 +13,8 @@ #include #include #include +#include +#include #include "../iio.h" #include "../sysfs.h" -- 1.7.6.3 -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/