linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warnings after merge of the writeback tree
Date: Tue, 11 Oct 2011 20:27:36 +1100	[thread overview]
Message-ID: <20111011202736.2c0a7ac57a4a5c9c43564f13@canb.auug.org.au> (raw)
In-Reply-To: <20111011091725.GA31349@localhost>

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

Hi,

On Tue, 11 Oct 2011 17:17:25 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> On Tue, Oct 11, 2011 at 04:57:04PM +0800, Stephen Rothwell wrote:
> > 
> > After merging the writeback tree, today's linux-next build (powerpc
> > allnoconfig) produced these warnings:
> > 
> > mm/page-writeback.c: In function 'bdi_position_ratio':
> > mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> > 
> > Introduced by commits 6c14ae1e92c7 ("writeback: dirty position control")
> > and 8927f66c4ede ("writeback: dirty position control - bdi reserve area").
> 
> Ah sorry!  The below patch should fix it. Shall I update the original
> commits in place, or append this patch as a new commit?

That choice is up to you as the maintainer of that tree.  Either works
for me (appending is easier for you and me, and the warning is not a
problem as far as bisection is concerned).

> Fix powerpc compile warnings
> 
> mm/page-writeback.c: In function 'bdi_position_ratio':
> mm/page-writeback.c:622:3: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> page-writeback.c:635:4: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> 
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

If you do keep it separate, you could add a

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

above your SOB line.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-10-11  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11  8:57 linux-next: build warnings after merge of the writeback tree Stephen Rothwell
2011-10-11  9:17 ` Wu Fengguang
2011-10-11  9:27   ` Stephen Rothwell [this message]
2011-10-11  9:33     ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111011202736.2c0a7ac57a4a5c9c43564f13@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).