linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the scsi tree with the s390 tree
@ 2011-10-25  6:16 Stephen Rothwell
  2011-10-25  7:05 ` Martin Schwidefsky
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2011-10-25  6:16 UTC (permalink / raw)
  To: James Bottomley
  Cc: linux-next, linux-kernel, Swen Schillig, Steffen Maier,
	Jan Glauber, Martin Schwidefsky, Heiko Carstens

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

Hi James,

Today's linux-next merge of the scsi tree got a conflict in
drivers/s390/cio/qdio_main.c between commit 9c20b3dd8479 ("[S390] qdio:
EQBS retry after CCQ 96") from the s390 tree and commit dfe5bb506172
("[SCSI] qdio: base support for hardware data router with zfcp") from the
scsi tree.

I fixed it up (see below) and can carry the fix as necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/s390/cio/qdio_main.c
index a108e28,d2c1f1b..0000000
--- a/drivers/s390/cio/qdio_main.c
+++ b/drivers/s390/cio/qdio_main.c
@@@ -145,26 -151,16 +145,28 @@@ again
  		goto again;
  	}
  
 -	if (rc < 0) {
 -		DBF_ERROR("%4x EQBS ERROR", SCH_NO(q));
 -		DBF_ERROR("%3d%3d%2d", count, tmp_count, nr);
 -		q->handler(q->irq_ptr->cdev,
 -			   QDIO_ERROR_ACTIVATE_CHECK_CONDITION,
 -			   q->nr, q->first_to_kick, count,
 -			   q->irq_ptr->int_parm);
 -		return 0;
 +	if (rc == 2) {
 +		BUG_ON(tmp_count == count);
 +		qperf_inc(q, eqbs_partial);
 +		DBF_DEV_EVENT(DBF_WARN, q->irq_ptr, "EQBS part:%02x",
 +			tmp_count);
 +		/*
 +		 * Retry once, if that fails bail out and process the
 +		 * extracted buffers before trying again.
 +		 */
 +		if (!retried++)
 +			goto again;
 +		else
 +			return count - tmp_count;
  	}
 -	return count - tmp_count;
 +
 +	DBF_ERROR("%4x EQBS ERROR", SCH_NO(q));
 +	DBF_ERROR("%3d%3d%2d", count, tmp_count, nr);
- 	q->handler(q->irq_ptr->cdev, QDIO_ERROR_ACTIVATE_CHECK_CONDITION,
- 		   0, -1, -1, q->irq_ptr->int_parm);
++	q->handler(q->irq_ptr->cdev,
++		   QDIO_ERROR_ACTIVATE_CHECK_CONDITION,
++		   q->nr, q->first_to_kick, count,
++		   q->irq_ptr->int_parm);
 +	return 0;
  }
  
  /**
@@@ -207,12 -198,17 +209,12 @@@ again
  		qperf_inc(q, sqbs_partial);
  		goto again;
  	}
 -	if (rc < 0) {
 -		DBF_ERROR("%4x SQBS ERROR", SCH_NO(q));
 -		DBF_ERROR("%3d%3d%2d", count, tmp_count, nr);
 -		q->handler(q->irq_ptr->cdev,
 -			   QDIO_ERROR_ACTIVATE_CHECK_CONDITION,
 -			   q->nr, q->first_to_kick, count,
 -			   q->irq_ptr->int_parm);
 -		return 0;
 -	}
 -	WARN_ON(tmp_count);
 -	return count - tmp_count;
 +
 +	DBF_ERROR("%4x SQBS ERROR", SCH_NO(q));
 +	DBF_ERROR("%3d%3d%2d", count, tmp_count, nr);
 +	q->handler(q->irq_ptr->cdev, QDIO_ERROR_ACTIVATE_CHECK_CONDITION,
- 		   0, -1, -1, q->irq_ptr->int_parm);
++		   q->nr, q->first_to_kick, count, q->irq_ptr->int_parm);
 +	return 0;
  }
  
  /* returns number of examined buffers and their common state in *state */

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: manual merge of the scsi tree with the s390 tree
  2011-10-25  6:16 linux-next: manual merge of the scsi tree with the s390 tree Stephen Rothwell
@ 2011-10-25  7:05 ` Martin Schwidefsky
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2011-10-25  7:05 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: James Bottomley, linux-next, linux-kernel, Swen Schillig,
	Steffen Maier, Jan Glauber, Heiko Carstens

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Tue, 25 Oct 2011 17:16:01 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Today's linux-next merge of the scsi tree got a conflict in
> drivers/s390/cio/qdio_main.c between commit 9c20b3dd8479 ("[S390] qdio:
> EQBS retry after CCQ 96") from the s390 tree and commit dfe5bb506172
> ("[SCSI] qdio: base support for hardware data router with zfcp") from the
> scsi tree.
> 
> I fixed it up (see below) and can carry the fix as necessary.

Looks good. Thanks Stephen.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-25  7:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-25  6:16 linux-next: manual merge of the scsi tree with the s390 tree Stephen Rothwell
2011-10-25  7:05 ` Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).