From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Date: Tue, 6 Dec 2011 11:34:58 +0000 Message-ID: <20111206113458.1c247d79@lxorguk.ukuu.org.uk> References: <20111110162859.GA7088@oksana.dev.rtsoft.ru> <20111202192618.GC3037@localhost.localdomain> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> <20111205184522.316598de@lxorguk.ukuu.org.uk> <20111206061321.GH9192@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111206061321.GH9192-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Jean-Christophe PLAGNIOL-VILLARD Cc: Nicolas Pitre , Stephen Rothwell , Russell King - ARM Linux , Pawel Moll , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Ingo Molnar , LKML , linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Randy Dunlap , linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Anton Vorontsov , Andrew Morton , Linus Torvalds , Jeff Garzik , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-next.vger.kernel.org > can we sinply introduce a macro irq_is_valid See the 2005, 2006 and 2008 discussion. if (!dev->irq) is the proper test. The <= is just a temporary thing while ARM gets its publically visible house in order so it can be done without breakage. Alan