From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the battery tree
Date: Thu, 5 Jan 2012 19:25:36 +0400 [thread overview]
Message-ID: <20120105152536.GB28629@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20120105144042.4e03850089cce56a7e9312e4@canb.auug.org.au>
On Thu, Jan 05, 2012 at 02:40:42PM +1100, Stephen Rothwell wrote:
> Hi Anton,
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "sysfs_create_link_nowarn" [drivers/power/power_supply.ko] undefined!
>
> Caused by commit 8351665195ce ("power_supply: allow a power supply to
> explicitly point to powered device"). That symbol is not exported to
> modules.
>
> I have used the battery tree from next-20120104 for today.
Thanks for catching this, Stephen!
I wonder why do we need to use _nowarn variant?..
Something tells me that we actually want a warning.
Jeremy, are you OK with the patch down below?
- - - -
From: Anton Vorontsov <cbouatmailru@gmail.com>
Subject: power_supply: Drop usage of nowarn variant of sysfs_create_link()
The function is not exported to modules, plus we do want to catch anyone
who tries to create complex hierarchy (in that case we'd need to change
'powers' symlink to a directory, probably under a different name to not
break ABI).
This patch fixes the following build error:
ERROR: "sysfs_create_link_nowarn" [drivers/power/power_supply.ko] undefined!
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
---
drivers/power/power_supply_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c
index b10c121..47f4e11 100644
--- a/drivers/power/power_supply_core.c
+++ b/drivers/power/power_supply_core.c
@@ -149,7 +149,7 @@ EXPORT_SYMBOL_GPL(power_supply_get_by_name);
int power_supply_powers(struct power_supply *psy, struct device *dev)
{
- return sysfs_create_link_nowarn(&psy->dev->kobj, &dev->kobj, "powers");
+ return sysfs_create_link(&psy->dev->kobj, &dev->kobj, "powers");
}
EXPORT_SYMBOL_GPL(power_supply_powers);
--
1.7.7.3
next prev parent reply other threads:[~2012-01-05 15:25 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 3:40 linux-next: build failure after merge of the battery tree Stephen Rothwell
2012-01-05 15:25 ` Anton Vorontsov [this message]
2012-01-05 15:53 ` Greg KH
2012-01-07 9:00 ` Jeremy Fitzhardinge
2012-01-09 2:11 Stephen Rothwell
[not found] <C3AE124F08223B42BC95AEB82F0F6CED1FDB2C78@KCHJEXMB02.kpit.com>
2012-01-09 8:29 ` Ashish Jangam
2012-01-09 13:10 ` linux-next: " Anton Vorontsov
2012-01-09 23:53 ` Mark Brown
2012-01-10 0:51 ` Anton Vorontsov
2012-03-15 2:56 Stephen Rothwell
2012-03-20 4:39 ` Stephen Rothwell
2012-03-26 2:13 ` Stephen Rothwell
2012-03-26 16:11 ` Anton Vorontsov
2012-03-26 21:44 ` Stephen Rothwell
2012-03-26 21:47 ` Stephen Rothwell
2012-03-27 13:03 ` Anton Vorontsov
2012-03-28 11:38 ` Mark Brown
2012-07-16 4:09 Stephen Rothwell
2012-07-16 4:57 ` Chanwoo Choi
2015-07-27 1:40 Stephen Rothwell
2015-09-29 1:45 Stephen Rothwell
2015-10-02 1:49 ` Stephen Rothwell
2015-10-08 1:04 ` Stephen Rothwell
2015-10-08 6:12 ` Belisko Marek
2015-10-08 10:21 ` Stephen Rothwell
2015-10-15 14:26 ` Stephen Rothwell
2015-10-20 22:32 ` Stephen Rothwell
2015-10-21 6:12 ` Belisko Marek
2019-06-28 4:03 Stephen Rothwell
2019-06-28 15:31 ` Sebastian Reichel
2019-06-28 16:56 ` Enric Balletbo i Serra
2019-06-29 0:33 ` Stephen Rothwell
2019-07-01 13:22 ` Enric Balletbo i Serra
2019-12-19 0:01 Stephen Rothwell
2019-12-19 1:35 ` Sebastian Reichel
2022-05-04 2:35 Stephen Rothwell
2022-06-20 0:45 Stephen Rothwell
2022-06-21 12:30 ` Asmaa Mnebhi
2022-06-24 2:47 ` Stephen Rothwell
2022-06-24 12:44 ` Asmaa Mnebhi
2022-06-28 2:30 ` Stephen Rothwell
2023-08-21 2:57 Stephen Rothwell
2023-08-21 7:07 ` Lee Jones
2023-08-21 7:13 ` Lee Jones
2023-08-21 12:41 ` Rob Herring
2023-08-21 12:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105152536.GB28629@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).