Linux-Next Archive on
 help / color / Atom feed
From: Arnd Bergmann <>
To: Stephen Rothwell <>
Cc: Olof Johansson <>,,,, "Turquette,
	Mike" <>
Subject: Re: linux-next: build warning after merge of the arm-soc tree
Date: Mon, 19 Mar 2012 09:40:01 +0000
Message-ID: <> (raw)
In-Reply-To: <>

On Monday 19 March 2012, Stephen Rothwell wrote:
> Hi all,
> After merging the arm-soc tree, today's linux-next build (all)
> produced this warning:
> drivers/clk/Kconfig:22: warning: menuconfig statement without prompt
> Introduced by commit c173033d154e ("clk: make CONFIG_COMMON_CLK invisible").

Thanks for the report. This is clearly my fault for not testing the last
minute patch.
I have now replaced it with the one below and tested that it works
as intended.


commit 8fb61e33507e5d76b69467b4f96290338e96b733
Author: Arnd Bergmann <>
Date:   Sat Mar 17 21:10:51 2012 +0000

    clk: make CONFIG_COMMON_CLK invisible
    All platforms that use the common clk infrastructure should select
    COMMON_CLK from platform code, and on all other platforms, it must
    not be enabled, so there is no point making the option visible to
    users, and when it is visible, we break randconfig builds.
    Signed-off-by: Arnd Bergmann <>

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 2eaf17e..165e1fe 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -9,21 +9,18 @@ config HAVE_CLK_PREPARE
-menuconfig COMMON_CLK
-	bool "Common Clock Framework"
+config COMMON_CLK
+	bool
 	  The common clock framework is a single definition of struct
 	  clk, useful across many platforms, as well as an
 	  implementation of the clock API in include/linux/clk.h.
 	  Architectures utilizing the common struct clk should select
-	  this automatically, but it may be necessary to manually select
-	  this option for loadable modules requiring the common clock
-	  framework.
-	  If in doubt, say "N".
+	  this option.
+menu "Common Clock Framework"
+	depends on COMMON_CLK
 	bool "Disabled unused clocks at boot"
@@ -47,4 +44,4 @@ config COMMON_CLK_DEBUG
 	  clk_flags, clk_prepare_count, clk_enable_count &

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19  7:39 Stephen Rothwell
2012-03-19  9:40 ` Arnd Bergmann [this message]
2014-01-19 23:39 Stephen Rothwell
2019-04-29 23:28 Stephen Rothwell
2019-05-03  6:49 ` Linus Walleij
2019-05-03 12:57   ` Arnd Bergmann
2019-08-15 23:23 Stephen Rothwell
2019-08-15 23:25 Stephen Rothwell
2021-04-06  0:45 Stephen Rothwell
2021-04-06  6:34 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on

Archives are clonable:
	git clone --mirror linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ \
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone