linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: netdev@vger.kernel.org, linux-next@vger.kernel.org,
	linux-kernel@vger.kernel.org, msink@permonline.ru,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)
Date: Tue, 10 Apr 2012 09:26:23 -0400 (EDT)	[thread overview]
Message-ID: <20120410.092623.821622563087500166.davem@davemloft.net> (raw)
In-Reply-To: <20120410152923.15aee4df478d819f167cd4af@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 Apr 2012 15:29:23 +1000

> After merging the final tree, today's linux-next build (s390 allmodconfig)
> failed like this:

I just checked in the following which will hopefully cure this,
thanks:

--------------------
wiznet: Fix Kconfig dependencies.

Both drivers need to depend upon HAS_IOMEM, otherwise we
get a build failure on platforms like S390.

All the driver specific config options need to depend upon
the drivers themselves.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/ethernet/wiznet/Kconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/wiznet/Kconfig b/drivers/net/ethernet/wiznet/Kconfig
index 2bb383c..c8291bf 100644
--- a/drivers/net/ethernet/wiznet/Kconfig
+++ b/drivers/net/ethernet/wiznet/Kconfig
@@ -19,6 +19,7 @@ if NET_VENDOR_WIZNET
 
 config WIZNET_W5100
 	tristate "WIZnet W5100 Ethernet support"
+	depends on HAS_IOMEM
 	---help---
 	  Support for WIZnet W5100 chips.
 
@@ -31,6 +32,7 @@ config WIZNET_W5100
 
 config WIZNET_W5300
 	tristate "WIZnet W5300 Ethernet support"
+	depends on HAS_IOMEM
 	---help---
 	  Support for WIZnet W5300 chips.
 
@@ -43,6 +45,7 @@ config WIZNET_W5300
 
 choice
 	prompt "WIZnet interface mode"
+	depends on WIZNET_W5100 || WIZNET_W5300
 	default WIZNET_BUS_ANY
 
 config WIZNET_BUS_DIRECT
@@ -69,6 +72,7 @@ endchoice
 
 config WIZNET_TX_FLOW
 	bool "Use transmit flow control"
+	depends on WIZNET_W5100 || WIZNET_W5300
 	default y
 	help
 	  This enables transmit flow control for WIZnet chips.
-- 
1.7.7.6

  reply	other threads:[~2012-04-10 13:29 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10  5:29 linux-next: build failure after merge of the final tree (net-next tree related) Stephen Rothwell
2012-04-10 13:26 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-03-18  7:27 Stephen Rothwell
2014-03-19  3:13 ` David Miller
2014-03-17 10:21 Stephen Rothwell
2014-03-19  3:11 ` David Miller
2014-03-17 10:13 Stephen Rothwell
2013-09-02  9:11 Stephen Rothwell
2013-09-02  9:18 ` Cong Wang
2013-07-03  7:48 Stephen Rothwell
2013-07-03  7:51 ` Sedat Dilek
2013-07-03  8:45 ` Eliezer Tamir
2013-07-03 19:17 ` David Miller
2013-06-26  7:56 Stephen Rothwell
2013-06-26  8:07 ` Alexey Brodkin
2013-06-26  8:36   ` David Miller
2013-04-23  7:46 Stephen Rothwell
2013-04-23 17:10 ` David Miller
2013-04-23 23:44 ` David Rientjes
2013-04-12  6:00 Stephen Rothwell
2013-04-12  7:08 ` David Miller
2013-03-28  5:04 Stephen Rothwell
2013-03-28  5:19 ` David Miller
2013-01-03  3:23 Stephen Rothwell
2013-01-03  3:28 ` David Miller
2013-01-03  9:51 ` David Miller
2012-09-20  7:36 Stephen Rothwell
2012-09-20  9:10 ` Mika Westerberg
2012-09-20 20:45   ` David Miller
2012-09-20 22:15     ` Stephen Rothwell
2012-09-20 22:22       ` Benjamin Herrenschmidt
2012-09-20 22:53         ` David Miller
2012-09-21 21:46           ` Benjamin Herrenschmidt
2012-09-22 20:00             ` David Miller
2012-09-22 21:20               ` Benjamin Herrenschmidt
2012-09-20 22:28     ` Stephen Rothwell
2012-09-21  1:37 ` Stephen Rothwell
2012-09-05  5:39 Stephen Rothwell
2012-09-05 21:46 ` David Miller
2012-09-04  6:58 Stephen Rothwell
2012-09-04 18:20 ` David Miller
2012-09-04 19:50   ` Jerry Chu
2012-07-22  6:34 Stephen Rothwell
2012-07-22  7:29 ` Jiri Pirko
2012-05-03  6:16 Stephen Rothwell
2012-05-03  6:26 ` David Miller
2012-04-30  5:58 Stephen Rothwell
2012-04-30 17:22 ` David Miller
2012-04-19  6:28 Stephen Rothwell
2012-04-19  6:40 ` David Miller
2012-04-05  3:25 Stephen Rothwell
2012-04-05  3:59 ` David Miller
2012-04-06  7:09   ` Giuseppe CAVALLARO
2012-04-06  7:30     ` Giuseppe CAVALLARO
2012-02-20  5:15 Stephen Rothwell
2012-02-20  5:46 ` David Miller
2011-12-14  7:07 Stephen Rothwell
2011-12-14 18:35 ` David Miller
2011-11-23  4:00 Stephen Rothwell
2011-11-23 12:09 ` Neil Horman
2011-11-23 23:02   ` Andrew Morton
2011-11-23 23:44     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120410.092623.821622563087500166.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=msink@permonline.ru \
    --cc=netdev@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).