From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: devel@driverdev.osuosl.org,
Frank Mori Hess <fmhess@users.sourceforge.net>,
Sergei Shtylyov <sshtylyov@mvista.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Ian Abbott <abbotti@mev.co.uk>,
linux-next@vger.kernel.org
Subject: Re: [PATCH -next] usb: add usb.h stubs for CONFIG_USB not enabled
Date: Sat, 19 May 2012 09:12:07 -0700 [thread overview]
Message-ID: <20120519161207.GA31712@kroah.com> (raw)
In-Reply-To: <4FB7C028.80406@xenotime.net>
On Sat, May 19, 2012 at 08:45:44AM -0700, Randy Dunlap wrote:
> On 05/19/2012 07:16 AM, Sergei Shtylyov wrote:
>
> > Hello.
> >
> > On 19-05-2012 6:04, Randy Dunlap wrote:
> >
> >> From: Randy Dunlap<rdunlap@xenotime.net>
> >
> >> Add stubs for some usb core functions when CONFIG_USB
> >> is not enabled. This fixes these comedi build errors:
> >
> >> ERROR: "usb_deregister" [drivers/staging/comedi/comedi.ko] undefined!
> >> ERROR: "usb_register_driver" [drivers/staging/comedi/comedi.ko] undefined!
> >
> >> Signed-off-by: Randy Dunlap<rdunlap@xenotime.net>
> >> ---
> >> I am only adding the stubs that are needed for comedi to build.
> >> I expect that more stubs will be needed as more build errors are
> >> found. It seems to me that linux/usb.h might need more (major)
> >> moving of lines to support more stubs in the future.
> >
> >> Documentation/usb/error-codes.txt | 2 ++
> >> include/linux/usb.h | 24 +++++++++++++++++++++++-
> >> 2 files changed, 25 insertions(+), 1 deletion(-)
> >>
> >> --- linux-next-20120518.orig/include/linux/usb.h
> >> +++ linux-next-20120518/include/linux/usb.h
> >> @@ -10,7 +10,7 @@
> >>
> >> #ifdef __KERNEL__
> >>
> >> -#include<linux/errno.h> /* for -ENODEV */
> >> +#include<linux/errno.h> /* for -ENODEV, -ENOSYS */
> >> #include<linux/delay.h> /* for mdelay() */
> >> #include<linux/interrupt.h> /* for in_interrupt() */
> >> #include<linux/list.h> /* for struct list_head */
> >> @@ -515,6 +515,8 @@ static inline struct usb_device *interfa
> >> return to_usb_device(intf->dev.parent);
> >> }
> >>
> >> +#if defined(CONFIG_USB) || defined(CONFIG_USB_MODULE)
> >
> > You can use IS_ENABLED(CONFIG_USB) instead of these two now.
>
>
> I know, but I chose not to do that in case the patch
> needs to be applied to some earlier kernels.
If it did, the person doing that would do the change :)
Please use IS_ENABLED().
thanks,
greg k-h
next prev parent reply other threads:[~2012-05-19 16:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 8:49 linux-next: Tree for May 18 Stephen Rothwell
2012-05-19 0:46 ` [PATCH -next] comedi: fix build when USB is not enabled Randy Dunlap
2012-05-19 0:50 ` Greg Kroah-Hartman
2012-05-19 0:51 ` Randy Dunlap
2012-05-19 2:04 ` [PATCH -next] usb: add usb.h stubs for CONFIG_USB " Randy Dunlap
[not found] ` <4FB6FFBF.6000509-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-05-19 14:16 ` Sergei Shtylyov
2012-05-19 15:45 ` Randy Dunlap
2012-05-19 16:12 ` Greg Kroah-Hartman [this message]
2012-05-19 16:31 ` [PATCH -next v2] " Randy Dunlap
2012-05-21 16:48 ` H Hartley Sweeten
2012-05-19 14:30 ` [PATCH -next] " Alan Stern
2012-05-19 15:48 ` Randy Dunlap
[not found] ` <4FB7C0E4.4000008-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-06-11 23:07 ` Greg Kroah-Hartman
2012-06-11 23:35 ` [PATCH] staging/comedi: fix build for USB " Randy Dunlap
2012-05-19 1:02 ` linux-next: Tree for May 18 (drm drivers and vgacon) Randy Dunlap
2012-05-19 15:40 ` Dave Airlie
2012-05-19 2:16 ` linux-next: Tree for May 18 (edac) Randy Dunlap
2012-05-19 12:03 ` Mauro Carvalho Chehab
2012-05-19 15:50 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120519161207.GA31712@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).