[Just bring this to the attention of the PowerPC folks ...] On Thu, 20 Sep 2012 16:45:58 -0400 (EDT) David Miller wrote: > > From: Mika Westerberg > Date: Thu, 20 Sep 2012 12:10:14 +0300 > > > On Thu, Sep 20, 2012 at 05:36:22PM +1000, Stephen Rothwell wrote: > >> Hi all, > >> > >> After merging the final tree, today's linux-next build (powerpc > >> allyesconfig) failed like this: > >> > >> drivers/net/ethernet/i825xx/znet.c: In function 'hardware_init': > >> drivers/net/ethernet/i825xx/znet.c:868:2: error: implicit declaration of function 'isa_virt_to_bus' [-Werror=implicit-function-declaration] > >> > >> Caused by commit 1d3ff76759b7 ("i825xx: znet: fix compiler warnings when > >> building a 64-bit kernel"). Is there some Kconfig dependency missing (CONFIG_ISA)? > > > > If we make it dependent on CONFIG_ISA then the driver cannot be built with > > 64-bit kernel. Then again is there someone running 64-bit kernel on Zenith > > Z-note notebook? From the pictures it looks like very ancient "laptop". > > > > An alternative is to make it depend on X86 like this: > > I think the powerpc port is at fault here. > > Part of being able to advertise ISA_DMA_API is providing isa_virt_to_bus(). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au