Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bill Pemberton <wfp5p@virginia.edu>, Greg KH <greg@kroah.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: linux-next: manual merge of the gpio tree with the driver-core tree
Date: Thu, 29 Nov 2012 15:57:23 +1100
Message-ID: <20121129155723.60035c6419fd9a00f46e4d69@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

Hi Grant,

Today's linux-next merge of the gpio tree got a conflict in
drivers/gpio/gpio-em.c between commit 3836309d9346 ("gpio: remove use of
__devinit") from the driver-core tree and commit 7385500a49b7 ("gpio/em:
convert to linear IRQ domain") from the gpio tree.

I fixed it up (see below) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/gpio/gpio-em.c
index 320a718,b007063..0000000
--- a/drivers/gpio/gpio-em.c
+++ b/drivers/gpio/gpio-em.c
@@@ -234,41 -233,7 +233,7 @@@ static struct irq_domain_ops em_gio_irq
  	.map	= em_gio_irq_domain_map,
  };
  
- static int __devinit em_gio_irq_domain_init(struct em_gio_priv *p)
- {
- 	struct platform_device *pdev = p->pdev;
- 	struct gpio_em_config *pdata = pdev->dev.platform_data;
- 
- 	p->irq_base = irq_alloc_descs(pdata->irq_base, 0,
- 				      pdata->number_of_pins, numa_node_id());
- 	if (p->irq_base < 0) {
- 		dev_err(&pdev->dev, "cannot get irq_desc\n");
- 		return p->irq_base;
- 	}
- 	pr_debug("gio: hw base = %d, nr = %d, sw base = %d\n",
- 		 pdata->gpio_base, pdata->number_of_pins, p->irq_base);
- 
- 	p->irq_domain = irq_domain_add_legacy(pdev->dev.of_node,
- 					      pdata->number_of_pins,
- 					      p->irq_base, 0,
- 					      &em_gio_irq_domain_ops, p);
- 	if (!p->irq_domain) {
- 		irq_free_descs(p->irq_base, pdata->number_of_pins);
- 		return -ENXIO;
- 	}
- 
- 	return 0;
- }
- 
- static void em_gio_irq_domain_cleanup(struct em_gio_priv *p)
- {
- 	struct gpio_em_config *pdata = p->pdev->dev.platform_data;
- 
- 	irq_free_descs(p->irq_base, pdata->number_of_pins);
- 	/* FIXME: irq domain wants to be freed! */
- }
- 
 -static int __devinit em_gio_probe(struct platform_device *pdev)
 +static int em_gio_probe(struct platform_device *pdev)
  {
  	struct gpio_em_config *pdata = pdev->dev.platform_data;
  	struct em_gio_priv *p;

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29  4:57 Stephen Rothwell [this message]
2012-11-29  5:17 ` Greg KH
2012-11-30  0:01 ` Grant Likely
2019-11-07  4:05 Stephen Rothwell

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121129155723.60035c6419fd9a00f46e4d69@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=grant.likely@secretlab.ca \
    --cc=greg@kroah.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git