linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the usb tree
@ 2013-01-28 10:46 Stephen Rothwell
  2013-01-28 14:45 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2013-01-28 10:46 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Lan Tianyu

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/usb/core/usb-acpi.c: In function 'usb_acpi_register_power_resources':
drivers/usb/core/usb-acpi.c:226:2: error: implicit declaration of function 'acpi_power_resource_register_device' [-Werror=implicit-function-declaration]
drivers/usb/core/usb-acpi.c: In function 'usb_acpi_unregister_power_resources':
drivers/usb/core/usb-acpi.c:234:3: error: implicit declaration of function 'acpi_power_resource_unregister_device' [-Werror=implicit-function-declaration]

Caused by commit 88bb965ed711 ("usb: Register usb port's acpi power
resources").

I have used the usb tree from next-20130125 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2023-10-04  2:22 Stephen Rothwell
  2023-10-04  6:43 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2023-10-04  2:22 UTC (permalink / raw)
  To: Greg KH
  Cc: Greg Kroah-Hartman, Rohit Agarwal, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 10310 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/phy/qualcomm/phy-qcom-qmp-usb.c:156:43: error: 'QPHY_V6_PCS_SW_RESET' undeclared here (not in a function); did you mean 'QPHY_V2_PCS_SW_RESET'?
  156 |         [QPHY_SW_RESET]                 = QPHY_V6_PCS_SW_RESET,
      |                                           ^~~~~~~~~~~~~~~~~~~~
      |                                           QPHY_V2_PCS_SW_RESET
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:157:43: error: 'QPHY_V6_PCS_START_CONTROL' undeclared here (not in a function); did you mean 'QPHY_V3_PCS_START_CONTROL'?
  157 |         [QPHY_START_CTRL]               = QPHY_V6_PCS_START_CONTROL,
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           QPHY_V3_PCS_START_CONTROL
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:158:43: error: 'QPHY_V6_PCS_PCS_STATUS1' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_PCS_STATUS1'?
  158 |         [QPHY_PCS_STATUS]               = QPHY_V6_PCS_PCS_STATUS1,
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~
      |                                           QPHY_V5_PCS_PCS_STATUS1
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:159:43: error: 'QPHY_V6_PCS_POWER_DOWN_CONTROL' undeclared here (not in a function); did you mean 'QPHY_V3_PCS_POWER_DOWN_CONTROL'?
  159 |         [QPHY_PCS_POWER_DOWN_CONTROL]   = QPHY_V6_PCS_POWER_DOWN_CONTROL,
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           QPHY_V3_PCS_POWER_DOWN_CONTROL
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:162:43: error: 'QPHY_V6_PCS_USB3_AUTONOMOUS_MODE_CTRL' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_USB3_AUTONOMOUS_MODE_CTRL'?
  162 |         [QPHY_PCS_AUTONOMOUS_MODE_CTRL] = QPHY_V6_PCS_USB3_AUTONOMOUS_MODE_CTRL,
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           QPHY_V5_PCS_USB3_AUTONOMOUS_MODE_CTRL
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:163:44: error: 'QPHY_V6_PCS_USB3_LFPS_RXTERM_IRQ_CLEAR' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_USB3_LFPS_RXTERM_IRQ_CLEAR'?
  163 |         [QPHY_PCS_LFPS_RXTERM_IRQ_CLEAR] = QPHY_V6_PCS_USB3_LFPS_RXTERM_IRQ_CLEAR,
      |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                            QPHY_V5_PCS_USB3_LFPS_RXTERM_IRQ_CLEAR
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:991:26: error: 'QPHY_V6_PCS_LOCK_DETECT_CONFIG1' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_LOCK_DETECT_CONFIG1'?
  991 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_LOCK_DETECT_CONFIG1, 0xc4),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:992:26: error: 'QPHY_V6_PCS_LOCK_DETECT_CONFIG2' undeclared here (not in a function); did you mean 'QPHY_V3_PCS_LOCK_DETECT_CONFIG2'?
  992 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_LOCK_DETECT_CONFIG2, 0x89),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:993:26: error: 'QPHY_V6_PCS_LOCK_DETECT_CONFIG3' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_LOCK_DETECT_CONFIG3'?
  993 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_LOCK_DETECT_CONFIG3, 0x20),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:994:26: error: 'QPHY_V6_PCS_LOCK_DETECT_CONFIG6' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_LOCK_DETECT_CONFIG6'?
  994 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_LOCK_DETECT_CONFIG6, 0x13),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:997:26: error: 'QPHY_V6_PCS_RCVR_DTCT_DLY_P1U2_L' undeclared here (not in a function); did you mean 'QPHY_V3_PCS_RCVR_DTCT_DLY_P1U2_L'?
  997 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_RCVR_DTCT_DLY_P1U2_L, 0xe7),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:998:26: error: 'QPHY_V6_PCS_RCVR_DTCT_DLY_P1U2_H' undeclared here (not in a function); did you mean 'QPHY_V3_PCS_RCVR_DTCT_DLY_P1U2_H'?
  998 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_RCVR_DTCT_DLY_P1U2_H, 0x03),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:999:26: error: 'QPHY_V6_PCS_CDR_RESET_TIME' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_CDR_RESET_TIME'?
  999 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_CDR_RESET_TIME, 0x0a),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1000:26: error: 'QPHY_V6_PCS_ALIGN_DETECT_CONFIG1' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_ALIGN_DETECT_CONFIG1'?
 1000 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_ALIGN_DETECT_CONFIG1, 0x88),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1001:26: error: 'QPHY_V6_PCS_ALIGN_DETECT_CONFIG2' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_ALIGN_DETECT_CONFIG2'?
 1001 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_ALIGN_DETECT_CONFIG2, 0x13),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1003:26: error: 'QPHY_V6_PCS_EQ_CONFIG1' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_EQ_CONFIG1'?
 1003 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_EQ_CONFIG1, 0x4b),
      |                          ^~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1004:26: error: 'QPHY_V6_PCS_EQ_CONFIG5' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_EQ_CONFIG5'?
 1004 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_EQ_CONFIG5, 0x10),
      |                          ^~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1008:26: error: 'QPHY_V6_PCS_USB3_LFPS_DET_HIGH_COUNT_VAL' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_USB3_LFPS_DET_HIGH_COUNT_VAL'?
 1008 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB3_LFPS_DET_HIGH_COUNT_VAL, 0xf8),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1009:26: error: 'QPHY_V6_PCS_USB3_RXEQTRAINING_DFE_TIME_S2' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_USB3_RXEQTRAINING_DFE_TIME_S2'?
 1009 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB3_RXEQTRAINING_DFE_TIME_S2, 0x07),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1010:26: error: 'QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_L' undeclared here (not in a function); did you mean 'QPHY_V4_PCS_USB3_RCVR_DTCT_DLY_U3_L'?
 1010 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_L, 0x40),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:1011:26: error: 'QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_H' undeclared here (not in a function); did you mean 'QPHY_V5_PCS_USB3_RCVR_DTCT_DLY_U3_H'?
 1011 |         QMP_PHY_INIT_CFG(QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_H, 0x00),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-usb.c:78:27: note: in definition of macro 'QMP_PHY_INIT_CFG'
   78 |                 .offset = o,            \
      |                           ^

Caused by commit

  685dbd1b2306 ("phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support")

I have used the usb tree from next-20231003 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2023-03-27  5:02 Stephen Rothwell
  2023-03-27  7:37 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2023-03-27  5:02 UTC (permalink / raw)
  To: Greg KH
  Cc: Greg Kroah-Hartman, Josue David Hernandez Gutierrez,
	Mathias Nyman, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (s390 allmodconfig)
failed like this:

drivers/usb/host/xhci-pci.c:91:13: error: 'xhci_msix_sync_irqs' defined but not used [-Werror=unused-function]

(reported here: http://kisskb.ellerman.id.au/kisskb/buildresult/14902506/)

Caused by commit

  9abe15d55dcc ("xhci: Move xhci MSI sync function to to xhci-pci")

The function is only called if CONFIG_PM is set, but defined
unconditionally.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2022-11-30  2:18 Stephen Rothwell
  2022-11-30 10:52 ` Greg KH
  2022-11-30 10:53 ` Andy Shevchenko
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2022-11-30  2:18 UTC (permalink / raw)
  To: Greg KH
  Cc: Andy Shevchenko, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/xen/unpopulated-alloc.c:17:21: error: 'list_count' redeclared as different kind of symbol
   17 | static unsigned int list_count;
      |                     ^~~~~~~~~~
In file included from include/linux/preempt.h:11,
                 from include/linux/spinlock.h:56,
                 from include/linux/mmzone.h:8,
                 from include/linux/gfp.h:7,
                 from drivers/xen/unpopulated-alloc.c:3:
include/linux/list.h:662:22: note: previous definition of 'list_count' with type 'size_t(struct list_head *)' {aka 'long unsigned int(struct list_head *)'}
  662 | static inline size_t list_count(struct list_head *head)
      |                      ^~~~~~~~~~

Caused by commit

  a9efc04cfd05 ("i915: Move list_count() to list.h for broader use")

I have used the usb tree from next-20221129 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2022-07-18  6:31 Stephen Rothwell
  2022-07-18 20:43 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2022-07-18  6:31 UTC (permalink / raw)
  To: Greg KH, Benson Leung, Guenter Roeck, Dmitry Torokhov
  Cc: Prashant Malani, Tzung-Bi Shih, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/platform/chrome/cros_typec_switch.c: In function 'cros_typec_cmd_mux_set':
drivers/platform/chrome/cros_typec_switch.c:52:16: error: implicit declaration of function 'cros_ec_command'; did you mean 'cros_ec_cmd'? [-Werror=implicit-function-declaration]
   52 |         return cros_ec_command(sdata->ec, 0, EC_CMD_TYPEC_CONTROL, &req,
      |                ^~~~~~~~~~~~~~~
      |                cros_ec_cmd
drivers/platform/chrome/cros_typec_switch.c: In function 'cros_typec_register_switches':
drivers/platform/chrome/cros_typec_switch.c:244:23: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
  244 |                 ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
      |                       ^~~~~~~~~~~~~~~~~~~~~
      |                       acpi_evaluate_object
drivers/platform/chrome/cros_typec_switch.c:244:49: error: invalid use of undefined type 'struct acpi_device'
  244 |                 ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
      |                                                 ^~

Caused by commit

  e54369058f3d ("platform/chrome: cros_typec_switch: Add switch driver")

and commits

  34f375f0fdf6 ("platform/chrome: cros_typec_switch: Set EC retimer")
  bb53ad958012 ("platform/chrome: cros_typec_switch: Add event check")

interacting with commit

  b1d288d9c3c5 ("platform/chrome: cros_ec_proto: Rename cros_ec_command function")

from the chrome-platform tree.

I have used the usb tree from next-20220715 for today.

I will fix up the cros_ec_command() rename with a merge fix patch after
the apci usage problem is solved.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2022-06-14  2:08 Stephen Rothwell
  2022-06-14  2:41 ` Neal Liu
  2022-06-14  6:41 ` Greg KH
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2022-06-14  2:08 UTC (permalink / raw)
  To: Greg KH; +Cc: Neal Liu, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:


Caused by commit

  2cee50bf4590 ("ARM: dts: aspeed: Add USB2.0 device controller node")

I have used the usb tree from next-20220610 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2022-05-02 11:07 Stephen Rothwell
  2022-05-02 11:40 ` Greg KH
  2022-05-03 14:49 ` Greg KH
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2022-05-02 11:07 UTC (permalink / raw)
  To: Greg KH
  Cc: Matthias Kaehlcke, Ravi Chandra Sadineni,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (x86_64
modules_install) failed like this:

depmod: ERROR: Cycle detected: usbcore -> onboard_usb_hub -> usbcore
depmod: ERROR: Found 2 modules in dependency cycles!

Caused by commit

  c40b62216c1a ("usb: core: hcd: Create platform devices for onboard hubs in probe()")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2021-04-12 11:36 Stephen Rothwell
  2021-04-12 12:35 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2021-04-12 11:36 UTC (permalink / raw)
  To: Greg KH
  Cc: Heikki Krogerus, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (x86_64 almodconfig
modules_install) failed like this:

depmod: ERROR: Cycle detected: usbcore -> typec -> usbcore
depmod: ERROR: Found 2 modules in dependency cycles!

Caused by commit

  63cd78617350 ("usb: Link the ports to the connectors they are attached to")

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2020-03-16  3:10 Stephen Rothwell
  2020-03-16 11:30 ` Thierry Reding
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2020-03-16  3:10 UTC (permalink / raw)
  To: Greg KH, Colin Cross, Olof Johansson, Thierry Reding
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Nagarjuna Kristam, Heikki Krogerus

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/phy/tegra/xusb.c: In function 'tegra_xusb_setup_usb_role_switch':
drivers/phy/tegra/xusb.c:641:10: error: initialization of 'int (*)(struct usb_role_switch *, enum usb_role)' from incompatible pointer type 'int (*)(struct device *, enum usb_role)' [-Werror=incompatible-pointer-types]
  641 |   .set = tegra_xusb_role_sw_set,
      |          ^~~~~~~~~~~~~~~~~~~~~~
drivers/phy/tegra/xusb.c:641:10: note: (near initialization for 'role_sx_desc.set')

Caused by commit

  bce3052f0c16 ("usb: roles: Provide the switch drivers handle to the switch in the API")

interacting with commit

  5a00c7c7604f ("phy: tegra: xusb: Add usb-role-switch support")

from the tegra tree.

I have added this merge fix patch (which may need more work):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 16 Mar 2020 14:04:20 +1100
Subject: [PATCH] phy: tegra: fix up for set_role API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/phy/tegra/xusb.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index d907f03bf282..25223c350e66 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -596,11 +596,12 @@ static void tegra_xusb_usb_phy_work(struct work_struct *work)
 	atomic_notifier_call_chain(&port->usb_phy.notifier, 0, &port->usb_phy);
 }
 
-static int tegra_xusb_role_sw_set(struct device *dev, enum usb_role role)
+static int tegra_xusb_role_sw_set(struct usb_role_switch *sw,
+				  enum usb_role role)
 {
-	struct tegra_xusb_port *port = dev_get_drvdata(dev);
+	struct tegra_xusb_port *port = usb_role_switch_get_drvdata(sw);
 
-	dev_dbg(dev, "%s(): role %s\n", __func__, usb_roles[role]);
+	dev_dbg(&port->dev, "%s(): role %s\n", __func__, usb_roles[role]);
 
 	schedule_work(&port->usb_phy_work);
 
-- 
2.25.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2019-06-19  6:43 Stephen Rothwell
  2019-06-19 14:56 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2019-06-19  6:43 UTC (permalink / raw)
  To: Greg KH
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Dmitry Torokhov, Masahiro Yamada, Alan Stern

[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]

Hi all,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from usr/include/linux/usbdevice_fs.hdrtest.c:1:
./usr/include/linux/usbdevice_fs.h:88:2: error: unknown type name 'u8'
  u8 num_ports;  /* Number of ports the device is connected */
  ^~
./usr/include/linux/usbdevice_fs.h:92:2: error: unknown type name 'u8'
  u8 ports[7];  /* List of ports on the way from the root  */
  ^~

Caused by commit

  6d101f24f1dd ("USB: add usbfs ioctl to retrieve the connection parameters")

Presumably exposed by commit

  b91976b7c0e3 ("kbuild: compile-test UAPI headers to ensure they are self-contained")

from the kbuild tree.

I have added this patch for now:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 19 Jun 2019 16:36:16 +1000
Subject: [PATCH] USB: fix types in uapi include

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/uapi/linux/usbdevice_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/usbdevice_fs.h b/include/uapi/linux/usbdevice_fs.h
index 4b267fe3776e..78efe870c2b7 100644
--- a/include/uapi/linux/usbdevice_fs.h
+++ b/include/uapi/linux/usbdevice_fs.h
@@ -85,11 +85,11 @@ struct usbdevfs_conninfo_ex {
 				/* kernel, the device is connected to.     */
 	__u32 devnum;           /* Device address on the bus.              */
 	__u32 speed;		/* USB_SPEED_* constants from ch9.h        */
-	u8 num_ports;		/* Number of ports the device is connected */
+	__u8 num_ports;		/* Number of ports the device is connected */
 				/* to on the way to the root hub. It may   */
 				/* be bigger than size of 'ports' array so */
 				/* userspace can detect overflows.         */
-	u8 ports[7];		/* List of ports on the way from the root  */
+	__u8 ports[7];		/* List of ports on the way from the root  */
 				/* hub to the device. Current limit in     */
 				/* USB specification is 7 tiers (root hub, */
 				/* 5 intermediate hubs, device), which     */
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2014-12-01  8:19 Stephen Rothwell
  2014-12-02 18:12 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2014-12-01  8:19 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Heikki Krogerus, Kishon Vijay Abraham I

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arch/arm/mach-omap2/twl-common.c:94:21: error: array type has incomplete element type
 struct phy_consumer consumers[] = {
                     ^

Caused by commit dbc98635e0d4 ("phy: remove the old lookup method").

I have used the usb tree from next-20141128 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2014-07-24  7:07 Stephen Rothwell
  2014-07-24  7:44 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2014-07-24  7:07 UTC (permalink / raw)
  To: Greg KH, Olof Johansson, Arnd Bergmann, linux-arm-kernel
  Cc: linux-next, linux-kernel, Pratyush Anand, Viresh Kumar, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 6699 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/phy/phy-spear1310-miphy.c: In function 'spear1310_miphy_probe':
drivers/phy/phy-spear1310-miphy.c:232:14: warning: passing argument 2 of 'devm_phy_create' from incompatible pointer type
  priv->phy = devm_phy_create(dev, &spear1310_miphy_ops, NULL);
              ^
In file included from drivers/phy/phy-spear1310-miphy.c:21:0:
include/linux/phy/phy.h:164:13: note: expected 'struct device_node *' but argument is of type 'struct phy_ops *'
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^
drivers/phy/phy-spear1310-miphy.c:232:14: error: too few arguments to function 'devm_phy_create'
  priv->phy = devm_phy_create(dev, &spear1310_miphy_ops, NULL);
              ^
In file included from drivers/phy/phy-spear1310-miphy.c:21:0:
include/linux/phy/phy.h:164:13: note: declared here
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^
drivers/phy/phy-spear1340-miphy.c: In function 'spear1340_miphy_probe':
drivers/phy/phy-spear1340-miphy.c:264:14: warning: passing argument 2 of 'devm_phy_create' from incompatible pointer type
  priv->phy = devm_phy_create(dev, &spear1340_miphy_ops, NULL);
              ^
In file included from drivers/phy/phy-spear1340-miphy.c:21:0:
include/linux/phy/phy.h:164:13: note: expected 'struct device_node *' but argument is of type 'struct phy_ops *'
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^
drivers/phy/phy-spear1340-miphy.c:264:14: error: too few arguments to function 'devm_phy_create'
  priv->phy = devm_phy_create(dev, &spear1340_miphy_ops, NULL);
              ^
In file included from drivers/phy/phy-spear1340-miphy.c:21:0:
include/linux/phy/phy.h:164:13: note: declared here
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^

Caused by commit f0ed817638b5 ("phy: core: Let node ptr of PHY point to
PHY and not of PHY provider") interacting with commit 64562e99477f
("phy: Add drivers for PCIe and SATA phy on SPEAr13xx") from the
arm-soc tree.

I fixed that up and then got:

drivers/pinctrl/pinctrl-tegra-xusb.c: In function 'tegra_xusb_padctl_probe':
drivers/pinctrl/pinctrl-tegra-xusb.c:913:8: warning: passing argument 2 of 'devm_phy_create' from incompatible pointer type
  phy = devm_phy_create(&pdev->dev, &pcie_phy_ops, NULL);
        ^
In file included from drivers/pinctrl/pinctrl-tegra-xusb.c:18:0:
include/linux/phy/phy.h:164:13: note: expected 'struct device_node *' but argument is of type 'const struct phy_ops *'
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^
drivers/pinctrl/pinctrl-tegra-xusb.c:913:8: error: too few arguments to function 'devm_phy_create'
  phy = devm_phy_create(&pdev->dev, &pcie_phy_ops, NULL);
        ^
In file included from drivers/pinctrl/pinctrl-tegra-xusb.c:18:0:
include/linux/phy/phy.h:164:13: note: declared here
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^
drivers/pinctrl/pinctrl-tegra-xusb.c:922:8: warning: passing argument 2 of 'devm_phy_create' from incompatible pointer type
  phy = devm_phy_create(&pdev->dev, &sata_phy_ops, NULL);
        ^
In file included from drivers/pinctrl/pinctrl-tegra-xusb.c:18:0:
include/linux/phy/phy.h:164:13: note: expected 'struct device_node *' but argument is of type 'const struct phy_ops *'
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^
drivers/pinctrl/pinctrl-tegra-xusb.c:922:8: error: too few arguments to function 'devm_phy_create'
  phy = devm_phy_create(&pdev->dev, &sata_phy_ops, NULL);
        ^
In file included from drivers/pinctrl/pinctrl-tegra-xusb.c:18:0:
include/linux/phy/phy.h:164:13: note: declared here
 struct phy *devm_phy_create(struct device *dev, struct device_node *node,
             ^

From an interaction with commit dc0a39386687 ("pinctrl: Add NVIDIA
Tegra XUSB pad controller support") from the arm-soc tree.

Final merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 24 Jul 2014 16:55:16 +1000
Subject: [PATCH] phy: fix up for devm_phy_create api change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/phy/phy-spear1310-miphy.c    | 2 +-
 drivers/phy/phy-spear1340-miphy.c    | 2 +-
 drivers/pinctrl/pinctrl-tegra-xusb.c | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
index c58c869d57e0..6dcbfcddb372 100644
--- a/drivers/phy/phy-spear1310-miphy.c
+++ b/drivers/phy/phy-spear1310-miphy.c
@@ -229,7 +229,7 @@ static int spear1310_miphy_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	priv->phy = devm_phy_create(dev, &spear1310_miphy_ops, NULL);
+	priv->phy = devm_phy_create(dev, NULL, &spear1310_miphy_ops, NULL);
 	if (IS_ERR(priv->phy)) {
 		dev_err(dev, "failed to create SATA PCIe PHY\n");
 		return PTR_ERR(priv->phy);
diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c
index 8de98adf21c3..7135ba2603b6 100644
--- a/drivers/phy/phy-spear1340-miphy.c
+++ b/drivers/phy/phy-spear1340-miphy.c
@@ -261,7 +261,7 @@ static int spear1340_miphy_probe(struct platform_device *pdev)
 		return PTR_ERR(priv->misc);
 	}
 
-	priv->phy = devm_phy_create(dev, &spear1340_miphy_ops, NULL);
+	priv->phy = devm_phy_create(dev, NULL, &spear1340_miphy_ops, NULL);
 	if (IS_ERR(priv->phy)) {
 		dev_err(dev, "failed to create SATA PCIe PHY\n");
 		return PTR_ERR(priv->phy);
diff --git a/drivers/pinctrl/pinctrl-tegra-xusb.c b/drivers/pinctrl/pinctrl-tegra-xusb.c
index 4a7daf577b49..a06620474845 100644
--- a/drivers/pinctrl/pinctrl-tegra-xusb.c
+++ b/drivers/pinctrl/pinctrl-tegra-xusb.c
@@ -910,7 +910,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
 		goto reset;
 	}
 
-	phy = devm_phy_create(&pdev->dev, &pcie_phy_ops, NULL);
+	phy = devm_phy_create(&pdev->dev, NULL, &pcie_phy_ops, NULL);
 	if (IS_ERR(phy)) {
 		err = PTR_ERR(phy);
 		goto unregister;
@@ -919,7 +919,7 @@ static int tegra_xusb_padctl_probe(struct platform_device *pdev)
 	padctl->phys[TEGRA_XUSB_PADCTL_PCIE] = phy;
 	phy_set_drvdata(phy, padctl);
 
-	phy = devm_phy_create(&pdev->dev, &sata_phy_ops, NULL);
+	phy = devm_phy_create(&pdev->dev, NULL, &sata_phy_ops, NULL);
 	if (IS_ERR(phy)) {
 		err = PTR_ERR(phy);
 		goto unregister;
-- 
2.0.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply related	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2014-05-29  9:01 Stephen Rothwell
  2014-05-29 18:18 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2014-05-29  9:01 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Dan Williams

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (sparc64 defconfig)
failed like this:

drivers/usb/core/hub.c: In function 'port_event':
drivers/usb/core/hub.c:4853:2: error: implicit declaration of function 'hub_handle_remote_wakeup' [-Werror=implicit-function-declaration]

Caused by commits af376a461cf0 ("usb: refactor port handling in
hub_events()") and 7e73be227b15 ("usb: hub_handle_remote_wakeup()
depends on CONFIG_PM_RUNTIME=y") This build has CONFIG_PM not set ...

I have added this fix patch for today (there is probably a better way):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 29 May 2014 18:55:06 +1000
Subject: [PATCH] usb: hub_handle_remote_wakeup() only exists for CONFIG_PM=y

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/core/hub.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 5672752bfd2c..879b66e13370 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3977,6 +3977,12 @@ EXPORT_SYMBOL_GPL(usb_disable_ltm);
 void usb_enable_ltm(struct usb_device *udev) { }
 EXPORT_SYMBOL_GPL(usb_enable_ltm);
 
+static int hub_handle_remote_wakeup(struct usb_hub *hub, unsigned int port,
+		u16 portstatus, u16 portchange)
+{
+	return 0;
+}
+
 #endif	/* CONFIG_PM */
 
 
-- 
2.0.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2013-04-18  6:05 Stephen Rothwell
  2013-04-18 16:06 ` Joe Perches
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2013-04-18  6:05 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Joe Perches

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-usbat.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-sddr55.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-sddr09.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-realtek.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-karma.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-jumpshot.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-isd200.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-freecom.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-eneub6250.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-datafab.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-cypress.ko] undefined!
ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-alauda.ko] undefined!

Caused by commit 75b9130e8af6 ("usb: storage: Add usb_stor_dbg, reduce
object size").  Please build test such infrastructure patches with and
without MODULES ...

I have used the usb tree from next-20130417 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2013-03-27  3:41 Stephen Rothwell
  2013-03-27  3:51 ` Ming Lei
  2013-03-28 18:04 ` Greg KH
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2013-03-27  3:41 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Johan Hovold, Ming Lei

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/usb/serial/usb-serial.c: In function 'usb_serial_probe':
drivers/usb/serial/usb-serial.c:887:3: error: 'struct usb_serial_port' has no member named 'delta_msr_wait'

Caused by commit eba0e3c3a0ba ("USB: serial: fix hang when opening port")
fro the usb.current tree interacting with commit 53ab34dc50ad ("USB:
serial: remove unused MSR-wait queue") from the usb tree.

I have reverted the commit from usb.current on the assumption that the
problem it solves has been, or will be, solved some other way.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2013-01-21  4:21 Stephen Rothwell
  2013-01-21  8:37 ` Lan, Tianyu
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2013-01-21  4:21 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Lan Tianyu

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/usb/core/port.c: In function 'usb_port_device_release':
drivers/usb/core/port.c:25:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
drivers/usb/core/port.c: In function 'usb_hub_create_port_device':
drivers/usb/core/port.c:38:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
drivers/usb/core/port.c:38:11: warning: assignment makes pointer from integer without a cast [enabled by default]

Caused by commit 6e30d7cba992 ("usb: Add driver/usb/core/(port.c,hub.h)
files").  See Rule 1 in Documentation/SubmitChecklist.

I have used the usb tree from next-20130118 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2012-09-19  4:31 Stephen Rothwell
  2012-09-19  7:17 ` Greg KH
  2012-09-19 13:59 ` Alan Cox
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2012-09-19  4:31 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Alan Cox

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/usb/serial/vizzini.c: In function 'vizzini_set_termios':
drivers/usb/serial/vizzini.c:454:22: error: invalid type argument of '->' (have 'struct ktermios')

Caused by commit c05fecb1d57e ("USB: serial: add vizzini driver")
interacting with commit adc8d746caa6 ("tty: move the termios object into
the tty") from the tty tree.

I added the following merge fix patch and can carry it as necessary:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 19 Sep 2012 14:27:39 +1000
Subject: [PATCH] USB: serial: fix vizzini driver for move of the termios
 object

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/usb/serial/vizzini.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/serial/vizzini.c b/drivers/usb/serial/vizzini.c
index 2ac48fe..253eaf8 100644
--- a/drivers/usb/serial/vizzini.c
+++ b/drivers/usb/serial/vizzini.c
@@ -451,7 +451,7 @@ static void vizzini_set_termios(struct tty_struct *tty_param,
 	unsigned int             format_size, format_parity, format_stop, flow, gpio_mode;
 	struct tty_struct       *tty = port->port.tty;
 
-	cflag = tty->termios->c_cflag;
+	cflag = tty->termios.c_cflag;
 
 	portdata->clocal = ((cflag & CLOCAL) != 0);
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2012-05-21  6:22 Stephen Rothwell
  2012-05-21 12:56 ` Sarah Sharp
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2012-05-21  6:22 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Sarah Sharp

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/usb/core/hub.c: In function 'usb_disable_lpm':
drivers/usb/core/hub.c:3394:2: error: implicit declaration of function 'usb_enable_lpm' [-Werror=implicit-function-declaration]
drivers/usb/core/hub.c: At top level:
drivers/usb/core/hub.c:3424:6: warning: conflicting types for 'usb_enable_lpm' [enabled by default]
drivers/usb/core/hub.c:3394:2: note: previous implicit declaration of 'usb_enable_lpm' was here
drivers/usb/core/driver.c: In function 'usb_probe_interface':
drivers/usb/core/driver.c:339:2: error: implicit declaration of function 'usb_unlocked_disable_lpm' [-Werror=implicit-function-declaration]
drivers/usb/core/driver.c:364:3: error: implicit declaration of function 'usb_unlocked_enable_lpm' [-Werror=implicit-function-declaration]
drivers/usb/core/message.c: In function 'usb_set_interface':
drivers/usb/core/message.c:1314:2: error: implicit declaration of function 'usb_disable_lpm' [-Werror=implicit-function-declaration]
drivers/usb/core/message.c:1323:3: error: implicit declaration of function 'usb_enable_lpm' [-Werror=implicit-function-declaration]
drivers/usb/core/message.c:1368:2: error: implicit declaration of function 'usb_unlocked_enable_lpm' [-Werror=implicit-function-declaration]

Caused by commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical
sections").

I have used the usb tree from next-20120518 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2012-04-27  4:12 Stephen Rothwell
  2012-04-27 18:25 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2012-04-27  4:12 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from drivers/usb/host/ohci-hcd.c:1079:0:
drivers/usb/host/ohci-ps3.c: In function 'ps3_ohci_hc_start':
drivers/usb/host/ohci-ps3.c:48:3: error: implicit declaration of function 'err' [-Werror=implicit-function-declaration]

Caused by commit af4e1ee04026 ("USB: remove err() macro").

I have used the usb tree from next-20120424 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2010-11-17  2:14 Stephen Rothwell
  2010-11-17  4:20 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2010-11-17  2:14 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Alan Stern

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/media/video/tlg2300/pd-main.c: In function 'poseidon_probe':
drivers/media/video/tlg2300/pd-main.c:455: error: 'struct usb_device' has no member named 'autosuspend_delay'
drivers/net/wimax/i2400m/usb.c: In function 'i2400mu_probe':
drivers/net/wimax/i2400m/usb.c:517: error: 'struct usb_device' has no member named 'autosuspend_delay'

Caused by commit fcc4a01eb8661226e80632327673f67bf6a5840b ("USB: use the
runtime-PM autosuspend implementation").  More grepping required ...

I have used the usb tree from next-20101116 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2010-09-14  2:54 Stephen Rothwell
  2010-09-14  4:03 ` Greg KH
  2010-09-14  4:08 ` Greg KH
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2010-09-14  2:54 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Mihai Donțu, David Brownell

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from drivers/usb/gadget/ether.c:123:
drivers/usb/gadget/rndis.c: In function 'rndis_init':
drivers/usb/gadget/rndis.c:1163: error: expected ';' before 'if'

Caused by commit c8feb3bad134f927a624cc19da13f57627b905e2 ("USB: gadget:
rndis: fix up coding style issues in the file").

I used the version of the usb tree from next-20100913 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2010-09-02  3:54 Stephen Rothwell
  2010-09-02  4:32 ` Greg KH
  0 siblings, 1 reply; 103+ messages in thread
From: Stephen Rothwell @ 2010-09-02  3:54 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, linux-kernel, "Uwe Kleine-König",
	"Michał Nazarewicz"

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/usb/gadget/nokia.c:244: error: unknown field 'bind' specified in initializer
drivers/usb/gadget/nokia.c:244: warning: initialization makes integer from pointer without a cast
drivers/usb/gadget/nokia.c:244: error: initializer element is not computable at load time
drivers/usb/gadget/nokia.c:244: error: (near initialization for 'nokia_driver.needs_serial')
drivers/usb/gadget/nokia.c: In function 'nokia_init':
drivers/usb/gadget/nokia.c:250: error: implicit declaration of function 'usb_composite_register'

Caused by commit cc604fa9db859b7d6899de807d6bd8df80fc0a1a ("usb gadget:
don't save bind callback in struct usb_configuration").  The 'bind' and
'usb_composite_register' references above were added before 2.6.34-rc1
but missed in this patch.

Please make every attempt to (at least) build every file that gets
modified when testing a patch.  (and grep is your friend)

I have used the usb tree from next-20100901 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread
* linux-next: build failure after merge of the usb tree
@ 2010-05-18  7:42 Stephen Rothwell
  2010-05-18 13:54 ` Alan Stern
  2010-05-18 14:00 ` Greg KH
  0 siblings, 2 replies; 103+ messages in thread
From: Stephen Rothwell @ 2010-05-18  7:42 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-next, linux-kernel, Alan Stern

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (powerpc
ppc6xx_defconfig) failed like this:

drivers/usb/host/ehci-fsl.c:316: error: 'ehci' undeclared (first use in this function)

Caused by commit d19f8cd047971b43844d61d995be736dacb4826a ("USB: EHCI:
fix controller wakeup flag settings during suspend").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 103+ messages in thread

end of thread, other threads:[~2023-10-16 18:44 UTC | newest]

Thread overview: 103+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-28 10:46 linux-next: build failure after merge of the usb tree Stephen Rothwell
2013-01-28 14:45 ` Greg KH
2013-01-28 14:50   ` Lan Tianyu
2013-01-28 15:28   ` Lan Tianyu
2013-01-28 16:03   ` Lan, Tianyu
2013-01-29 13:41     ` Greg KH
2013-01-29 13:51       ` Lan, Tianyu
2013-01-29 14:59         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2023-10-04  2:22 Stephen Rothwell
2023-10-04  6:43 ` Greg KH
2023-10-04  6:47   ` Rohit Agarwal
2023-10-04 12:46     ` Greg KH
2023-10-09  9:18       ` Rohit Agarwal
2023-10-09  9:48         ` Greg KH
2023-10-09  9:49           ` Dmitry Baryshkov
2023-10-12 17:03             ` Rohit Agarwal
2023-10-16 18:43               ` Greg KH
2023-03-27  5:02 Stephen Rothwell
2023-03-27  7:37 ` Greg KH
2022-11-30  2:18 Stephen Rothwell
2022-11-30 10:52 ` Greg KH
2022-11-30 10:58   ` Andy Shevchenko
2022-11-30 17:43     ` Andy Shevchenko
2022-11-30 17:46       ` Greg KH
2022-11-30 10:53 ` Andy Shevchenko
2022-07-18  6:31 Stephen Rothwell
2022-07-18 20:43 ` Greg KH
2022-07-18 21:41   ` Prashant Malani
2022-07-18 22:08     ` Prashant Malani
2022-07-19  6:50     ` Greg KH
2022-07-19 12:01       ` Greg KH
2022-07-19 17:11         ` Prashant Malani
2022-07-19  6:08   ` Stephen Rothwell
2022-06-14  2:08 Stephen Rothwell
2022-06-14  2:41 ` Neal Liu
2022-06-14  6:30   ` Stephen Rothwell
2022-06-14  6:41 ` Greg KH
2022-06-14  7:52   ` Stephen Rothwell
2022-06-14  8:10     ` Bagas Sanjaya
2022-06-14  9:28       ` Greg KH
2022-06-14 11:11       ` Stephen Rothwell
2022-05-02 11:07 Stephen Rothwell
2022-05-02 11:40 ` Greg KH
2022-05-02 17:09   ` Matthias Kaehlcke
2022-05-02 17:32     ` Greg KH
2022-05-02 17:49       ` Matthias Kaehlcke
2022-05-03 14:49 ` Greg KH
2021-04-12 11:36 Stephen Rothwell
2021-04-12 12:35 ` Greg KH
2021-04-12 12:41   ` Heikki Krogerus
2020-03-16  3:10 Stephen Rothwell
2020-03-16 11:30 ` Thierry Reding
2020-03-16 13:28   ` Greg KH
2020-03-16 13:44     ` Thierry Reding
2019-06-19  6:43 Stephen Rothwell
2019-06-19 14:56 ` Greg KH
2014-12-01  8:19 Stephen Rothwell
2014-12-02 18:12 ` Greg KH
2014-12-03  5:57   ` Kishon Vijay Abraham I
2014-07-24  7:07 Stephen Rothwell
2014-07-24  7:44 ` Greg KH
2014-08-06  1:39   ` Stephen Rothwell
2014-08-06  4:04     ` Greg KH
2014-05-29  9:01 Stephen Rothwell
2014-05-29 18:18 ` Greg KH
2014-05-29 18:40   ` Dan Williams
2013-04-18  6:05 Stephen Rothwell
2013-04-18 16:06 ` Joe Perches
2013-03-27  3:41 Stephen Rothwell
2013-03-27  3:51 ` Ming Lei
2013-03-27  4:20   ` Greg KH
2013-03-28 18:04 ` Greg KH
2013-01-21  4:21 Stephen Rothwell
2013-01-21  8:37 ` Lan, Tianyu
2012-09-19  4:31 Stephen Rothwell
2012-09-19  7:17 ` Greg KH
2012-09-19 13:59 ` Alan Cox
2012-09-19 14:13   ` Greg KH
2012-05-21  6:22 Stephen Rothwell
2012-05-21 12:56 ` Sarah Sharp
2012-04-27  4:12 Stephen Rothwell
2012-04-27 18:25 ` Greg KH
2010-11-17  2:14 Stephen Rothwell
2010-11-17  4:20 ` Greg KH
     [not found]   ` <20101117042053.GB2999-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-11-17 15:56     ` Alan Stern
2010-11-17 21:25       ` Greg KH
2010-09-14  2:54 Stephen Rothwell
2010-09-14  4:03 ` Greg KH
2010-09-14  4:08 ` Greg KH
2010-09-14  4:25   ` Stephen Rothwell
2010-09-14 13:26     ` Greg KH
2010-09-15 13:21     ` Mihai Donțu
2010-09-02  3:54 Stephen Rothwell
2010-09-02  4:32 ` Greg KH
2010-09-02  4:36   ` Michał Nazarewicz
2010-09-02  4:51   ` Stephen Rothwell
2010-05-18  7:42 Stephen Rothwell
2010-05-18 13:54 ` Alan Stern
2010-05-18 14:08   ` Greg KH
2010-05-18 21:11   ` Greg KH
2010-05-19 22:49     ` Stephen Rothwell
2010-05-20  6:39       ` Greg KH
2010-05-18 14:00 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).