linux-next: build failure after merge of the final tree (staging tree related)

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1763 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]

Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").

From Documentation/bus-virt-phys-mapping.txt:

"[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
        superseded by the functionality provided by the PCI DMA interface
        (see Documentation/DMA-API-HOWTO.txt).  They continue
        to be documented below for historical purposes, but new code
        must not use them. --davidm 00/12/12 ]"

See also Documentation/DMA-API-HOWTO.txt.

I have added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 13 Mar 2013 16:35:50 +1100
Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/dwc2/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
index 610418a..bc4cdfe 100644
--- a/drivers/staging/dwc2/Kconfig
+++ b/drivers/staging/dwc2/Kconfig
@@ -1,6 +1,7 @@
 config USB_DWC2
 	tristate "DesignWare USB2 DRD Core Support"
 	depends on USB
+	depends on VIRT_TO_BUS
 	select USB_OTG_UTILS
 	help
 	  Say Y or M here if your system has a Dual Role HighSpeed
-- 
1.8.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the final tree (staging tree related)

[Paul Zimmerman]

> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Tuesday, March 12, 2013 10:40 PM
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
> drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
> drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]
> 
> Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").
> 
> From Documentation/bus-virt-phys-mapping.txt:
> 
> "[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
>         superseded by the functionality provided by the PCI DMA interface
>         (see Documentation/DMA-API-HOWTO.txt).  They continue
>         to be documented below for historical purposes, but new code
>         must not use them. --davidm 00/12/12 ]"
> 
> See also Documentation/DMA-API-HOWTO.txt.
> 
> I have added this patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 13 Mar 2013 16:35:50 +1100
> Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/dwc2/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
> index 610418a..bc4cdfe 100644
> --- a/drivers/staging/dwc2/Kconfig
> +++ b/drivers/staging/dwc2/Kconfig
> @@ -1,6 +1,7 @@
>  config USB_DWC2
>  	tristate "DesignWare USB2 DRD Core Support"
>  	depends on USB
> +	depends on VIRT_TO_BUS
>  	select USB_OTG_UTILS
>  	help
>  	  Say Y or M here if your system has a Dual Role HighSpeed
> --

Hi Greg,

Do you apply these sort of patches automatically, or do you need an ack from me?
In case you do:

Acked-by: Paul Zimmerman <paulz@synopsys.com>

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Thu, Mar 14, 2013 at 08:23:39PM +0000, Paul Zimmerman wrote:
> > From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> > Sent: Tuesday, March 12, 2013 10:40 PM
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
> > drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
> > drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]
> > 
> > Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").
> > 
> > From Documentation/bus-virt-phys-mapping.txt:
> > 
> > "[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
> >         superseded by the functionality provided by the PCI DMA interface
> >         (see Documentation/DMA-API-HOWTO.txt).  They continue
> >         to be documented below for historical purposes, but new code
> >         must not use them. --davidm 00/12/12 ]"
> > 
> > See also Documentation/DMA-API-HOWTO.txt.
> > 
> > I have added this patch for today:
> > 
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 13 Mar 2013 16:35:50 +1100
> > Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/staging/dwc2/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
> > index 610418a..bc4cdfe 100644
> > --- a/drivers/staging/dwc2/Kconfig
> > +++ b/drivers/staging/dwc2/Kconfig
> > @@ -1,6 +1,7 @@
> >  config USB_DWC2
> >  	tristate "DesignWare USB2 DRD Core Support"
> >  	depends on USB
> > +	depends on VIRT_TO_BUS
> >  	select USB_OTG_UTILS
> >  	help
> >  	  Say Y or M here if your system has a Dual Role HighSpeed
> > --
> 
> Hi Greg,
> 
> Do you apply these sort of patches automatically, or do you need an ack from me?
> In case you do:
> 
> Acked-by: Paul Zimmerman <paulz@synopsys.com>

Thanks, I'll take it, I hadn't gotten to this fix just yet.

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Mon, Feb 10, 2014 at 03:54:12PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_init_mlme_priv':
> drivers/staging/rtl8188eu/core/rtw_mlme.c:65:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
>   pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network)));
>   ^

<snip>

Sorry about that.  Larry sent me a patch for this Friday evening and I
haven't had the chance to add it to my tree just yet.  Sorry for the
noise.

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 7004 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_init_mlme_priv':
drivers/staging/rtl8188eu/core/rtw_mlme.c:65:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network)));
  ^
drivers/staging/rtl8188eu/core/rtw_mlme.c:65:7: warning: assignment makes pointer from integer without a cast [enabled by default]
  pbuf = vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network)));
       ^
drivers/staging/rtl8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv':
drivers/staging/rtl8188eu/core/rtw_mlme.c:133:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
    vfree(pmlmepriv->free_bss_buf);
    ^
drivers/staging/rtl8188eu/core/rtw_mp.c: In function '_rtw_mp_xmit_priv':
drivers/staging/rtl8188eu/core/rtw_mp.c:946:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
   vfree(pxmitpriv->pallocated_xmit_extbuf);
   ^
drivers/staging/rtl8188eu/core/rtw_mp.c:959:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);
  ^
drivers/staging/rtl8188eu/core/rtw_mp.c:959:36: warning: assignment makes pointer from integer without a cast [enabled by default]
  pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);
                                    ^
drivers/staging/rtl8188eu/core/rtw_recv.c: In function '_rtw_init_recv_priv':
drivers/staging/rtl8188eu/core/rtw_recv.c:80:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ);
  ^
drivers/staging/rtl8188eu/core/rtw_recv.c:80:34: warning: assignment makes pointer from integer without a cast [enabled by default]
  precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(union recv_frame) + RXFRAME_ALIGN_SZ);
                                  ^
drivers/staging/rtl8188eu/core/rtw_recv.c: In function '_rtw_free_recv_priv':
drivers/staging/rtl8188eu/core/rtw_recv.c:132:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
   vfree(precvpriv->pallocated_frame_buf);
   ^
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c: In function '_rtw_init_sta_priv':
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:82:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
  ^
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:82:35: warning: assignment makes pointer from integer without a cast [enabled by default]
  pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
                                   ^
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c: In function '_rtw_free_sta_priv':
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c:211:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
    vfree(pstapriv->pallocated_stainfo_buf);
    ^
drivers/staging/rtl8188eu/core/rtw_xmit.c: In function '_rtw_init_xmit_priv':
drivers/staging/rtl8188eu/core/rtw_xmit.c:94:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4);
  ^
drivers/staging/rtl8188eu/core/rtw_xmit.c:94:34: warning: assignment makes pointer from integer without a cast [enabled by default]
  pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4);
                                  ^
drivers/staging/rtl8188eu/core/rtw_xmit.c:132:32: warning: assignment makes pointer from integer without a cast [enabled by default]
  pxmitpriv->pallocated_xmitbuf = vzalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4);
                                ^
drivers/staging/rtl8188eu/core/rtw_xmit.c:174:36: warning: assignment makes pointer from integer without a cast [enabled by default]
  pxmitpriv->pallocated_xmit_extbuf = vzalloc(num_xmit_extbuf * sizeof(struct xmit_buf) + 4);
                                    ^
drivers/staging/rtl8188eu/core/rtw_xmit.c: In function '_rtw_free_xmit_priv':
drivers/staging/rtl8188eu/core/rtw_xmit.c:262:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
   vfree(pxmitpriv->pallocated_frame_buf);
   ^
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c: In function 'rtw_IOL_cmd_tx_pkt_buf_dump':
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:368:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  u8 *pbuf = vzalloc(data_len+10);
  ^
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:368:13: warning: initialization makes pointer from integer without a cast [enabled by default]
  u8 *pbuf = vzalloc(data_len+10);
             ^
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:390:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
   vfree(pbuf);
   ^
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_priv':
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:5651:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
  ext = vmalloc(len);
  ^
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:5651:6: warning: assignment makes pointer from integer without a cast [enabled by default]
  ext = vmalloc(len);
      ^
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:5656:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
   vfree(ext);
   ^
drivers/staging/rtl8188eu/os_dep/usb_intf.c: In function 'rtw_usb_if1_init':
drivers/staging/rtl8188eu/os_dep/usb_intf.c:649:21: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
  padapter = (struct adapter *)vzalloc(sizeof(*padapter));
                     ^
drivers/staging/rtl8188eu/os_dep/usb_intf.c:649:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  padapter = (struct adapter *)vzalloc(sizeof(*padapter));
             ^
drivers/staging/rtl8188eu/os_dep/usb_intf.c:749:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
    vfree(padapter);
    ^

Caused by commits 2397c6e09276 ("staging: r8188eu: Remove wrappers around
vmalloc and vzalloc") and 03bd6aea7ba6 ("staging: r8188eu: Remove
wrappers around vfree") from the staging tree.  See Rule 1 in
Documentation/SubmitChecklist ...

I have disabled that driver for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Tue, Jun 25, 2013 at 08:22:49AM +0800, Peng Tao wrote:
> On 06/25/2013 07:50 AM, Greg KH wrote:
> >On Tue, Jun 25, 2013 at 09:40:51AM +1000, Stephen Rothwell wrote:
> >>Hi Greg,
> >>
> >>On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <greg@kroah.com> wrote:
> >>>We are running out of time, my tree is pretty much closed for 3.11 now,
> >>>should I just disable the build of this module for 3.11?
> >>That's what I've been doing - it has never been enabled in a final
> >>linux-next release.  So, it should probably just be disabled properly.
> >I agree, now disabled.
> >
> >greg k-h
> Greg,
> 
> Sorry for the delay. I've been caught up by other build failures
> that were found during my tests. I'm sending you the latest patches
> that should fix all the build errors. I've verified that we can now
> pass build on sparc/mips/s390/powerpc/x86, both 32bits and 64bits.
> Please help to queue them.
> 
> I see that you have already disabled Lustre build. Can we re-enable
> it or do we have to wait until 3.10 is released?

My trees mare now closed for 3.11, given that 3.10 will be released in
less than a week.  I'll keep patches in my to-apply mailbox, which I
will then apply after 3.11-rc1 is out, so I'll not be accepting anything
for the next 3 weeks or so.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Peng Tao]

On 06/25/2013 07:50 AM, Greg KH wrote:
> On Tue, Jun 25, 2013 at 09:40:51AM +1000, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <greg@kroah.com> wrote:
>>> We are running out of time, my tree is pretty much closed for 3.11 now,
>>> should I just disable the build of this module for 3.11?
>> That's what I've been doing - it has never been enabled in a final
>> linux-next release.  So, it should probably just be disabled properly.
> I agree, now disabled.
>
> greg k-h
Greg,

Sorry for the delay. I've been caught up by other build failures that 
were found during my tests. I'm sending you the latest patches that 
should fix all the build errors. I've verified that we can now pass 
build on sparc/mips/s390/powerpc/x86, both 32bits and 64bits. Please 
help to queue them.

I see that you have already disabled Lustre build. Can we re-enable it 
or do we have to wait until 3.10 is released?

Thanks,
Tao

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Tue, Jun 25, 2013 at 09:40:51AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > We are running out of time, my tree is pretty much closed for 3.11 now,
> > should I just disable the build of this module for 3.11?
> 
> That's what I've been doing - it has never been enabled in a final
> linux-next release.  So, it should probably just be disabled properly.

I agree, now disabled.

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi Greg,

On Mon, 24 Jun 2013 15:40:35 -0700 Greg KH <greg@kroah.com> wrote:
>
> We are running out of time, my tree is pretty much closed for 3.11 now,
> should I just disable the build of this module for 3.11?

That's what I've been doing - it has never been enabled in a final
linux-next release.  So, it should probably just be disabled properly.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, Jun 19, 2013 at 05:26:57PM +0800, Peng Tao wrote:
> On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
> >                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
> >                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
> >   static struct libcfs_debug_msg_data msgdata;      \
> >                 ^
> Thanks for reporting!
> 
> It is a bug in Lustre code that it is missing NIPQUAD definition on
> Linux platform. I will send fix later.

We are running out of time, my tree is pretty much closed for 3.11 now,
should I just disable the build of this module for 3.11?

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Peng Tao]

On Wed, Jun 19, 2013 at 10:37 PM, Greg KH <greg@kroah.com> wrote:
> On Wed, Jun 19, 2013 at 05:26:57PM +0800, Peng Tao wrote:
>> On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> > Hi all,
>> >
>> > After merging the final tree, today's linux-next build (powerpc
>> > allyesconfig) failed like this:
>> >
>> > In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
>> >                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
>> >                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
>> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
>> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
>> >   static struct libcfs_debug_msg_data msgdata;      \
>> >                 ^
>> Thanks for reporting!
>>
>> It is a bug in Lustre code that it is missing NIPQUAD definition on
>> Linux platform. I will send fix later.
>>
>> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
>> >   __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
>> >   ^
>> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
>> >  #define CERROR(format, ...)  CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
>> >                               ^
>> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
>> >    CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
>> >    ^
>> >
>> > I have once again disabled the building og the lustre client code.
>> >
>> Sorry that Lustre is mostly tested only on x86 platform (and sadly I
>> don't have other architectures to test on.). We sincerely thank you
>> for your continuous help.
>
> You can always use a ppc cross compiler for just the kernel build tests
> to catch things like this.
>
Thanks for the suggestion. I've set up cross compiler for powerpc and
found a few more bugs. Will send patches to fix them later.

Cheers,
Tao

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, Jun 19, 2013 at 05:26:57PM +0800, Peng Tao wrote:
> On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
> >                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
> >                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
> >   static struct libcfs_debug_msg_data msgdata;      \
> >                 ^
> Thanks for reporting!
> 
> It is a bug in Lustre code that it is missing NIPQUAD definition on
> Linux platform. I will send fix later.
> 
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
> >   __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
> >   ^
> > drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
> >  #define CERROR(format, ...)  CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
> >                               ^
> > drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
> >    CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
> >    ^
> >
> > I have once again disabled the building og the lustre client code.
> >
> Sorry that Lustre is mostly tested only on x86 platform (and sadly I
> don't have other architectures to test on.). We sincerely thank you
> for your continuous help.

You can always use a ppc cross compiler for just the kernel build tests
to catch things like this.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Peng Tao]

On Wed, Jun 19, 2013 at 4:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
>                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
>                  from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
> drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
>   static struct libcfs_debug_msg_data msgdata;      \
>                 ^
Thanks for reporting!

It is a bug in Lustre code that it is missing NIPQUAD definition on
Linux platform. I will send fix later.

> drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
>   __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
>   ^
> drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
>  #define CERROR(format, ...)  CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
>                               ^
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
>    CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
>    ^
>
> I have once again disabled the building og the lustre client code.
>
Sorry that Lustre is mostly tested only on x86 platform (and sadly I
don't have other architectures to test on.). We sincerely thank you
for your continuous help.

Cheers,
Tao

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/staging/lustre/include/linux/libcfs/libcfs.h:203:0,
                 from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h:67,
                 from drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:41:
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c: In function 'kiblnd_dev_need_failover':
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:215:16: error: implicit declaration of function 'NIPQUAD' [-Werror=implicit-function-declaration]
  static struct libcfs_debug_msg_data msgdata;      \
                ^
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:231:2: note: in expansion of macro '__CDEBUG'
  __CDEBUG(&cdls, mask, format, ## __VA_ARGS__);\
  ^
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h:238:30: note: in expansion of macro 'CDEBUG_LIMIT'
 #define CERROR(format, ...)  CDEBUG_LIMIT(D_ERROR, format, ## __VA_ARGS__)
                              ^
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2577:3: note: in expansion of macro 'CERROR'
   CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n",
   ^

I have once again disabled the building og the lustre client code.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the final tree (staging tree related))

[H Hartley Sweeten]

On Wednesday, April 24, 2013 12:56 AM, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
> drivers/staging/comedi/drivers/ni_labpc.c:980:9: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
>

Stephen,

I just posted a patch that hopefully will fix this.

Please let me know if it works.

Regards,
Hartley

RE: linux-next: build failure after merge of the final tree (staging tree related))

[H Hartley Sweeten]

On Wednesday, April 24, 2013 12:56 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:

Ugh.. powerpc probably has CONFIG_ISA_DMA_API but not
CONFIG_VIRT_TO_BUS.

I'm looking for a fix now.

Regards,
Hartley

linux-next: build failure after merge of the final tree (staging tree related))

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
drivers/staging/comedi/drivers/ni_labpc.c:980:9: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]

Probably caused by commit fa3cb2191091 ("staging: comedi: ni_labpc: split
out PCI support").

I have disabled this driver for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 24 Apr 2013 17:52:15 +1000
Subject: [PATCH] staging: comedi: disable building ni_labpc.c

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/comedi/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 7871579..f6569fd 100644
--- a/drivers/staging/comedi/Kconfig
+++ b/drivers/staging/comedi/Kconfig
@@ -488,6 +488,7 @@ config COMEDI_NI_LABPC_ISA
 	tristate "NI Lab-PC and compatibles ISA support"
 	select COMEDI_NI_LABPC
 	depends on VIRT_TO_BUS
+	depends on BROKEN
 	---help---
 	  Enable support for National Instruments Lab-PC and compatibles
 	  Lab-PC-1200, Lab-PC-1200AI, Lab-PC+.
@@ -1024,6 +1025,7 @@ config COMEDI_NI_LABPC_PCI
 	tristate "NI Lab-PC PCI-1200 support"
 	select COMEDI_NI_LABPC
 	select COMEDI_MITE
+	depends on BROKEN
 	---help---
 	  Enable support for National Instruments Lab-PC PCI-1200.
 
@@ -1151,6 +1153,7 @@ config COMEDI_NI_DAQ_DIO24_CS
 config COMEDI_NI_LABPC_CS
 	tristate "NI DAQCard-1200 PCMCIA support"
 	select COMEDI_NI_LABPC
+	depends on BROKEN
 	---help---
 	  Enable support for the National Instruments PCMCIA DAQCard-1200
 
-- 
1.8.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Konrad Rzeszutek Wilk]

On Thu, Mar 07, 2013 at 07:50:55AM +1100, Stephen Rothwell wrote:
> Hi Konrad,
> 
> On Wed, 6 Mar 2013 15:04:44 -0500 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> >
> > So, irrespective of zcache, I also see this:
> > 
> > init/built-in.o: In function `.rd_load_image':
> > (.init.text+0x1b24): undefined reference to `.__bswapdi2'
> > arch/powerpc/kernel/built-in.o: In function `.iowa_writeq':
> > io-workarounds.c:(.text+0x2f778): undefined reference to `.__bswapdi2'
> > arch/powerpc/kernel/built-in.o: In function `.iowa_readq':
> > io-workarounds.c:(.text+0x2f848): undefined reference to `.__bswapdi2'
> > arch/powerpc/platforms/built-in.o: In function `.spiderpci_readq':
> > spider-pci.c:(.text+0x2a84c): undefined reference to `.__bswapdi2'
> > arch/powerpc/platforms/built-in.o: In function `.scc_pciex_readq':
> > celleb_scc_pciex.c:(.text+0x2fc4c): undefined reference to `.__bswapdi2'
> > fs/built-in.o:(.text+0x9717c): more undefined references to `.__bswapdi2' follow
> > 
> > Is that new?
> 
> I don't get those.  What compiler version and config are you using?

powerpc64-unknown-linux-gnu-gcc (GCC) 4.4.2

The defconfig with CONFIG_STAGING=y, CONFIG_CONFIGFS_FS=y, CONFIG_FRONTSWAP=y and CONFIG_ZCACHE_* =y

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Konrad Rzeszutek Wilk]

On Thu, Mar 07, 2013 at 06:11:19AM +0800, Greg KH wrote:
> On Wed, Mar 06, 2013 at 03:04:44PM -0500, Konrad Rzeszutek Wilk wrote:
> > On Wed, Mar 06, 2013 at 08:56:54AM -0500, Konrad Rzeszutek Wilk wrote:
> > > On Wed, Mar 06, 2013 at 08:43:41AM +0800, Greg KH wrote:
> > > > On Wed, Mar 06, 2013 at 11:35:08AM +1100, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > > 
> > > > > After merging the final tree, today's linux-next build (powerpc
> > > > > allyesconfig) failed like this:
> > > > > 
> > > > > In file included from drivers/staging/zcache/debug.c:2:0:
> > > > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > > > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > > > > 
> > > > > Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of
> > > > > zcache-main.c file").
> > > > > 
> > > > > I applied this patch for today:
> > > > > 
> > > > > From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001
> > > > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > > Date: Wed, 6 Mar 2013 11:31:06 +1100
> > > > > Subject: [PATCH] disable ZCACHE_DEBUG due to build error
> > > > > 
> > > > > In file included from drivers/staging/zcache/debug.c:2:0:
> > > > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > > > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > > > > 
> > > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > > ---
> > > > >  drivers/staging/zcache/Kconfig | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > Ick, sorry about that, I've applied your patch to my tree.
> > > 
> > > Wait, there is no BUG_ON on PPC? Or is the definition for it hidden in layers
> > > of #include files? Would this also solve it:
> > 
> > I got the cross-compiler up and the patch below does indeed solve the problem.
> > Greg, could you apply the patch below please?
> 
> What patch?  I don't see a proper Subject:, Signed-off-by: or anything
> else I can use.

Shesshh. And now I owe you a beer .
> 
> > > diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> > > index eef67db..494cea02 100644
> > > --- a/drivers/staging/zcache/debug.h
> > > +++ b/drivers/staging/zcache/debug.h
> > > @@ -1,5 +1,7 @@
> > >  #ifdef CONFIG_ZCACHE_DEBUG
> > >  
> > > +#include <asm/bug.h>
> 
> Never include an asm .h file, you know better than that :)

OK, let me send an official path.
> 
> greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, Mar 06, 2013 at 03:04:44PM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 06, 2013 at 08:56:54AM -0500, Konrad Rzeszutek Wilk wrote:
> > On Wed, Mar 06, 2013 at 08:43:41AM +0800, Greg KH wrote:
> > > On Wed, Mar 06, 2013 at 11:35:08AM +1100, Stephen Rothwell wrote:
> > > > Hi all,
> > > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allyesconfig) failed like this:
> > > > 
> > > > In file included from drivers/staging/zcache/debug.c:2:0:
> > > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > > > 
> > > > Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of
> > > > zcache-main.c file").
> > > > 
> > > > I applied this patch for today:
> > > > 
> > > > From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001
> > > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > Date: Wed, 6 Mar 2013 11:31:06 +1100
> > > > Subject: [PATCH] disable ZCACHE_DEBUG due to build error
> > > > 
> > > > In file included from drivers/staging/zcache/debug.c:2:0:
> > > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > > > 
> > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > > ---
> > > >  drivers/staging/zcache/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > 
> > > Ick, sorry about that, I've applied your patch to my tree.
> > 
> > Wait, there is no BUG_ON on PPC? Or is the definition for it hidden in layers
> > of #include files? Would this also solve it:
> 
> I got the cross-compiler up and the patch below does indeed solve the problem.
> Greg, could you apply the patch below please?

What patch?  I don't see a proper Subject:, Signed-off-by: or anything
else I can use.

> > diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> > index eef67db..494cea02 100644
> > --- a/drivers/staging/zcache/debug.h
> > +++ b/drivers/staging/zcache/debug.h
> > @@ -1,5 +1,7 @@
> >  #ifdef CONFIG_ZCACHE_DEBUG
> >  
> > +#include <asm/bug.h>

Never include an asm .h file, you know better than that :)

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Hi Konrad,

On Wed, 6 Mar 2013 15:04:44 -0500 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>
> So, irrespective of zcache, I also see this:
> 
> init/built-in.o: In function `.rd_load_image':
> (.init.text+0x1b24): undefined reference to `.__bswapdi2'
> arch/powerpc/kernel/built-in.o: In function `.iowa_writeq':
> io-workarounds.c:(.text+0x2f778): undefined reference to `.__bswapdi2'
> arch/powerpc/kernel/built-in.o: In function `.iowa_readq':
> io-workarounds.c:(.text+0x2f848): undefined reference to `.__bswapdi2'
> arch/powerpc/platforms/built-in.o: In function `.spiderpci_readq':
> spider-pci.c:(.text+0x2a84c): undefined reference to `.__bswapdi2'
> arch/powerpc/platforms/built-in.o: In function `.scc_pciex_readq':
> celleb_scc_pciex.c:(.text+0x2fc4c): undefined reference to `.__bswapdi2'
> fs/built-in.o:(.text+0x9717c): more undefined references to `.__bswapdi2' follow
> 
> Is that new?

I don't get those.  What compiler version and config are you using?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Konrad,

On Wed, 6 Mar 2013 15:04:44 -0500 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>
> > diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> > index eef67db..494cea02 100644
> > --- a/drivers/staging/zcache/debug.h
> > +++ b/drivers/staging/zcache/debug.h
> > @@ -1,5 +1,7 @@
> >  #ifdef CONFIG_ZCACHE_DEBUG
> >  
> > +#include <asm/bug.h>

Why not include <linux/bug.h> ?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Konrad Rzeszutek Wilk]

On Wed, Mar 06, 2013 at 08:56:54AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 06, 2013 at 08:43:41AM +0800, Greg KH wrote:
> > On Wed, Mar 06, 2013 at 11:35:08AM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > In file included from drivers/staging/zcache/debug.c:2:0:
> > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > > 
> > > Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of
> > > zcache-main.c file").
> > > 
> > > I applied this patch for today:
> > > 
> > > From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001
> > > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Date: Wed, 6 Mar 2013 11:31:06 +1100
> > > Subject: [PATCH] disable ZCACHE_DEBUG due to build error
> > > 
> > > In file included from drivers/staging/zcache/debug.c:2:0:
> > > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > > 
> > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > ---
> > >  drivers/staging/zcache/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > Ick, sorry about that, I've applied your patch to my tree.
> 
> Wait, there is no BUG_ON on PPC? Or is the definition for it hidden in layers
> of #include files? Would this also solve it:

I got the cross-compiler up and the patch below does indeed solve the problem.
Greg, could you apply the patch below please?
> 
> 
> diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
> index eef67db..494cea02 100644
> --- a/drivers/staging/zcache/debug.h
> +++ b/drivers/staging/zcache/debug.h
> @@ -1,5 +1,7 @@
>  #ifdef CONFIG_ZCACHE_DEBUG
>  
> +#include <asm/bug.h>
> +
>  /* we try to keep these statistics SMP-consistent */
>  static ssize_t zcache_obj_count;
>  static atomic_t zcache_obj_atomic = ATOMIC_INIT(0);
> 
> 
> ? (going to get my PPC compiler ready shortly to check this out).
> 

So, irrespective of zcache, I also see this:

init/built-in.o: In function `.rd_load_image':
(.init.text+0x1b24): undefined reference to `.__bswapdi2'
arch/powerpc/kernel/built-in.o: In function `.iowa_writeq':
io-workarounds.c:(.text+0x2f778): undefined reference to `.__bswapdi2'
arch/powerpc/kernel/built-in.o: In function `.iowa_readq':
io-workarounds.c:(.text+0x2f848): undefined reference to `.__bswapdi2'
arch/powerpc/platforms/built-in.o: In function `.spiderpci_readq':
spider-pci.c:(.text+0x2a84c): undefined reference to `.__bswapdi2'
arch/powerpc/platforms/built-in.o: In function `.scc_pciex_readq':
celleb_scc_pciex.c:(.text+0x2fc4c): undefined reference to `.__bswapdi2'
fs/built-in.o:(.text+0x9717c): more undefined references to `.__bswapdi2' follow

Is that new?


> > 
> > thanks,
> > 
> > greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Konrad Rzeszutek Wilk]

On Wed, Mar 06, 2013 at 08:43:41AM +0800, Greg KH wrote:
> On Wed, Mar 06, 2013 at 11:35:08AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > In file included from drivers/staging/zcache/debug.c:2:0:
> > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > 
> > Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of
> > zcache-main.c file").
> > 
> > I applied this patch for today:
> > 
> > From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 6 Mar 2013 11:31:06 +1100
> > Subject: [PATCH] disable ZCACHE_DEBUG due to build error
> > 
> > In file included from drivers/staging/zcache/debug.c:2:0:
> > drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> > drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/staging/zcache/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Ick, sorry about that, I've applied your patch to my tree.

Wait, there is no BUG_ON on PPC? Or is the definition for it hidden in layers
of #include files? Would this also solve it:


diff --git a/drivers/staging/zcache/debug.h b/drivers/staging/zcache/debug.h
index eef67db..494cea02 100644
--- a/drivers/staging/zcache/debug.h
+++ b/drivers/staging/zcache/debug.h
@@ -1,5 +1,7 @@
 #ifdef CONFIG_ZCACHE_DEBUG
 
+#include <asm/bug.h>
+
 /* we try to keep these statistics SMP-consistent */
 static ssize_t zcache_obj_count;
 static atomic_t zcache_obj_atomic = ATOMIC_INIT(0);


? (going to get my PPC compiler ready shortly to check this out).

> 
> thanks,
> 
> greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, Mar 06, 2013 at 11:35:08AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from drivers/staging/zcache/debug.c:2:0:
> drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> 
> Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of
> zcache-main.c file").
> 
> I applied this patch for today:
> 
> From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 6 Mar 2013 11:31:06 +1100
> Subject: [PATCH] disable ZCACHE_DEBUG due to build error
> 
> In file included from drivers/staging/zcache/debug.c:2:0:
> drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
> drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/zcache/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Ick, sorry about that, I've applied your patch to my tree.

thanks,

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/staging/zcache/debug.c:2:0:
drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]

Caused by commit 95bdaee2140e ("zcache: Move debugfs code out of
zcache-main.c file").

I applied this patch for today:

From 24b03cf426007c4e94c6bed81560e436afcc136c Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 6 Mar 2013 11:31:06 +1100
Subject: [PATCH] disable ZCACHE_DEBUG due to build error

In file included from drivers/staging/zcache/debug.c:2:0:
drivers/staging/zcache/debug.h: In function 'dec_zcache_obj_count':
drivers/staging/zcache/debug.h:16:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/zcache/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
index 2da6cc4..ad47b4b 100644
--- a/drivers/staging/zcache/Kconfig
+++ b/drivers/staging/zcache/Kconfig
@@ -13,6 +13,7 @@ config ZCACHE
 config ZCACHE_DEBUG
 	bool "Enable debug statistics"
 	depends on DEBUG_FS && ZCACHE
+	depends on BROKEN
 	default n
 	help
 	  This is used to provide an debugfs directory with counters of
-- 
1.8.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Tue, Nov 13, 2012 at 04:51:06PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from drivers/power/lp8788-charger.c:15:0:
> include/linux/iio/consumer.h:76:21: error: unknown type name 'u8'
> include/linux/iio/consumer.h:78:11: error: expected ';', ',' or ')' before 'void'
> 
> Caused by commit 92d1079b281f ("staging:iio: add a callback buffer for in
> kernel push interface").  Presumably just a missing include.
> 
> I have reverted that commit for today (it introduces a set of not yet
> used interfaces).

I've fixed this up in the tree now so you shouldn't have this problem
with your next pull.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Jonathan Cameron]

On 13/11/12 05:51, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from drivers/power/lp8788-charger.c:15:0:
> include/linux/iio/consumer.h:76:21: error: unknown type name 'u8'
> include/linux/iio/consumer.h:78:11: error: expected ';', ',' or ')' before 'void'
>
> Caused by commit 92d1079b281f ("staging:iio: add a callback buffer for in
> kernel push interface").  Presumably just a missing include.
>
> I have reverted that commit for today (it introduces a set of not yet
> used interfaces).
>
Oops. Missed that.  Needs

#include <linux/types.h>

Sorry about that will fix up sometime in the next few days.

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/power/lp8788-charger.c:15:0:
include/linux/iio/consumer.h:76:21: error: unknown type name 'u8'
include/linux/iio/consumer.h:78:11: error: expected ';', ',' or ')' before 'void'

Caused by commit 92d1079b281f ("staging:iio: add a callback buffer for in
kernel push interface").  Presumably just a missing include.

I have reverted that commit for today (it introduces a set of not yet
used interfaces).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/dgrp/dgrp_specproc.c: In function 'config_proc_write':
drivers/staging/dgrp/dgrp_specproc.c:465:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/staging/dgrp/dgrp_specproc.c:465:13: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/staging/dgrp/dgrp_specproc.c:491:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]

Caused by commit 0b52b7497271 ("staging: Add dgrp driver for Digi
Realport devices").

I have added this fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 25 Sep 2012 00:27:11 +1000
Subject: [PATCH] staging: dgrp: using vmalloc needs to include vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/dgrp/dgrp_specproc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/dgrp/dgrp_specproc.c b/drivers/staging/dgrp/dgrp_specproc.c
index 259d23a..28f5c9a 100644
--- a/drivers/staging/dgrp/dgrp_specproc.c
+++ b/drivers/staging/dgrp/dgrp_specproc.c
@@ -39,6 +39,7 @@
 #include <linux/proc_fs.h>
 #include <linux/ctype.h>
 #include <linux/seq_file.h>
+#include <linux/vmalloc.h>
 
 #include "dgrp_common.h"
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Mon, Sep 10, 2012 at 05:04:09PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/silicom/bypasslib/built-in.o: In function `.is_bypass':
> (.text+0x3254): multiple definition of `.is_bypass'
> drivers/staging/silicom/bpctl_mod.o:(.text+0x1d938): first defined here
> drivers/staging/silicom/bypasslib/built-in.o: In function `is_bypass':
> (.opd+0x480): multiple definition of `is_bypass'
> drivers/staging/silicom/bpctl_mod.o:(.opd+0x15f0): first defined here
> 
> Caused by commit 7040e556c90a ("staging: add Silicom Bypass driver").
> 
> I added this patch to disable the driver:
> 
> From 884437b30775214e9f34696adb2be2f24f1e6df7 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 10 Sep 2012 17:01:05 +1000
> Subject: [PATCH] staging: disable Silicom Bypass driver
> 
> due to build breakage:
> 
> rivers/staging/silicom/bypasslib/built-in.o: In function `.is_bypass':
> (.text+0x3254): multiple definition of `.is_bypass'
> drivers/staging/silicom/bpctl_mod.o:(.text+0x1d938): first defined here
> drivers/staging/silicom/bypasslib/built-in.o: In function `is_bypass':
> (.opd+0x480): multiple definition of `is_bypass'
> drivers/staging/silicom/bpctl_mod.o:(.opd+0x15f0): first defined here
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/silicom/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/silicom/Kconfig b/drivers/staging/silicom/Kconfig
> index 3493ee8..1914844 100644
> --- a/drivers/staging/silicom/Kconfig
> +++ b/drivers/staging/silicom/Kconfig
> @@ -6,6 +6,7 @@ config NET_VENDOR_SILICOM
>  	bool "Silicom devices"
>  	default y
>  	depends on (SSB_POSSIBLE && HAS_DMA) || PCI 
> +	depends on BROKEN

I think forcing this driver to be a module will resolve this issue.
It seems to be quite a common problem for most staging drivers when they
first land in the tree, sorry for not catching this one.

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/silicom/bypasslib/built-in.o: In function `.is_bypass':
(.text+0x3254): multiple definition of `.is_bypass'
drivers/staging/silicom/bpctl_mod.o:(.text+0x1d938): first defined here
drivers/staging/silicom/bypasslib/built-in.o: In function `is_bypass':
(.opd+0x480): multiple definition of `is_bypass'
drivers/staging/silicom/bpctl_mod.o:(.opd+0x15f0): first defined here

Caused by commit 7040e556c90a ("staging: add Silicom Bypass driver").

I added this patch to disable the driver:

From 884437b30775214e9f34696adb2be2f24f1e6df7 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 10 Sep 2012 17:01:05 +1000
Subject: [PATCH] staging: disable Silicom Bypass driver

due to build breakage:

rivers/staging/silicom/bypasslib/built-in.o: In function `.is_bypass':
(.text+0x3254): multiple definition of `.is_bypass'
drivers/staging/silicom/bpctl_mod.o:(.text+0x1d938): first defined here
drivers/staging/silicom/bypasslib/built-in.o: In function `is_bypass':
(.opd+0x480): multiple definition of `is_bypass'
drivers/staging/silicom/bpctl_mod.o:(.opd+0x15f0): first defined here

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/silicom/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/silicom/Kconfig b/drivers/staging/silicom/Kconfig
index 3493ee8..1914844 100644
--- a/drivers/staging/silicom/Kconfig
+++ b/drivers/staging/silicom/Kconfig
@@ -6,6 +6,7 @@ config NET_VENDOR_SILICOM
 	bool "Silicom devices"
 	default y
 	depends on (SSB_POSSIBLE && HAS_DMA) || PCI 
+	depends on BROKEN
 	---help---
 	  If you have a network card (Ethernet) belonging to this class,
 	  say Y.
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Geert Uytterhoeven]

On Wed, Sep 5, 2012 at 7:48 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
> drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
> drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]
>
> Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during
> device registration").
>
> I have added the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 5 Sep 2012 15:44:11 +1000
> Subject: [PATCH] Staging: ipack: disable due to build error
>
> The powerpc allyesconfig build gives this:
>
> drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
> drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
> drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]

The ipack driver also fails on s390/allmodconfig:

drivers/staging/ipack/devices/ipoctal.c:59:2: error: implicit
declaration of function 'iowrite8'
[-Werror=implicit-function-declaration]
drivers/staging/ipack/devices/ipoctal.c:72:2: error: implicit
declaration of function 'ioread8'
[-Werror=implicit-function-declaration]

http://kisskb.ellerman.id.au/kisskb/buildresult/7143741/

Guess it has to depend on HAS_IOMEM, too.

> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/ipack/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig
> index af32178..5c428d7 100644
> --- a/drivers/staging/ipack/Kconfig
> +++ b/drivers/staging/ipack/Kconfig
> @@ -4,6 +4,7 @@
>
>  menuconfig IPACK_BUS
>         tristate "IndustryPack bus support"
> +       depends on BROKEN

Cool, can I do that for all build failures? ;-)

>         ---help---
>           If you say Y here you get support for the IndustryPack Framework
>           for drivers for many types of boards that support this industrial

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1783 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]

Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during
device registration").

I have added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 5 Sep 2012 15:44:11 +1000
Subject: [PATCH] Staging: ipack: disable due to build error

The powerpc allyesconfig build gives this:

drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function 'ioread16be' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/ipack/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ipack/Kconfig b/drivers/staging/ipack/Kconfig
index af32178..5c428d7 100644
--- a/drivers/staging/ipack/Kconfig
+++ b/drivers/staging/ipack/Kconfig
@@ -4,6 +4,7 @@
 
 menuconfig IPACK_BUS
 	tristate "IndustryPack bus support"
+	depends on BROKEN
 	---help---
 	  If you say Y here you get support for the IndustryPack Framework
 	  for drivers for many types of boards that support this industrial
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, May 16, 2012 at 07:17:02AM -0700, Dan Magenheimer wrote:
> > From: Greg KH [mailto:greg@kroah.com]
> > Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)
> > 
> > On Wed, May 16, 2012 at 08:06:59PM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > >
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> > > drivers/staging/zsmalloc/zsmalloc-main.c:704:3: error: implicit declaration of function 'set_pte' [-
> > Werror=implicit-function-declaration]
> > > drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> > > drivers/staging/zsmalloc/zsmalloc-main.c:738:3: error: implicit declaration of function
> > '__flush_tlb_one' [-Werror=implicit-function-declaration]
> > >
> > > Presumably caused by commit 49b81a3c7415 ("ramster: switch over to
> > > zsmalloc and crypto interface") which now has CONFIG_RAMSTER selecting
> > > CONFIG_ZSMALLOC explicitly which in turn ignores the dependency of
> > > CONFIG_ZSMALLOC on X86 ...
> > >
> > > I have reverted that commit for today.
> > 
> > Ick, sorry about that.
> > 
> > Dan, care to send me a follow-on patch, or do you just want me to revert
> > this patch from my tree for now?
> 
> Rats.  Sorry.
> 
> Greg, given that the solution for making zsmalloc portable
> is still being debated[1] and it doesn't look like it will
> be finalized before the looming window,  I guess the
> best choice is to revert the patch and ramster will fall
> back to its captive copy of the less-efficient-but-portable
> xvmalloc for now. :-(

Ok, now reverted, thanks.

greg k-h

RE: linux-next: build failure after merge of the final tree (staging tree related)

[Dan Magenheimer]

> From: Greg KH [mailto:greg@kroah.com]
> Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)
> 
> On Wed, May 16, 2012 at 08:06:59PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> > drivers/staging/zsmalloc/zsmalloc-main.c:704:3: error: implicit declaration of function 'set_pte' [-
> Werror=implicit-function-declaration]
> > drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> > drivers/staging/zsmalloc/zsmalloc-main.c:738:3: error: implicit declaration of function
> '__flush_tlb_one' [-Werror=implicit-function-declaration]
> >
> > Presumably caused by commit 49b81a3c7415 ("ramster: switch over to
> > zsmalloc and crypto interface") which now has CONFIG_RAMSTER selecting
> > CONFIG_ZSMALLOC explicitly which in turn ignores the dependency of
> > CONFIG_ZSMALLOC on X86 ...
> >
> > I have reverted that commit for today.
> 
> Ick, sorry about that.
> 
> Dan, care to send me a follow-on patch, or do you just want me to revert
> this patch from my tree for now?

Rats.  Sorry.

Greg, given that the solution for making zsmalloc portable
is still being debated[1] and it doesn't look like it will
be finalized before the looming window,  I guess the
best choice is to revert the patch and ramster will fall
back to its captive copy of the less-efficient-but-portable
xvmalloc for now. :-(

Thanks and sorry for the churn,
Dan

[1] http://comments.gmane.org/gmane.linux.kernel.mm/78470 

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, May 16, 2012 at 08:06:59PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> drivers/staging/zsmalloc/zsmalloc-main.c:704:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> drivers/staging/zsmalloc/zsmalloc-main.c:738:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
> 
> Presumably caused by commit 49b81a3c7415 ("ramster: switch over to
> zsmalloc and crypto interface") which now has CONFIG_RAMSTER selecting
> CONFIG_ZSMALLOC explicitly which in turn ignores the dependency of
> CONFIG_ZSMALLOC on X86 ...
> 
> I have reverted that commit for today.

Ick, sorry about that.

Dan, care to send me a follow-on patch, or do you just want me to revert
this patch from my tree for now?

thanks,

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
drivers/staging/zsmalloc/zsmalloc-main.c:704:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
drivers/staging/zsmalloc/zsmalloc-main.c:738:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]

Presumably caused by commit 49b81a3c7415 ("ramster: switch over to
zsmalloc and crypto interface") which now has CONFIG_RAMSTER selecting
CONFIG_ZSMALLOC explicitly which in turn ignores the dependency of
CONFIG_ZSMALLOC on X86 ...

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the final tree (staging tree related)

[Chris Kelly]

Hi Stephen,

Many thanks for your reply. This is exactly what I needed. I have submitted a patch to fix the problem and it builds OK with the compiler you suggested below.

Kind regards
Chris Kelly

-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: 29 February 2012 7:52 AM
To: Chris Kelly
Cc: Greg KH; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

Hi Chris,

On Wed, 29 Feb 2012 07:35:35 +0000 Chris Kelly <ckelly@ozmodevices.com> wrote:
>
> Hi Greg,
> 
> I believe I understand the cause of the problem and would like to 
> submit a patch to fix it. However, I am unclear on what the starting 
> point is given that the final patch was reverted from linux-next. Do I 
> assume that patch will be reapplied before the applying the new patch 
> or should I provide another patch to reapply the reverted patch? Is it 
> acceptable to submit patches generated against the head of linux-next?

Your patches are all still in Greg's tree which I merge into linux-next every day.  I have then been reverting that last patch each day.  Your patch should be against Greg's tree (or your last patch) and then when the fix is in Greg's tree, I will get it in linux-next and stop reverting the other patch.

> Before submitting the patch, I would like to test that the patch 
> really does fix the issue found by Stephen. Since it doesn't occur 
> when building for x32 or x64 then I need to setup a PowerPC 
> cross-compile tool chain. Do you have any suggestions as to where I 
> can pull a prebuilt tool chain or do I need to build directly from the GNU sources.

http://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.0/x86_64-gcc-4.6.0-nolibc_powerpc64-linux.tar.xz

That is am x86_64 hosted powerpc64 compiler suitable for building the kernel.

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

Hi Chris,

On Wed, 29 Feb 2012 07:35:35 +0000 Chris Kelly <ckelly@ozmodevices.com> wrote:
>
> Hi Greg,
> 
> I believe I understand the cause of the problem and would like to submit
> a patch to fix it. However, I am unclear on what the starting point is given
> that the final patch was reverted from linux-next. Do I assume that patch
> will be reapplied before the applying the new patch or should I provide
> another patch to reapply the reverted patch? Is it acceptable to submit
> patches generated against the head of linux-next?

Your patches are all still in Greg's tree which I merge into linux-next
every day.  I have then been reverting that last patch each day.  Your
patch should be against Greg's tree (or your last patch) and then when
the fix is in Greg's tree, I will get it in linux-next and stop reverting
the other patch.

> Before submitting the patch, I would like to test that the patch really
> does fix the issue found by Stephen. Since it doesn't occur when building
> for x32 or x64 then I need to setup a PowerPC cross-compile tool chain. Do
> you have any suggestions as to where I can pull a prebuilt tool chain or
> do I need to build directly from the GNU sources.

http://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.0/x86_64-gcc-4.6.0-nolibc_powerpc64-linux.tar.xz

That is am x86_64 hosted powerpc64 compiler suitable for building the
kernel.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the final tree (staging tree related)

[Chris Kelly]

Hi Greg,

I believe I understand the cause of the problem and would like to submit a patch to fix it. However, I am unclear on what the starting point is given that the final patch was reverted from linux-next. Do I assume that patch will be reapplied before the applying the new patch or should I provide another patch to reapply the reverted patch? Is it acceptable to submit patches generated against the head of linux-next?

Before submitting the patch, I would like to test that the patch really does fix the issue found by Stephen. Since it doesn't occur when building for x32 or x64 then I need to setup a PowerPC cross-compile tool chain. Do you have any suggestions as to where I can pull a prebuilt tool chain or do I need to build directly from the GNU sources.

Many thanks for your help
Kind regards
Chris Kelly 

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org] 
Sent: 27 February 2012 9:17 PM
To: Stephen Rothwell
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Chris Kelly
Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Mon, Feb 27, 2012 at 06:13:03PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build
> (powerpc_allyesconfig) failed like this:
> 
> drivers/staging/ozwpan/ozcdev.c: In function 'oz_cdev_ioctl':
> drivers/staging/ozwpan/ozcdev.c:284:7: error: case label does not reduce to an integer constant
> 
> Caused by commit 23af8c2a088f ("staging: ozwpan: Added character device
> support") from the staging tree.
> 
> I reverted commit b0406db5b3e4 ("staging: ozwpan: Plumbed in Kconfig and
> Kbuild") for today.

Thanks, Chris, care to fix this up and send me a patch?

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Mon, Feb 27, 2012 at 06:13:03PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build
> (powerpc_allyesconfig) failed like this:
> 
> drivers/staging/ozwpan/ozcdev.c: In function 'oz_cdev_ioctl':
> drivers/staging/ozwpan/ozcdev.c:284:7: error: case label does not reduce to an integer constant
> 
> Caused by commit 23af8c2a088f ("staging: ozwpan: Added character device
> support") from the staging tree.
> 
> I reverted commit b0406db5b3e4 ("staging: ozwpan: Plumbed in Kconfig and
> Kbuild") for today.

Thanks, Chris, care to fix this up and send me a patch?

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Hi all,

After merging the final tree, today's linux-next build
(powerpc_allyesconfig) failed like this:

drivers/staging/ozwpan/ozcdev.c: In function 'oz_cdev_ioctl':
drivers/staging/ozwpan/ozcdev.c:284:7: error: case label does not reduce to an integer constant

Caused by commit 23af8c2a088f ("staging: ozwpan: Added character device
support") from the staging tree.

I reverted commit b0406db5b3e4 ("staging: ozwpan: Plumbed in Kconfig and
Kbuild") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Mon, Feb 13, 2012 at 08:48:05AM -0600, Seth Jennings wrote:
> On 02/13/2012 12:45 AM, Greg KH wrote:
> > On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote:
> >> Hi ,
> >>
> >> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> >> failed like this:
> >>
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
> >> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
> >> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> >> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
> >>
> >> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
> >> allocation library").  This needs to include linux/vmalloc.h at least.  I
> >> couldn't find set_pte at all or __flush_tlb_one for powerpc.
> >>
> >> This was too hard to revert, so I have left powerpc allyesconfig broken
> >> for today.  I may revert it (and some dependent commits) tomorrow.
> > 
> > Nitin, please send me a patch to fix this as soon as possible.
> 
> Sending a patch now.  Adds linux/vmalloc.h to zsmalloc-main.c. On a less ideal
> note, it also adds an X86 dependency since set_pte and __flush_tlb_one are
> x86 only.  I'm working to find portable replacements for these functions.

Thanks for the patch, I'll queue it up.

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Seth Jennings]

On 02/13/2012 12:45 AM, Greg KH wrote:
> On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote:
>> Hi ,
>>
>> After merging the final tree, today's linux-next build (powerpc allyesconfig)
>> failed like this:
>>
>> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
>> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
>> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
>> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
>> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
>> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
>> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
>> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
>> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
>>
>> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
>> allocation library").  This needs to include linux/vmalloc.h at least.  I
>> couldn't find set_pte at all or __flush_tlb_one for powerpc.
>>
>> This was too hard to revert, so I have left powerpc allyesconfig broken
>> for today.  I may revert it (and some dependent commits) tomorrow.
> 
> Nitin, please send me a patch to fix this as soon as possible.

Sending a patch now.  Adds linux/vmalloc.h to zsmalloc-main.c. On a less ideal
note, it also adds an X86 dependency since set_pte and __flush_tlb_one are
x86 only.  I'm working to find portable replacements for these functions.

--
Seth

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Seth Jennings]

On 02/13/2012 12:45 AM, Greg KH wrote:
> On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote:
>> Hi ,
>>
>> After merging the final tree, today's linux-next build (powerpc allyesconfig)
>> failed like this:
>>
>> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
>> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
>> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
>> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
>> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
>> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
>> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
>> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
>> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
>>
>> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
>> allocation library").  This needs to include linux/vmalloc.h at least.  I
>> couldn't find set_pte at all or __flush_tlb_one for powerpc.
>>
>> This was too hard to revert, so I have left powerpc allyesconfig broken
>> for today.  I may revert it (and some dependent commits) tomorrow.
> 
> Nitin, please send me a patch to fix this as soon as possible.

Hey Greg,

Working... response within the hour.

--
Seth

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Mon, Feb 13, 2012 at 05:19:49PM +1100, Stephen Rothwell wrote:
> Hi ,
> 
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
> drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
> drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
> drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
> drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
> drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
> drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]
> 
> Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
> allocation library").  This needs to include linux/vmalloc.h at least.  I
> couldn't find set_pte at all or __flush_tlb_one for powerpc.
> 
> This was too hard to revert, so I have left powerpc allyesconfig broken
> for today.  I may revert it (and some dependent commits) tomorrow.

Nitin, please send me a patch to fix this as soon as possible.

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

Hi ,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_cpu_notifier':
drivers/staging/zsmalloc/zsmalloc-main.c:451:3: error: implicit declaration of function 'alloc_vm_area' [-Werror=implicit-function-declaration]
drivers/staging/zsmalloc/zsmalloc-main.c:451:12: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/staging/zsmalloc/zsmalloc-main.c:459:4: error: implicit declaration of function 'free_vm_area' [-Werror=implicit-function-declaration]
drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_map_object':
drivers/staging/zsmalloc/zsmalloc-main.c:705:3: error: implicit declaration of function 'set_pte' [-Werror=implicit-function-declaration]
drivers/staging/zsmalloc/zsmalloc-main.c:709:27: error: dereferencing pointer to incomplete type
drivers/staging/zsmalloc/zsmalloc-main.c: In function 'zs_unmap_object':
drivers/staging/zsmalloc/zsmalloc-main.c:739:3: error: implicit declaration of function '__flush_tlb_one' [-Werror=implicit-function-declaration]

Caused by commit 61989a80fb3a ("staging: zsmalloc: zsmalloc memory
allocation library").  This needs to include linux/vmalloc.h at least.  I
couldn't find set_pte at all or __flush_tlb_one for powerpc.

This was too hard to revert, so I have left powerpc allyesconfig broken
for today.  I may revert it (and some dependent commits) tomorrow.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Jonathan Cameron]

On 10/04/11 09:05, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/iio/industrialio-buffer.c: In function 'iio_show_fixed_type':
> drivers/staging/iio/industrialio-buffer.c:108:7: error: '__LITTLE_ENDIAN' undeclared (first use in this function)
> 
> Caused by commit 8310b86c3cd2 ("staging:iio:scan element types: introduce
> endian description to the data format") from the staging tree.  Missing
> include file ...
> 
> I haven't bothered fixing this for today.
gah.  Sorry about that one.  Clearly should be an ifdef not an if.  Will send patch shortly.

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/iio/industrialio-buffer.c: In function 'iio_show_fixed_type':
drivers/staging/iio/industrialio-buffer.c:108:7: error: '__LITTLE_ENDIAN' undeclared (first use in this function)

Caused by commit 8310b86c3cd2 ("staging:iio:scan element types: introduce
endian description to the data format") from the staging tree.  Missing
include file ...

I haven't bothered fixing this for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/rtl8192e/rtl_core.c: In function 'rtl8192_init_priv_variable':
drivers/staging/rtl8192e/rtl_core.c:1270:2: error: implicit declaration of function 'vmalloc'
drivers/staging/rtl8192e/rtl_core.c:1270:20: warning: cast to pointer from integer of different size
drivers/staging/rtl8192e/rtl_core.c: In function 'rtl8192_pci_disconnect':
drivers/staging/rtl8192e/rtl_core.c:3101:4: error: implicit declaration of function 'vfree'

Caused by commit 94a799425eee ("rom: wlanfae <wlanfae@realtek.com>"
really "[PATCH 1/8] rtl8192e: Import new version of driver from realtek").

I have applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 25 Aug 2011 16:13:02 +1000
Subject: [PATCH] staging/rtl8192e: using vmalloc/vfree requires including
 vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/rtl8192e/rtl_core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl_core.c
index b38f626..15ee5ee 100644
--- a/drivers/staging/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl_core.c
@@ -43,6 +43,7 @@
 
 #include <asm/uaccess.h>
 #include <linux/pci.h>
+#include <linux/vmalloc.h>
 #include "rtl_core.h"
 #include "r8192E_phy.h"
 #include "r8192E_phyreg.h"
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

Hi Greg,

On Wed, 24 Aug 2011 15:57:58 -0700 Greg KH <greg@kroah.com> wrote:
>
> Fair enough, I've made this fix in my tree, so it should be good now.

Great, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Thu, Aug 25, 2011 at 08:54:20AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > To fix it, all we have to do is include linux/vmalloc.h, right?  Or is
> 
> I would assume so.
> 
> > ppc "special" in some other way regarding this call?
> 
> I assume it happens just because vmalloc.h is implicitly included by some
> other header file on x86 and not on ppc.
> 
> This is why we have "Rule 1" in Documentation/SubmitChecklist.  Relying
> on the implicit inclusion of header files is bound to trip us up on some
> architecture or platform or combination of CONFIG options.

Fair enough, I've made this fix in my tree, so it should be good now.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Hi Greg,

On Wed, 24 Aug 2011 14:16:46 -0700 Greg KH <greg@kroah.com> wrote:
>
> To fix it, all we have to do is include linux/vmalloc.h, right?  Or is

I would assume so.

> ppc "special" in some other way regarding this call?

I assume it happens just because vmalloc.h is implicitly included by some
other header file on x86 and not on ppc.

This is why we have "Rule 1" in Documentation/SubmitChecklist.  Relying
on the implicit inclusion of header files is bound to trip us up on some
architecture or platform or combination of CONFIG options.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Wed, Aug 24, 2011 at 03:47:41PM +1000, Stephen Rothwell wrote:
> Hi ,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/rts5139/rts51x_scsi.c: In function 'inquiry':
> drivers/staging/rts5139/rts51x_scsi.c:498:2: error: implicit declaration of function 'vmalloc'
> drivers/staging/rts5139/xd.c: In function 'xd_init_l2p_tbl':
> drivers/staging/rts5139/xd.c:745:2: error: implicit declaration of function 'vmalloc'
> drivers/staging/rts5139/xd.c: In function 'free_zone':
> drivers/staging/rts5139/xd.c:771:3: error: implicit declaration of function 'vfree'
> drivers/staging/rts5139/ms.c: In function 'ms_init_l2p_tbl':
> drivers/staging/rts5139/ms.c:2214:2: error: implicit declaration of function 'vmalloc'
> drivers/staging/rts5139/ms.c:2257:3: error: implicit declaration of function 'vfree'
> 
> Caused by commit 1dac4186bcc6 ("Staging: add driver for Realtek RTS5139
> cardreader").
> 
> I have reverted that commit for today.

To fix it, all we have to do is include linux/vmalloc.h, right?  Or is
ppc "special" in some other way regarding this call?

thanks,

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

Hi ,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/rts5139/rts51x_scsi.c: In function 'inquiry':
drivers/staging/rts5139/rts51x_scsi.c:498:2: error: implicit declaration of function 'vmalloc'
drivers/staging/rts5139/xd.c: In function 'xd_init_l2p_tbl':
drivers/staging/rts5139/xd.c:745:2: error: implicit declaration of function 'vmalloc'
drivers/staging/rts5139/xd.c: In function 'free_zone':
drivers/staging/rts5139/xd.c:771:3: error: implicit declaration of function 'vfree'
drivers/staging/rts5139/ms.c: In function 'ms_init_l2p_tbl':
drivers/staging/rts5139/ms.c:2214:2: error: implicit declaration of function 'vmalloc'
drivers/staging/rts5139/ms.c:2257:3: error: implicit declaration of function 'vfree'

Caused by commit 1dac4186bcc6 ("Staging: add driver for Realtek RTS5139
cardreader").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Thu, Jul 28, 2011 at 01:35:23PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 18 Jul 2011 18:01:04 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > On Mon, Jul 18, 2011 at 07:36:46PM +1000, Stephen Rothwell wrote:
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allysconfig) failed like this:
> > > 
> > > In file included from drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:26:0:
> > > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
> > > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80:2: error: implicit declaration of function 'inw'
> > > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
> > > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86:2: error: implicit declaration of function 'outw'
> > 
> > PowerPC supports PCMCIA?  Anyway, Ondrej, care to provide a fix for this
> > please?
> 
> Ping ... this is now in Linus' tree.

Thanks, I now have a fix for it that should show up in the next
linux-next release and be sent to Linus soon.

thanks,

greg k-h

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

Hi all,

On Mon, 18 Jul 2011 18:01:04 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Mon, Jul 18, 2011 at 07:36:46PM +1000, Stephen Rothwell wrote:
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allysconfig) failed like this:
> > 
> > In file included from drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:26:0:
> > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
> > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80:2: error: implicit declaration of function 'inw'
> > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
> > drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86:2: error: implicit declaration of function 'outw'
> 
> PowerPC supports PCMCIA?  Anyway, Ondrej, care to provide a fix for this
> please?

Ping ... this is now in Linus' tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Mon, Jul 18, 2011 at 07:36:46PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allysconfig) failed like this:
> 
> In file included from drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:26:0:
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80:2: error: implicit declaration of function 'inw'
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86:2: error: implicit declaration of function 'outw'

PowerPC supports PCMCIA?  Anyway, Ondrej, care to provide a fix for this
please?

thanks,

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allysconfig) failed like this:

In file included from drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:26:0:
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80:2: error: implicit declaration of function 'inw'
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86:2: error: implicit declaration of function 'outw'
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (staging tree related)

[Greg KH]

On Thu, Jul 07, 2011 at 04:25:54PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:26:0:
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80:2: error: implicit declaration of function 'inw'
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
> drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86:2: error: implicit declaration of function 'outw'
> 
> Caused by commit 8ac299853b70 ("staging: ft1000-pcmcia: get rid of
> ft1000_dev.h") which I can;t revert (it is too deeply buried).  I have
> just left the breakage for today - hopefully it will be fixed before I
> have to worry about it again. :-)

Ick, Ondrej, can you look into this and resolve it please?

Do we really have PPC support for PCMCIA these days?

thanks,

greg k-h

linux-next: build failure after merge of the final tree (staging tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/staging/ft1000/ft1000-pcmcia/ft1000_proc.c:26:0:
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_read_reg':
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:80:2: error: implicit declaration of function 'inw'
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h: In function 'ft1000_write_reg':
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h:86:2: error: implicit declaration of function 'outw'

Caused by commit 8ac299853b70 ("staging: ft1000-pcmcia: get rid of
ft1000_dev.h") which I can;t revert (it is too deeply buried).  I have
just left the breakage for today - hopefully it will be fixed before I
have to worry about it again. :-)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]