linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: sparclinux@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH -next] sparc32/sparc64: Provide cmpxchg64()
Date: Tue, 19 Mar 2013 16:20:00 -0400 (EDT)	[thread overview]
Message-ID: <20130319.162000.1936616024625986095.davem@davemloft.net> (raw)
In-Reply-To: <1363290128-21247-1-git-send-email-geert@linux-m68k.org>

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 14 Mar 2013 20:42:08 +0100

> sparc/sparc64 allmodconfig:
> 
> drivers/block/blockconsole.c: In function ‘bcon_advance_console_bytes’:
> drivers/block/blockconsole.c:164: error: implicit declaration of function
> ‘cmpxchg64’
> 
> Map cmpxchg64 to cmpxchg64_local to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

But, in the sparc 32-bit case, the _local() variants are only atomic
from the perspective of the current cpu, they are not globally atomic.

This is true because the sparc 32-bit cases use the
asm-generic/cmpxchg-local.h helpers.

I really can't apply this, it isn't correct, sorry.

  reply	other threads:[~2013-03-19 20:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 19:42 [PATCH -next] sparc32/sparc64: Provide cmpxchg64() Geert Uytterhoeven
2013-03-19 20:20 ` David Miller [this message]
2013-03-20  8:05   ` Geert Uytterhoeven
2013-03-20 14:11     ` David Miller
2013-03-20 14:35       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130319.162000.1936616024625986095.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).