From: wfp5p@viridian.itc.virginia.edu (Bill Pemberton)
To: Jiri Slaby <jslaby@suse.cz>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Greg KH <greg@kroah.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the tty tree
Date: Wed, 20 Mar 2013 08:51:37 -0400 [thread overview]
Message-ID: <20130320125137.EDCD3802B0@viridian.itc.virginia.edu> (raw)
In-Reply-To: <5149707F.5050003@suse.cz>
Jiri Slaby writes:
>
> > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> > drivers/usb/serial/quatech2.c:661:18: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> > drivers/usb/serial/quatech2.c:705:15: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> >
> > Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
> > is_open"). grep is your friend (or searching while editting the
> > file).
>
> I think this is caused by another commit. Bill added a check for
> is_open meanwhile I removed that member completely. Bill, could you
> fix that up, please?
>
Is it legal to call tty_flip_buffer_push() without an open tty? If
so, I can get rid of the is_open logic completely. Otherwise, I need
to either keep is_open or otherwise check for a valid tty before
calling tty_flip_buffer_push().
--
Bill
next prev parent reply other threads:[~2013-03-20 12:51 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 3:12 linux-next: build failure after merge of the tty tree Stephen Rothwell
2013-03-20 8:17 ` Jiri Slaby
2013-03-20 12:51 ` Bill Pemberton [this message]
2013-03-20 14:17 ` Jiri Slaby
2013-03-20 14:42 ` Bill Pemberton
2013-03-20 15:13 ` Jiri Slaby
2013-03-20 15:15 ` Bill Pemberton
2013-03-21 0:16 ` Greg KH
2013-03-21 22:54 ` Stephen Rothwell
2013-03-21 23:28 ` Stephen Rothwell
2013-03-21 23:47 ` Greg KH
2013-03-22 0:42 ` Stephen Rothwell
2013-03-21 23:36 ` Greg KH
2013-03-21 4:20 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2023-01-23 2:18 Stephen Rothwell
2023-01-23 9:46 ` Bartosz Golaszewski
2023-01-23 17:52 ` Greg KH
2022-08-02 20:06 broonie
2022-08-02 20:27 ` Doug Anderson
2022-08-03 6:10 ` Greg KH
2019-06-13 5:32 Stephen Rothwell
2019-06-13 6:10 ` Greg KH
2018-10-04 5:19 Stephen Rothwell
2018-10-04 16:34 ` Steve Sakoman
2018-10-04 17:00 ` Greg Kroah-Hartman
2018-10-04 17:13 ` Steve Sakoman
2018-10-04 18:13 ` Steve Sakoman
2018-10-04 18:22 ` Greg Kroah-Hartman
2018-09-11 2:58 Stephen Rothwell
2018-09-11 8:23 ` Greg KH
2018-09-11 8:25 ` Lee Jones
2018-09-11 8:32 ` Nicolas Ferre
2018-09-11 8:43 ` Lee Jones
2018-09-18 4:54 ` Andy Shevchenko
2017-12-18 3:28 Stephen Rothwell
2017-12-18 8:52 ` Geert Uytterhoeven
2017-12-18 9:02 ` Greg KH
2017-12-18 9:33 ` Greg KH
2017-02-06 4:22 Stephen Rothwell
2017-02-06 8:51 ` Greg KH
2017-02-06 14:09 ` Rob Herring
2017-02-06 15:18 ` Greg KH
2017-02-06 20:38 ` Stephen Rothwell
2016-09-30 3:54 Stephen Rothwell
2016-09-30 5:46 ` Greg KH
2015-08-18 6:01 Stephen Rothwell
2015-08-18 16:12 ` Greg KH
2015-05-11 5:16 Stephen Rothwell
2015-05-11 10:42 ` Dave Martin
2014-09-30 7:39 Stephen Rothwell
2014-09-30 7:52 ` Sebastian Andrzej Siewior
2014-09-30 8:09 ` Stephen Rothwell
2014-09-25 6:30 Stephen Rothwell
2014-09-25 11:04 ` Greg KH
2014-05-29 7:28 Stephen Rothwell
[not found] ` <5EB3BFCD089AD643B9BB63439F5FD5E9012BF05ED1@SHAASIEXM01.ASIA.ROOT.PRI>
2014-05-29 12:29 ` Barry Song
2013-10-31 7:40 Stephen Rothwell
2013-10-31 10:35 ` Sedat Dilek
2013-10-31 13:09 ` Philippe Proulx
2013-10-31 13:24 ` Greg KH
2013-07-24 4:42 Stephen Rothwell
2013-07-24 13:29 ` Peter Hurley
2013-05-21 3:25 Stephen Rothwell
2012-10-24 2:28 Stephen Rothwell
2012-10-24 2:51 ` Greg KH
2012-09-06 5:10 Stephen Rothwell
2012-09-06 11:47 ` Alan Cox
2012-07-20 3:33 Stephen Rothwell
2012-07-25 22:51 ` Stephen Rothwell
2012-07-26 0:25 ` Alan Cox
2012-07-20 3:28 Stephen Rothwell
2012-07-25 22:47 ` Greg KH
2012-07-25 22:49 ` Stephen Rothwell
2012-07-19 4:36 Stephen Rothwell
2012-07-19 10:41 ` Alan Cox
2012-07-17 3:45 Stephen Rothwell
2012-07-17 10:10 ` Alan Cox
2012-07-17 15:45 ` Greg KH
2012-07-17 15:45 ` Greg KH
2012-07-17 16:05 ` Alan Cox
2012-07-13 4:13 Stephen Rothwell
2012-07-13 11:10 ` Alan Cox
2012-07-20 18:38 ` Geert Uytterhoeven
2012-07-20 20:55 ` Alan Cox
2012-07-20 21:06 ` Geert Uytterhoeven
2012-04-10 3:06 Stephen Rothwell
2011-08-24 4:33 Stephen Rothwell
2011-08-24 4:50 ` Greg KH
2011-02-24 5:40 Stephen Rothwell
2011-02-25 17:54 ` Greg KH
2010-09-23 4:20 Stephen Rothwell
2010-09-23 14:14 ` Greg KH
2010-09-23 15:13 ` Randy Dunlap
2010-09-23 15:46 ` Alan Cox
2010-09-23 17:12 ` Alan Cox
2010-09-23 17:13 ` Randy Dunlap
2010-07-27 5:18 Stephen Rothwell
2010-07-27 7:43 ` Alan Cox
2010-07-27 16:47 ` Greg KH
2010-07-28 1:19 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320125137.EDCD3802B0@viridian.itc.virginia.edu \
--to=wfp5p@viridian.itc.virginia.edu \
--cc=greg@kroah.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).