linux-next: build failure after merge of the tty tree

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/net/caif/caif_serial.c: In function 'update_tty_status':
drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' has no member named 'warned'

Caused by commit 6865ff222cca ("TTY: do not warn about setting speed via
SPD_*").

drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no member named 'is_open'
drivers/usb/serial/quatech2.c:705:15: error: 'struct qt2_port_private' has no member named 'is_open'

Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
is_open").  grep is your friend (or searching while editting the file).

I have used the tty tree from next-20130319 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

Hi,

On 03/20/2013 04:12 AM, Stephen Rothwell wrote:
> drivers/net/caif/caif_serial.c: In function 'update_tty_status': 
> drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct'
> has no member named 'warned'
> 
> Caused by commit 6865ff222cca ("TTY: do not warn about setting
> speed via SPD_*").

I wonder why this didn't trigger locally. I have to check if I have
debugfs enabled. In any way, I will send a patch to fix this later today.

> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
> drivers/usb/serial/quatech2.c:661:18: error: 'struct
> qt2_port_private' has no member named 'is_open' 
> drivers/usb/serial/quatech2.c:705:15: error: 'struct
> qt2_port_private' has no member named 'is_open'
> 
> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
> is_open").  grep is your friend (or searching while editting the
> file).

I think this is caused by another commit. Bill added a check for
is_open meanwhile I removed that member completely. Bill, could you
fix that up, please?

thanks,
-- 
js
suse labs

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
> 
> > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
> > drivers/usb/serial/quatech2.c:661:18: error: 'struct
> > qt2_port_private' has no member named 'is_open' 
> > drivers/usb/serial/quatech2.c:705:15: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> > 
> > Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
> > is_open").  grep is your friend (or searching while editting the
> > file).
> 
> I think this is caused by another commit. Bill added a check for
> is_open meanwhile I removed that member completely. Bill, could you
> fix that up, please?
> 

Is it legal to call tty_flip_buffer_push() without an open tty?  If
so, I can get rid of the is_open logic completely.  Otherwise, I need
to either keep is_open or otherwise check for a valid tty before
calling tty_flip_buffer_push().

-- 
Bill

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

On 03/20/2013 01:51 PM, Bill Pemberton wrote:
> Jiri Slaby writes:
>>
>>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
>>> drivers/usb/serial/quatech2.c:661:18: error: 'struct
>>> qt2_port_private' has no member named 'is_open' 
>>> drivers/usb/serial/quatech2.c:705:15: error: 'struct
>>> qt2_port_private' has no member named 'is_open'
>>>
>>> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
>>> is_open").  grep is your friend (or searching while editting the
>>> file).
>>
>> I think this is caused by another commit. Bill added a check for
>> is_open meanwhile I removed that member completely. Bill, could you
>> fix that up, please?
>>
> 
> Is it legal to call tty_flip_buffer_push() without an open tty?  If
> so, I can get rid of the is_open logic completely.  Otherwise, I need
> to either keep is_open or otherwise check for a valid tty before
> calling tty_flip_buffer_push().

Yeah, it is legal to call that, as long as you have a valid tty_port.
Now, the data are queued and later flushed. The plan is to throw the
data directly on ingress in a way the drivers don't need to care.

thanks,
-- 
js
suse labs

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
> 
> On 03/20/2013 01:51 PM, Bill Pemberton wrote:
> > Jiri Slaby writes:
> >>
> >>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
> >>> drivers/usb/serial/quatech2.c:661:18: error: 'struct
> >>> qt2_port_private' has no member named 'is_open' 
> >>> drivers/usb/serial/quatech2.c:705:15: error: 'struct
> >>> qt2_port_private' has no member named 'is_open'
> >>>
> >>> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
> >>> is_open").  grep is your friend (or searching while editting the
> >>> file).
> >>
> >> I think this is caused by another commit. Bill added a check for
> >> is_open meanwhile I removed that member completely. Bill, could you
> >> fix that up, please?
> >>
> > 
> > Is it legal to call tty_flip_buffer_push() without an open tty?  If
> > so, I can get rid of the is_open logic completely.  Otherwise, I need
> > to either keep is_open or otherwise check for a valid tty before
> > calling tty_flip_buffer_push().
> 
> Yeah, it is legal to call that, as long as you have a valid tty_port.
> Now, the data are queued and later flushed. The plan is to throw the
> data directly on ingress in a way the drivers don't need to care.
> 

Ok, for the unopened ports there *should* never be any actual data to
push so the push is really doing nothing anyhow in these cases.  It's
coming from the device sending an initial change port command.

Anyhow, so my patch adding more is_open logic can be dropped and then
yours will apply fine.  What's the best way for me to handle this?
Send a revert for my patch so yours will apply or send an updated
version of your patch that removes my additions?


-- 
Bill

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> Ok, for the unopened ports there *should* never be any actual data to
> push so the push is really doing nothing anyhow in these cases.  It's
> coming from the device sending an initial change port command.
> 
> Anyhow, so my patch adding more is_open logic can be dropped and then
> yours will apply fine.  What's the best way for me to handle this?
> Send a revert for my patch so yours will apply or send an updated
> version of your patch that removes my additions?

Asking Greg to revert should suffice. I commented on that patch, but in
a different thread, so Greg missed the comment the patch is not needed
IIRC. What was the title of the patch, I cannot find it immediately :/?


-- 
js
suse labs

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
> 
> On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > Ok, for the unopened ports there *should* never be any actual data to
> > push so the push is really doing nothing anyhow in these cases.  It's
> > coming from the device sending an initial change port command.
> > 
> > Anyhow, so my patch adding more is_open logic can be dropped and then
> > yours will apply fine.  What's the best way for me to handle this?
> > Send a revert for my patch so yours will apply or send an updated
> > version of your patch that removes my additions?
> 
> Asking Greg to revert should suffice. I commented on that patch, but in
> a different thread, so Greg missed the comment the patch is not needed
> IIRC. What was the title of the patch, I cannot find it immediately :/?
> 

"USB: quatech2: only write to the tty if the port is open." (commit
27b351c in v3.9-rc3).

-- 
Bill

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> Jiri Slaby writes:
> > 
> > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > Ok, for the unopened ports there *should* never be any actual data to
> > > push so the push is really doing nothing anyhow in these cases.  It's
> > > coming from the device sending an initial change port command.
> > > 
> > > Anyhow, so my patch adding more is_open logic can be dropped and then
> > > yours will apply fine.  What's the best way for me to handle this?
> > > Send a revert for my patch so yours will apply or send an updated
> > > version of your patch that removes my additions?
> > 
> > Asking Greg to revert should suffice. I commented on that patch, but in
> > a different thread, so Greg missed the comment the patch is not needed
> > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > 
> 
> "USB: quatech2: only write to the tty if the port is open." (commit
> 27b351c in v3.9-rc3).

I've now reverted this, so it should be ok.

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Hi Greg,

On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > Jiri Slaby writes:
> > > 
> > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > 
> > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > a different thread, so Greg missed the comment the patch is not needed
> > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > 
> > "USB: quatech2: only write to the tty if the port is open." (commit
> > 27b351c in v3.9-rc3).
> 
> I've now reverted this, so it should be ok.

That patch needed to be reverted in your tty tree, not your usb tree
since it breaks a patch added to your tty tree (see Subject).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hi Greg,

On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > > Jiri Slaby writes:
> > > > 
> > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > > 
> > > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > > a different thread, so Greg missed the comment the patch is not needed
> > > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > > 
> > > "USB: quatech2: only write to the tty if the port is open." (commit
> > > 27b351c in v3.9-rc3).
> > 
> > I've now reverted this, so it should be ok.
> 
> That patch needed to be reverted in your tty tree, not your usb tree
> since it breaks a patch added to your tty tree (see Subject).

Except, of course, commit 27b351c is not in your tty tree :-(

I will continue to carry a revert of 27b351c as a merge fix for when I
merge the tty tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH <greg@kroah.com> wrote:
> > >
> > > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > > > Jiri Slaby writes:
> > > > > 
> > > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > > > 
> > > > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > > > a different thread, so Greg missed the comment the patch is not needed
> > > > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > > > 
> > > > "USB: quatech2: only write to the tty if the port is open." (commit
> > > > 27b351c in v3.9-rc3).
> > > 
> > > I've now reverted this, so it should be ok.
> > 
> > That patch needed to be reverted in your tty tree, not your usb tree
> > since it breaks a patch added to your tty tree (see Subject).
> 
> Except, of course, commit 27b351c is not in your tty tree :-(

Which was causing me lots of confusion :)

I've merged it in there now, and reverted it, so all should be good.

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi Greg,

On Thu, 21 Mar 2013 16:47:24 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote:
> > 
> > Except, of course, commit 27b351c is not in your tty tree :-(
> 
> Which was causing me lots of confusion :)
> 
> I've merged it in there now, and reverted it, so all should be good.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Mar 22, 2013 at 09:54:23AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > > Jiri Slaby writes:
> > > > 
> > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > > 
> > > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > > a different thread, so Greg missed the comment the patch is not needed
> > > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > > 
> > > "USB: quatech2: only write to the tty if the port is open." (commit
> > > 27b351c in v3.9-rc3).
> > 
> > I've now reverted this, so it should be ok.
> 
> That patch needed to be reverted in your tty tree, not your usb tree
> since it breaks a patch added to your tty tree (see Subject).

Ah, ok, I've done that now, sorry for the confusion.

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

Hi Greg,

On Wed, 20 Mar 2013 14:12:11 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/net/caif/caif_serial.c: In function 'update_tty_status':
> drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' has no member named 'warned'
> 
> Caused by commit 6865ff222cca ("TTY: do not warn about setting speed via
> SPD_*").

I still have this error today so have still used the tty tree from
next-20130319.

> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no member named 'is_open'
> drivers/usb/serial/quatech2.c:705:15: error: 'struct qt2_port_private' has no member named 'is_open'
> 
> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
> is_open").  grep is your friend (or searching while editting the file).

As has been reported, this one is fixed by reverting commit 27b351c "USB:
quatech2: only write to the tty if the port is open".

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "serial_base_add_isa_preferred_console" [drivers/tty/serial/8250/8250.ko] undefined!

Caused by commit

  a8b04cfe7dad ("serial: 8250: Add preferred console in serial8250_isa_init_ports()")

I have used the tty tree from next-20240410 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Tony Lindgren]

* Stephen Rothwell <sfr@canb.auug.org.au> [240411 05:48]:
> Hi all,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: modpost: "serial_base_add_isa_preferred_console" [drivers/tty/serial/8250/8250.ko] undefined!
> 
> Caused by commit
> 
>   a8b04cfe7dad ("serial: 8250: Add preferred console in serial8250_isa_init_ports()")
> 
> I have used the tty tree from next-20240410 for today.

OK thanks, I'll take a look and send a fix.

Regards,

Tony

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2843 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/tty/serial/qcom_geni_serial.c: In function 'setup_fifos':
drivers/tty/serial/qcom_geni_serial.c:1058:17: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
 1058 |         if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
      |                 ^~
drivers/tty/serial/qcom_geni_serial.c:1059:21: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
 1059 |                 port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
      |                     ^~
drivers/tty/serial/qcom_geni_serial.c:1059:63: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
 1059 |                 port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
      |                                                               ^~
drivers/tty/serial/qcom_geni_serial.c:1062:26: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
 1062 |                 if (!port->rx_fifo)
      |                          ^~

Caused by commit

  2aaa43c70778 ("tty: serial: qcom-geni-serial: add support for serial engine DMA")

interacting with commit

  b8caf69a6946 ("tty: serial: qcom-geni-serial: fix slab-out-of-bounds on RX FIFO buffer")

from Linus' tree.

I have applied the following merge fix patch for today (I am not sure
if it is actually correct, but it builds).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 23 Jan 2023 13:09:27 +1100
Subject: [PATCH] tty: fix up for "tty: serial: qcom-geni-serial: add support
 for serial engine DMA"

interacting with "tty: serial: qcom-geni-serial: fix slab-out-of-bounds
on RX FIFO buffer".

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/tty/serial/qcom_geni_serial.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index d98e0a8aae7c..61350007bf1c 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -1055,11 +1055,11 @@ static int setup_fifos(struct qcom_geni_serial_port *port)
 	uport->fifosize =
 		(port->tx_fifo_depth * port->tx_fifo_width) / BITS_PER_BYTE;
 
-	if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
-		port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
+	if (port->rx_buf && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
+		port->rx_buf = devm_krealloc(uport->dev, port->rx_buf,
 					      port->rx_fifo_depth * sizeof(u32),
 					      GFP_KERNEL);
-		if (!port->rx_fifo)
+		if (!port->rx_buf)
 			return -ENOMEM;
 	}
 
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Bartosz Golaszewski]

On Mon, 23 Jan 2023 at 03:18, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/tty/serial/qcom_geni_serial.c: In function 'setup_fifos':
> drivers/tty/serial/qcom_geni_serial.c:1058:17: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
>  1058 |         if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
>       |                 ^~
> drivers/tty/serial/qcom_geni_serial.c:1059:21: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
>  1059 |                 port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
>       |                     ^~
> drivers/tty/serial/qcom_geni_serial.c:1059:63: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
>  1059 |                 port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
>       |                                                               ^~
> drivers/tty/serial/qcom_geni_serial.c:1062:26: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
>  1062 |                 if (!port->rx_fifo)
>       |                          ^~
>
> Caused by commit
>
>   2aaa43c70778 ("tty: serial: qcom-geni-serial: add support for serial engine DMA")
>
> interacting with commit
>
>   b8caf69a6946 ("tty: serial: qcom-geni-serial: fix slab-out-of-bounds on RX FIFO buffer")
>
> from Linus' tree.
>
> I have applied the following merge fix patch for today (I am not sure
> if it is actually correct, but it builds).
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 23 Jan 2023 13:09:27 +1100
> Subject: [PATCH] tty: fix up for "tty: serial: qcom-geni-serial: add support
>  for serial engine DMA"
>
> interacting with "tty: serial: qcom-geni-serial: fix slab-out-of-bounds
> on RX FIFO buffer".
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index d98e0a8aae7c..61350007bf1c 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1055,11 +1055,11 @@ static int setup_fifos(struct qcom_geni_serial_port *port)
>         uport->fifosize =
>                 (port->tx_fifo_depth * port->tx_fifo_width) / BITS_PER_BYTE;
>
> -       if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
> -               port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
> +       if (port->rx_buf && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
> +               port->rx_buf = devm_krealloc(uport->dev, port->rx_buf,
>                                               port->rx_fifo_depth * sizeof(u32),
>                                               GFP_KERNEL);
> -               if (!port->rx_fifo)
> +               if (!port->rx_buf)
>                         return -ENOMEM;
>         }
>
> --
> 2.35.1
>
> --
> Cheers,
> Stephen Rothwell

This looks fine and works fine:

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tested-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Jan 23, 2023 at 10:46:28AM +0100, Bartosz Golaszewski wrote:
> On Mon, 23 Jan 2023 at 03:18, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > drivers/tty/serial/qcom_geni_serial.c: In function 'setup_fifos':
> > drivers/tty/serial/qcom_geni_serial.c:1058:17: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
> >  1058 |         if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
> >       |                 ^~
> > drivers/tty/serial/qcom_geni_serial.c:1059:21: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
> >  1059 |                 port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
> >       |                     ^~
> > drivers/tty/serial/qcom_geni_serial.c:1059:63: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
> >  1059 |                 port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
> >       |                                                               ^~
> > drivers/tty/serial/qcom_geni_serial.c:1062:26: error: 'struct qcom_geni_serial_port' has no member named 'rx_fifo'
> >  1062 |                 if (!port->rx_fifo)
> >       |                          ^~
> >
> > Caused by commit
> >
> >   2aaa43c70778 ("tty: serial: qcom-geni-serial: add support for serial engine DMA")
> >
> > interacting with commit
> >
> >   b8caf69a6946 ("tty: serial: qcom-geni-serial: fix slab-out-of-bounds on RX FIFO buffer")
> >
> > from Linus' tree.
> >
> > I have applied the following merge fix patch for today (I am not sure
> > if it is actually correct, but it builds).
> >
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Mon, 23 Jan 2023 13:09:27 +1100
> > Subject: [PATCH] tty: fix up for "tty: serial: qcom-geni-serial: add support
> >  for serial engine DMA"
> >
> > interacting with "tty: serial: qcom-geni-serial: fix slab-out-of-bounds
> > on RX FIFO buffer".
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > ---
> >  drivers/tty/serial/qcom_geni_serial.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> > index d98e0a8aae7c..61350007bf1c 100644
> > --- a/drivers/tty/serial/qcom_geni_serial.c
> > +++ b/drivers/tty/serial/qcom_geni_serial.c
> > @@ -1055,11 +1055,11 @@ static int setup_fifos(struct qcom_geni_serial_port *port)
> >         uport->fifosize =
> >                 (port->tx_fifo_depth * port->tx_fifo_width) / BITS_PER_BYTE;
> >
> > -       if (port->rx_fifo && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
> > -               port->rx_fifo = devm_krealloc(uport->dev, port->rx_fifo,
> > +       if (port->rx_buf && (old_rx_fifo_depth != port->rx_fifo_depth) && port->rx_fifo_depth) {
> > +               port->rx_buf = devm_krealloc(uport->dev, port->rx_buf,
> >                                               port->rx_fifo_depth * sizeof(u32),
> >                                               GFP_KERNEL);
> > -               if (!port->rx_fifo)
> > +               if (!port->rx_buf)
> >                         return -ENOMEM;
> >         }
> >
> > --
> > 2.35.1
> >
> > --
> > Cheers,
> > Stephen Rothwell
> 
> This looks fine and works fine:
> 
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Tested-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Thanks for this, someone else just sent the same thing, I've queued it
up too.

greg k-h

linux-next: build failure after merge of the tty tree

[broonie]

Hi all,

After merging the tty tree, today's linux-next build (x86 allmodconfig)
failed like this:

In file included from /tmp/next/build/include/linux/device.h:15,
                 from /tmp/next/build/include/linux/node.h:18,
                 from /tmp/next/build/include/linux/cpu.h:17,
                 from /tmp/next/build/include/linux/of_device.h:5,
                 from /tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:14:
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c: In function 'qcom_geni_serial_set_termios':
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1039:4: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format=]
 1039 |    "Couldn't find suitable clock rate for %lu\n",
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
  110 |   _p_func(dev, fmt, ##__VA_ARGS__);   \
      |                ^~~
/tmp/next/build/include/linux/dev_printk.h:144:49: note: in expansion of macro 'dev_fmt'
  144 |  dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                                                 ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1038:3: note: in expansion of macro 'dev_err'
 1038 |   dev_err(port->se.dev,
      |   ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1039:45: note: format string is defined here
 1039 |    "Couldn't find suitable clock rate for %lu\n",
      |                                           ~~^
      |                                             |
      |                                             long unsigned int
      |                                           %u
In file included from /tmp/next/build/include/linux/printk.h:573,
                 from /tmp/next/build/include/linux/kernel.h:29,
                 from /tmp/next/build/include/linux/clk.h:13,
                 from /tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:7:
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1044:24: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
 1044 |  dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:134:15: note: in definition of macro '__dynamic_func_call'
  134 |   func(&id, ##__VA_ARGS__);  \
      |               ^~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:166:2: note: in expansion of macro '_dynamic_func_call'
  166 |  _dynamic_func_call(fmt,__dynamic_dev_dbg,   \
      |  ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:155:2: note: in expansion of macro 'dynamic_dev_dbg'
  155 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
      |  ^~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:155:23: note: in expansion of macro 'dev_fmt'
  155 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                       ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1044:2: note: in expansion of macro 'dev_dbg'
 1044 |  dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
      |  ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1044:40: note: format string is defined here
 1044 |  dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
      |                                      ~~^
      |                                        |
      |                                        long unsigned int
      |                                      %u

Caused by commit

  c474c775716edd46a5 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")

I have used the tree from 20220727 instead.

Re: linux-next: build failure after merge of the tty tree

[Doug Anderson]

Hi,

On Tue, Aug 2, 2022 at 1:07 PM <broonie@kernel.org> wrote:
>
> Caused by commit
>
>   c474c775716edd46a5 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
>
> I have used the tree from 20220727 instead.

Posted a fix: ("tty: serial: qcom-geni-serial: Fix %lu -> %u in print
statements") [1]

[1] https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Aug 02, 2022 at 01:27:25PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Aug 2, 2022 at 1:07 PM <broonie@kernel.org> wrote:
> >
> > Caused by commit
> >
> >   c474c775716edd46a5 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
> >
> > I have used the tree from 20220727 instead.
> 
> Posted a fix: ("tty: serial: qcom-geni-serial: Fix %lu -> %u in print
> statements") [1]
> 
> [1] https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid

Thanks, I'll pick it up now.

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_suspend':
drivers/tty/serial/stm32-usart.c:1298:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_sleep_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_resume':
drivers/tty/serial/stm32-usart.c:1307:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
  pinctrl_pm_select_default_state(dev);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  c70669ecef4e ("serial: stm32: select pinctrl state in each suspend/resume function")

I have used the tty tree from next-20190612 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Jun 13, 2019 at 03:32:15PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_suspend':
> drivers/tty/serial/stm32-usart.c:1298:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
>   pinctrl_pm_select_sleep_state(dev);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_resume':
> drivers/tty/serial/stm32-usart.c:1307:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
>   pinctrl_pm_select_default_state(dev);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   c70669ecef4e ("serial: stm32: select pinctrl state in each suspend/resume function")

Yeah, I think I need to just go revert that patch now, thanks.

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 7048 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_enable':
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:138:2: note: in expansion of macro 'rx_enabled'
  rx_enabled(port) = 1;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_disable':
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:153:2: note: in expansion of macro 'rx_enabled'
  rx_enabled(port) = 0;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_tx':
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:165:7: note: in expansion of macro 'tx_enabled'
  if (!tx_enabled(port))
       ^~~~~~~~~~
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:185:2: note: in expansion of macro 'tx_enabled'
  tx_enabled(port) = 0;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_start_tx':
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:343:7: note: in expansion of macro 'tx_enabled'
  if (!tx_enabled(port)) {
       ^~~~~~~~~~
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:347:3: note: in expansion of macro 'tx_enabled'
   tx_enabled(port) = 1;
   ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_rx':
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:392:6: note: in expansion of macro 'rx_enabled'
  if (rx_enabled(port)) {
      ^~~~~~~~~~
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:399:3: note: in expansion of macro 'rx_enabled'
   rx_enabled(port) = 0;
   ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_drain_fifo':
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:621:8: note: in expansion of macro 'rx_enabled'
    if (rx_enabled(port)) {
        ^~~~~~~~~~
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:623:6: note: in expansion of macro 'rx_enabled'
      rx_enabled(port) = 0;
      ^~~~~~~~~~
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:631:6: note: in expansion of macro 'rx_enabled'
      rx_enabled(port) = 1;
      ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_shutdown':
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:981:3: note: in expansion of macro 'tx_enabled'
   tx_enabled(port) = 0;
   ^~~~~~~~~~
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:990:3: note: in expansion of macro 'rx_enabled'
   rx_enabled(port) = 0;
   ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_startup':
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:1015:2: note: in expansion of macro 'rx_enabled'
  rx_enabled(port) = 1;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:1029:2: note: in expansion of macro 'tx_enabled'
  tx_enabled(port) = 1;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c64xx_serial_startup':
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:1080:2: note: in expansion of macro 'rx_enabled'
  rx_enabled(port) = 1;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:1082:2: note: in expansion of macro 'tx_enabled'
  tx_enabled(port) = 0;
  ^~~~~~~~~~
drivers/tty/serial/samsung.c: In function 's3c24xx_serial_resume_noirq':
drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
 #define tx_enabled(port) ((port)->unused[0])
                                         ^
drivers/tty/serial/samsung.c:1966:8: note: in expansion of macro 'tx_enabled'
    if (tx_enabled(port))
        ^~~~~~~~~~
drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
 #define rx_enabled(port) ((port)->unused[1])
                                         ^
drivers/tty/serial/samsung.c:1968:8: note: in expansion of macro 'rx_enabled'
    if (rx_enabled(port))
        ^~~~~~~~~~

Caused by commit

  c550f01c810f ("serial:serial_core: Allow use of CTS for PPS line discipline")

Looks like a suprise from some "interesting" previous development.

I have used the tty tree from next-20181003 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

Interesting indeed. Who would have thought someone would be using the
"unused" padding variable!

How would folks prefer we fix this, in the referenced patch or by
eliminating the use of "unused" in samsung.c?

Steve
On Wed, Oct 3, 2018 at 7:19 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_enable':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:138:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_disable':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:153:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 0;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_tx':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:165:7: note: in expansion of macro 'tx_enabled'
>   if (!tx_enabled(port))
>        ^~~~~~~~~~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:185:2: note: in expansion of macro 'tx_enabled'
>   tx_enabled(port) = 0;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_start_tx':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:343:7: note: in expansion of macro 'tx_enabled'
>   if (!tx_enabled(port)) {
>        ^~~~~~~~~~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:347:3: note: in expansion of macro 'tx_enabled'
>    tx_enabled(port) = 1;
>    ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_rx':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:392:6: note: in expansion of macro 'rx_enabled'
>   if (rx_enabled(port)) {
>       ^~~~~~~~~~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:399:3: note: in expansion of macro 'rx_enabled'
>    rx_enabled(port) = 0;
>    ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_drain_fifo':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:621:8: note: in expansion of macro 'rx_enabled'
>     if (rx_enabled(port)) {
>         ^~~~~~~~~~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:623:6: note: in expansion of macro 'rx_enabled'
>       rx_enabled(port) = 0;
>       ^~~~~~~~~~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:631:6: note: in expansion of macro 'rx_enabled'
>       rx_enabled(port) = 1;
>       ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_shutdown':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:981:3: note: in expansion of macro 'tx_enabled'
>    tx_enabled(port) = 0;
>    ^~~~~~~~~~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:990:3: note: in expansion of macro 'rx_enabled'
>    rx_enabled(port) = 0;
>    ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_startup':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:1015:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:1029:2: note: in expansion of macro 'tx_enabled'
>   tx_enabled(port) = 1;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c64xx_serial_startup':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:1080:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:1082:2: note: in expansion of macro 'tx_enabled'
>   tx_enabled(port) = 0;
>   ^~~~~~~~~~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_resume_noirq':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>                                          ^
> drivers/tty/serial/samsung.c:1966:8: note: in expansion of macro 'tx_enabled'
>     if (tx_enabled(port))
>         ^~~~~~~~~~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>                                          ^
> drivers/tty/serial/samsung.c:1968:8: note: in expansion of macro 'rx_enabled'
>     if (rx_enabled(port))
>         ^~~~~~~~~~
>
> Caused by commit
>
>   c550f01c810f ("serial:serial_core: Allow use of CTS for PPS line discipline")
>
> Looks like a suprise from some "interesting" previous development.
>
> I have used the tty tree from next-20181003 for today.
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the tty tree

[Greg Kroah-Hartman]

On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote:
> Interesting indeed. Who would have thought someone would be using the
> "unused" padding variable!

Ugh :(

> How would folks prefer we fix this, in the referenced patch or by
> eliminating the use of "unused" in samsung.c?

We should just get rid of the "unused" fields entirely.  They aren't
needed here as this is not a structure that anyone really cares about.
We can move things around a bit if the padding is an issue.

I've reverted this patch first for now.  I suggest a patch to the uart
core to drop the unused fields and fix up the samsung driver and then
your patch can go on top of that.  Can you work on this?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman <greg@kroah.com> wrote:

> We should just get rid of the "unused" fields entirely.  They aren't
> needed here as this is not a structure that anyone really cares about.
> We can move things around a bit if the padding is an issue.
>
> I've reverted this patch first for now.  I suggest a patch to the uart
> core to drop the unused fields and fix up the samsung driver and then
> your patch can go on top of that.  Can you work on this?

Yes I can. Stay tuned . . .

Steve

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

Hi Greg,

I sent the patch you requested to fix use of the "unused" struct
member in samsung.c. If that looks OK to you I'll redo my
"serial:serial_core: Allow use of CTS for PPS line discipline" patch.

Thanks,

Steve
On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman <greg@kroah.com> wrote:
>
> On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote:
> > Interesting indeed. Who would have thought someone would be using the
> > "unused" padding variable!
>
> Ugh :(
>
> > How would folks prefer we fix this, in the referenced patch or by
> > eliminating the use of "unused" in samsung.c?
>
> We should just get rid of the "unused" fields entirely.  They aren't
> needed here as this is not a structure that anyone really cares about.
> We can move things around a bit if the padding is an issue.
>
> I've reverted this patch first for now.  I suggest a patch to the uart
> core to drop the unused fields and fix up the samsung driver and then
> your patch can go on top of that.  Can you work on this?
>
> thanks,
>
> greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg Kroah-Hartman]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Oct 04, 2018 at 08:13:39AM -1000, Steve Sakoman wrote:
> Hi Greg,
> 
> I sent the patch you requested to fix use of the "unused" struct
> member in samsung.c. If that looks OK to you I'll redo my
> "serial:serial_core: Allow use of CTS for PPS line discipline" patch.

I think it needs a bit of a rework, see my review comments on that
patch.

thanks,

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
 static const struct of_device_id at91_usart_mode_of_match[] = {
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
  { .compatible = "atmel,at91rm9200-usart" },
    ^
drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
  { .compatible = "atmel,at91sam9260-usart" },
    ^
drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
 static const struct of_device_id at91_usart_mode_of_match[] = {
                                  ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")

Forgot to include <linux/mod_devicetable.h>?

I used the version of the tty tree from next-20180910 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91rm9200-usart" },
>     ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91sam9260-usart" },
>     ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include <linux/mod_devicetable.h>?
> 
> I used the version of the tty tree from next-20180910 for today.

Very odd, I just pulled in the "Immutable" branch from Lee here.

Lee, is there something I am missing to get this to build properly?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Stephen Rothwell wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91rm9200-usart" },
>     ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91sam9260-usart" },
>     ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include <linux/mod_devicetable.h>?

Looks like a missing Device Tree header <linux/of.h>.

Will chase this today and follow up with another PR.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Nicolas Ferre]

On 11/09/2018 at 10:25, Lee Jones wrote:
> On Tue, 11 Sep 2018, Stephen Rothwell wrote:
> 
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
>>   static const struct of_device_id at91_usart_mode_of_match[] = {
>>                                    ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
>>    { .compatible = "atmel,at91rm9200-usart" },
>>      ^
>> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
>> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
>>    { .compatible = "atmel,at91sam9260-usart" },
>>      ^
>> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
>> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
>>   static const struct of_device_id at91_usart_mode_of_match[] = {
>>                                    ^~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>>    7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
>>
>> Forgot to include <linux/mod_devicetable.h>?
> 
> Looks like a missing Device Tree header <linux/of.h>.
> 
> Will chase this today and follow up with another PR.

Hi all,

Actually it is due to the missing of  <linux/mod_devicetable.h> as 
Stephen suggested. It is due to the patch ac3167257b9f ("headers: 
separate linux/mod_devicetable.h from linux/platform_device.h") merged 
in v4.19-rc1.

because linux/platform_device.h was included by linux/mfd/core.h that is 
present in this driver. This is why the issue was not identified beforehand.

I'm building a tiny patch to address this right now.

Thanks for your help. Best regards,
-- 
Nicolas Ferre

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> On 11/09/2018 at 10:25, Lee Jones wrote:
> > On Tue, 11 Sep 2018, Stephen Rothwell wrote:
> > 
> > > Hi Greg,
> > > 
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > > 
> > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >                                    ^~~~~~~~~~~~~~~~~~~~~~~~
> > > drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
> > >    { .compatible = "atmel,at91rm9200-usart" },
> > >      ^
> > > drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
> > >    { .compatible = "atmel,at91sam9260-usart" },
> > >      ^
> > > drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >                                    ^~~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > Caused by commit
> > > 
> > >    7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> > > 
> > > Forgot to include <linux/mod_devicetable.h>?
> > 
> > Looks like a missing Device Tree header <linux/of.h>.
> > 
> > Will chase this today and follow up with another PR.
> 
> Hi all,
> 
> Actually it is due to the missing of  <linux/mod_devicetable.h> as Stephen
> suggested. It is due to the patch ac3167257b9f ("headers: separate
> linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.

Since this set uses Device Tree, it really should include the of.h.

This solves the issue reported above.

I will fix-up and re-send the pull-request.

> because linux/platform_device.h was included by linux/mfd/core.h that is
> present in this driver. This is why the issue was not identified beforehand.
> 
> I'm building a tiny patch to address this right now.
> 
> Thanks for your help. Best regards,

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Andy Shevchenko]

On Tue, Sep 11, 2018 at 11:43 AM Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> > Actually it is due to the missing of  <linux/mod_devicetable.h> as Stephen
> > suggested. It is due to the patch ac3167257b9f ("headers: separate
> > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.
>
> Since this set uses Device Tree, it really should include the of.h.

I didn't remember the contents of the driver, but I would disagree on
a statement that
*using* of_device_id table implies necessity of linux/of.h inclusion.

>
> This solves the issue reported above.
>
> I will fix-up and re-send the pull-request.


-- 
With Best Regards,
Andy Shevchenko

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

.config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
*
* Restart config...
*
*
* Serial drivers
*
8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
	.
	.
	.
SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
  Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) aborted!

Console input/output is redirected. Run 'make oldconfig' to update configuration.


Caused by commit

  f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")

I have used the tty tree from next-20171215 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Stephen,

On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> *
> * Restart config...
> *
> *
> * Serial drivers
> *
> 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
>         .
>         .
>         .
> SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
>   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) aborted!
>
> Console input/output is redirected. Run 'make oldconfig' to update configuration.
>
>
> Caused by commit
>
>   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
>
> I have used the tty tree from next-20171215 for today.

Sorry, silly misunderstanding of Kconfig behavior on my side.
Patch sent.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote:
> Hi Stephen,
> 
> On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> > *
> > * Restart config...
> > *
> > *
> > * Serial drivers
> > *
> > 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> >         .
> >         .
> >         .
> > SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
> >   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) aborted!
> >
> > Console input/output is redirected. Run 'make oldconfig' to update configuration.
> >
> >
> > Caused by commit
> >
> >   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
> >
> > I have used the tty tree from next-20171215 for today.
> 
> Sorry, silly misunderstanding of Kconfig behavior on my side.
> Patch sent.

Really?  I don't see the patch anywhere, can you resend it please?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Dec 18, 2017 at 10:02:08AM +0100, Greg KH wrote:
> On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote:
> > Hi Stephen,
> > 
> > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> > > *
> > > * Restart config...
> > > *
> > > *
> > > * Serial drivers
> > > *
> > > 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> > >         .
> > >         .
> > >         .
> > > SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
> > >   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) aborted!
> > >
> > > Console input/output is redirected. Run 'make oldconfig' to update configuration.
> > >
> > >
> > > Caused by commit
> > >
> > >   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
> > >
> > > I have used the tty tree from next-20171215 for today.
> > 
> > Sorry, silly misunderstanding of Kconfig behavior on my side.
> > Patch sent.
> 
> Really?  I don't see the patch anywhere, can you resend it please?

Got it now, thanks!

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!

Caused by commit

  cd6484e1830b ("serdev: Introduce new bus for serial attached devices")

I have used the tty tree from next-20170203 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> 
> Caused by commit
> 
>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> 
> I have used the tty tree from next-20170203 for today.

Ugh, how has this been passing the 0-day bot builds succesfully?

Rob, any ideas?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Rob Herring]

On Mon, Feb 6, 2017 at 2:51 AM, Greg KH <greg@kroah.com> wrote:
> On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>>
>> Caused by commit
>>
>>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
>>
>> I have used the tty tree from next-20170203 for today.
>
> Ugh, how has this been passing the 0-day bot builds succesfully?
>
> Rob, any ideas?

It didn't, but we happened to already have a fix queued up for 4.11.
The fix is in your usb-next branch:

commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
Author: Stephen Boyd <stephen.boyd@linaro.org>
Date:   Wed Dec 28 14:56:48 2016 -0800

    of: device: Export of_device_{get_modalias, uvent_modalias} to modules

    The ULPI bus can be built as a module, and it will soon be
    calling these functions when it supports probing devices from DT.
    Export them so they can be used by the ULPI module.

    Acked-by: Rob Herring <robh@kernel.org>
    Cc: <devicetree@vger.kernel.org>
    Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
    Signed-off-by: Peter Chen <peter.chen@nxp.com>

Rob

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> On Mon, Feb 6, 2017 at 2:51 AM, Greg KH <greg@kroah.com> wrote:
> > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> >> Hi Greg,
> >>
> >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> >> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> >>
> >> Caused by commit
> >>
> >>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> >>
> >> I have used the tty tree from next-20170203 for today.
> >
> > Ugh, how has this been passing the 0-day bot builds succesfully?
> >
> > Rob, any ideas?
> 
> It didn't, but we happened to already have a fix queued up for 4.11.
> The fix is in your usb-next branch:
> 
> commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> Author: Stephen Boyd <stephen.boyd@linaro.org>
> Date:   Wed Dec 28 14:56:48 2016 -0800
> 
>     of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> 
>     The ULPI bus can be built as a module, and it will soon be
>     calling these functions when it supports probing devices from DT.
>     Export them so they can be used by the ULPI module.
> 
>     Acked-by: Rob Herring <robh@kernel.org>
>     Cc: <devicetree@vger.kernel.org>
>     Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
>     Signed-off-by: Peter Chen <peter.chen@nxp.com>

Ah, so the if this is pulled into linux-next at the same time, then
there's no build error.

Stephen, do you need/want me to cherry-pick this into the tty branch, or
is it ok as-is?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Mon, 6 Feb 2017 16:18:22 +0100 Greg KH <greg@kroah.com> wrote:
>
> On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> > 
> > It didn't, but we happened to already have a fix queued up for 4.11.
> > The fix is in your usb-next branch:
> > 
> > commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> > Author: Stephen Boyd <stephen.boyd@linaro.org>
> > Date:   Wed Dec 28 14:56:48 2016 -0800
> > 
> >     of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> > 
> >     The ULPI bus can be built as a module, and it will soon be
> >     calling these functions when it supports probing devices from DT.
> >     Export them so they can be used by the ULPI module.
> > 
> >     Acked-by: Rob Herring <robh@kernel.org>
> >     Cc: <devicetree@vger.kernel.org>
> >     Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> >     Signed-off-by: Peter Chen <peter.chen@nxp.com>  
> 
> Ah, so the if this is pulled into linux-next at the same time, then
> there's no build error.
> 
> Stephen, do you need/want me to cherry-pick this into the tty branch, or
> is it ok as-is?

I will change things so that I merge the usb tree before the tty tree.
Please remember to tell Linus that they need to be merged in that order.

-- 
Cheers,
Stephen Rothwell

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match':
drivers/tty/serial/amba-pl011.c:2346:44: error: passing argument 3 of 'uart_parse_earlycon' from incompatible pointer type [-Werror=incompatible-pointer-types]
  if (uart_parse_earlycon(options, &iotype, &addr, &options))
                                            ^
In file included from drivers/tty/serial/amba-pl011.c:45:0:
include/linux/serial_core.h:384:5: note: expected 'resource_size_t * {aka unsigned int *}' but argument is of type 'long unsigned int *'
 int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
     ^

Caused by commit

  8b8f347d3a48 ("serial: pl011: add console matching function")

interacting with commit

  46e36683f433 ("serial: earlycon: Extend earlycon command line option to support 64-bit addresses")

I have reverted commit 8b8f347d3a48 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Sep 30, 2016 at 01:54:37PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match':
> drivers/tty/serial/amba-pl011.c:2346:44: error: passing argument 3 of 'uart_parse_earlycon' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   if (uart_parse_earlycon(options, &iotype, &addr, &options))
>                                             ^
> In file included from drivers/tty/serial/amba-pl011.c:45:0:
> include/linux/serial_core.h:384:5: note: expected 'resource_size_t * {aka unsigned int *}' but argument is of type 'long unsigned int *'
>  int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t *addr,
>      ^
> 
> Caused by commit
> 
>   8b8f347d3a48 ("serial: pl011: add console matching function")
> 
> interacting with commit
> 
>   46e36683f433 ("serial: earlycon: Extend earlycon command line option to support 64-bit addresses")
> 
> I have reverted commit 8b8f347d3a48 for today.

Ick, sorry about that.  I wonder why I'm not seeing that same build
failure here, odd.  I'll go revert the same patch in my tree now as
well.

thanks,

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

make[2]: *** No rule to make target 'arch/arm/boot/dts/imx6sl-fox-p1.dtb', needed by '__build'.  Stop.

Caused by commit

  189550b8644e ("serial: imx: introduce serial_imx_enable_wakeup()")

I guess a file was missed.

I partially reverted that commit:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 18 Aug 2015 15:56:40 +1000
Subject: [PATCH] serial: imx: partial revert of "introduce
 serial_imx_enable_wakeup()"

This reverts the part of commit 189550b8644e that affects
arch/arm/boot/dts/Makefile

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/arm/boot/dts/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d3ee1f01ffc7..233159d2eaab 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -330,7 +330,6 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
 	imx6q-wandboard-revb1.dtb
 dtb-$(CONFIG_SOC_IMX6SL) += \
 	imx6sl-evk.dtb \
-	imx6sl-fox-p1.dtb \
 	imx6sl-warp.dtb
 dtb-$(CONFIG_SOC_IMX6SX) += \
 	imx6sx-sabreauto.dtb \
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Aug 18, 2015 at 04:01:16PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> make[2]: *** No rule to make target 'arch/arm/boot/dts/imx6sl-fox-p1.dtb', needed by '__build'.  Stop.
> 
> Caused by commit
> 
>   189550b8644e ("serial: imx: introduce serial_imx_enable_wakeup()")
> 
> I guess a file was missed.
> 
> I partially reverted that commit:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Aug 2015 15:56:40 +1000
> Subject: [PATCH] serial: imx: partial revert of "introduce
>  serial_imx_enable_wakeup()"
> 
> This reverts the part of commit 189550b8644e that affects
> arch/arm/boot/dts/Makefile
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/arm/boot/dts/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d3ee1f01ffc7..233159d2eaab 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -330,7 +330,6 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>  	imx6q-wandboard-revb1.dtb
>  dtb-$(CONFIG_SOC_IMX6SL) += \
>  	imx6sl-evk.dtb \
> -	imx6sl-fox-p1.dtb \
>  	imx6sl-warp.dtb
>  dtb-$(CONFIG_SOC_IMX6SX) += \
>  	imx6sx-sabreauto.dtb \


Ugh, this sucks, Eduardo, what went wrong here?  I think I have to
revert the original commit now :(

thanks,

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/tty/serial/amba-pl011.c: In function 'pl011_startup':
drivers/tty/serial/amba-pl011.c:1582:5: error: 'struct uart_amba_port' has no member named 'tx_irq_seen'
  uap->tx_irq_seen = 0;
     ^

Caused by a mismerge between patch "Revert "serial/amba-pl011: Leave
the TX IRQ alone when the UART is not open" (that appears in Linus' tree
and the tty tree) and commit 1e84d22322ce ("serial/amba-pl011: Refactor
and simplify TX FIFO handling") from the tty tree.

I applied this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 11 May 2015 15:12:50 +1000
Subject: [PATCH] serial/amba-pl011: fix mismerge

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/tty/serial/amba-pl011.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 6fabc059efed..f5bd8426fd75 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1578,9 +1578,6 @@ static int pl011_startup(struct uart_port *port)
 
 	writew(uap->vendor->ifls, uap->port.membase + UART011_IFLS);
 
-	/* Assume that TX IRQ doesn't work until we see one: */
-	uap->tx_irq_seen = 0;
-
 	spin_lock_irq(&uap->port.lock);
 
 	/* restore RTS and DTR */
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Dave Martin]

On Mon, May 11, 2015 at 06:16:26AM +0100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
> 
> drivers/tty/serial/amba-pl011.c: In function 'pl011_startup':
> drivers/tty/serial/amba-pl011.c:1582:5: error: 'struct uart_amba_port' has no member named 'tx_irq_seen'
>   uap->tx_irq_seen = 0;
>      ^
> 
> Caused by a mismerge between patch "Revert "serial/amba-pl011: Leave
> the TX IRQ alone when the UART is not open" (that appears in Linus' tree
> and the tty tree) and commit 1e84d22322ce ("serial/amba-pl011: Refactor
> and simplify TX FIFO handling") from the tty tree.
> 
> I applied this merge fix patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 11 May 2015 15:12:50 +1000
> Subject: [PATCH] serial/amba-pl011: fix mismerge
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Ack.  The revert should add those lines back in; then the "Refactor
and simplify" patch gets rid of them finally.

Cheers
---Dave

> ---
>  drivers/tty/serial/amba-pl011.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index 6fabc059efed..f5bd8426fd75 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -1578,9 +1578,6 @@ static int pl011_startup(struct uart_port *port)
>  
>  	writew(uap->vendor->ifls, uap->port.membase + UART011_IFLS);
>  
> -	/* Assume that TX IRQ doesn't work until we see one: */
> -	uap->tx_irq_seen = 0;
> -
>  	spin_lock_irq(&uap->port.lock);
>  
>  	/* restore RTS and DTR */
> -- 
> 2.1.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:


drivers/built-in.o: In function `.serial8250_stop_tx':
8250_core.c:(.text+0xda1f4): undefined reference to `.__xchg_called_with_bad_pointer'
drivers/built-in.o: In function `.serial8250_tx_chars':
(.text+0xda42c): undefined reference to `.__xchg_called_with_bad_pointer'
drivers/built-in.o: In function `.serial8250_start_tx':
8250_core.c:(.text+0xda630): undefined reference to `.__xchg_called_with_bad_pointer'

Caused by commit d74d5d1b7288 ("tty: serial: 8250_core: add run time
pm").  xchg is called with &p->rpm_tx_active and that is an unsigned
char.  PowerPC (at least) only allows xchg with objects 4 (or 8 on 64
bit) bytes long.

I have used the version of the tty tree from next-20140926 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Sebastian Andrzej Siewior]

* Stephen Rothwell | 2014-09-30 17:39:00 [+1000]:

>Hi Greg,
Hi Stephen,

>After merging the tty tree, today's linux-next build (powerpc
>ppc64_defconfig) failed like this:
>
>
>drivers/built-in.o: In function `.serial8250_stop_tx':
>8250_core.c:(.text+0xda1f4): undefined reference to `.__xchg_called_with_bad_pointer'
>drivers/built-in.o: In function `.serial8250_tx_chars':
>(.text+0xda42c): undefined reference to `.__xchg_called_with_bad_pointer'
>drivers/built-in.o: In function `.serial8250_start_tx':
>8250_core.c:(.text+0xda630): undefined reference to `.__xchg_called_with_bad_pointer'
>
>Caused by commit d74d5d1b7288 ("tty: serial: 8250_core: add run time
>pm").  xchg is called with &p->rpm_tx_active and that is an unsigned
>char.  PowerPC (at least) only allows xchg with objects 4 (or 8 on 64
>bit) bytes long.
>
>I have used the version of the tty tree from next-20140926 for today.

this should have been fixed by commit baeb7ef34952f ("tty: serial: 8250:
use 32bit variable for rpm_tx_active") in Greg's tty-next tree. Isn't
this the case or did you fetch the tty tree before Greg pushed it?

Sebastian

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi Sebastian,

On Tue, 30 Sep 2014 09:52:39 +0200 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
> this should have been fixed by commit baeb7ef34952f ("tty: serial: 8250:
> use 32bit variable for rpm_tx_active") in Greg's tty-next tree. Isn't
> this the case or did you fetch the tty tree before Greg pushed it?

Presumably the latter, in which case I will see the fix tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

In file included from init/do_mounts.c:15:0:
include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
         unused:62;
         ^
include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
         unused_ctrl:55;
         ^
In file included from init/main.c:28:0:
include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
         unused:62;
         ^
include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
         unused_ctrl:55;
         ^
In file included from include/linux/serial_core.h:29:0,
                 from include/linux/serial_s3c.h:236,
                 from arch/arm/mach-exynos/exynos.c:15:
include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
         unused:62;
         ^
include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
         unused_ctrl:55;
         ^
In file included from include/linux/serial_core.h:29:0,
                 from include/linux/platform_data/serial-omap.h:20,
                 from arch/arm/mach-omap2/serial.c:30:
include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
         unused:62;
         ^
include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
         unused_ctrl:55;
         ^

Caused by commits c545b66c6922 ("tty: Serialize tcflow() with other tty
flow control changes") and 99416322dd16 ("tty: Workaround Alpha
non-atomic byte storage in tty_struct").  There are still 32 bit
architectures out there!  ;-)

I have used the tty tree from next-20140924 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Sep 25, 2014 at 04:30:36PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
> 
> In file included from init/do_mounts.c:15:0:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>          unused:62;
>          ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>          unused_ctrl:55;
>          ^
> In file included from init/main.c:28:0:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>          unused:62;
>          ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>          unused_ctrl:55;
>          ^
> In file included from include/linux/serial_core.h:29:0,
>                  from include/linux/serial_s3c.h:236,
>                  from arch/arm/mach-exynos/exynos.c:15:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>          unused:62;
>          ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>          unused_ctrl:55;
>          ^
> In file included from include/linux/serial_core.h:29:0,
>                  from include/linux/platform_data/serial-omap.h:20,
>                  from arch/arm/mach-omap2/serial.c:30:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>          unused:62;
>          ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>          unused_ctrl:55;
>          ^
> 
> Caused by commits c545b66c6922 ("tty: Serialize tcflow() with other tty
> flow control changes") and 99416322dd16 ("tty: Workaround Alpha
> non-atomic byte storage in tty_struct").  There are still 32 bit
> architectures out there!  ;-)

Sorry about that, a fix for this is now in my tree.

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/sirfsoc_uart.c: In function 'sirfsoc_uart_rx_dma_complete_tl':
drivers/tty/serial/sirfsoc_uart.c:707:2: error: 'struct uart_port' has no member named 'rx_lock'

Caused by commit 07d410e06463 ("serial: sirf: fix spinlock deadlock
issue").  Did anyone even build test this? Much less test that it fixed
the deadlock ... :-(

I have used the tty tree from next-20140528 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Barry Song]

2014-05-29 20:18 GMT+08:00 Barry Song <Barry.Song@csr.com>:
> From: Stephen Rothwell [sfr@canb.auug.org.au]
> Sent: Thursday, May 29, 2014 15:28
> To: Greg KH
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Qipan Li; Barry Song
> Subject: linux-next: build failure after merge of the tty tree
>
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/sirfsoc_uart.c: In function 'sirfsoc_uart_rx_dma_complete_tl':
> drivers/tty/serial/sirfsoc_uart.c:707:2: error: 'struct uart_port' has no member named 'rx_lock'
>
> Caused by commit 07d410e06463 ("serial: sirf: fix spinlock deadlock
> issue").  Did anyone even build test this? Much less test that it fixed
> the deadlock ... :-(
>

Stephen, it is my fault. qipan did a strange mis-operation when he
prepared this patch and i didn't double-confirm it.
but the patch did have been tested on real hardware to fix the
deadlock issue. it is not a patch without test.

the build issue has been fixed in another thread: [PATCH tty-next]
serial: sirf: Fix compilation failure
https://lkml.org/lkml/2014/5/29/476

i am very sorry for this as the related platform maintainer. i didn't
control this well and missed to do a double build for this. again, i
am very sorry!

> I have used the tty tree from next-20140528 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
>

-barry

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
drivers/tty/serial/omap-serial.c:1724:22: error: expected ')' before numeric constant
drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d' expects a matching 'int' argument [-Wformat]

Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
warnings").  There is a missing ',' in the dev_warn() ...

I have used the version of the tty tree from next-20131030 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Sedat Dilek]

On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> drivers/tty/serial/omap-serial.c:1724:22: error: expected ')' before numeric constant
> drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d' expects a matching 'int' argument [-Wformat]
>
> Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> warnings").  There is a missing ',' in the dev_warn() ...
>
> I have used the version of the tty tree from next-20131030 for today.
>

[ Add CC to linux-serial ML ]

Happy HelloWien and WelcomeBackStephen!

That was only checkpatch-tested, eh :-)?

@@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct platform_device *pdev)
up->port.uartclk = omap_up_info->uartclk;
if (!up->port.uartclk) {
up->port.uartclk = DEFAULT_CLK_SPEED;
- dev_warn(&pdev->dev, "No clock speed specified: using default:"
- "%d\n", DEFAULT_CLK_SPEED);
+ dev_warn(&pdev->dev,
+ "No clock speed specified: using default: %d\n" <--- Comma missing here!
+ DEFAULT_CLK_SPEED);
}

- Sedat -

Re: linux-next: build failure after merge of the tty tree

[Philippe Proulx]

----- Original Message -----
> From: "Sedat Dilek" <sedat.dilek@gmail.com>
> To: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Philippe Proulx" <philippe.proulx@savoirfairelinux.com>
> Cc: "Greg KH" <greg@kroah.com>, "linux-next" <linux-next@vger.kernel.org>, "LKML" <linux-kernel@vger.kernel.org>,
> linux-serial@vger.kernel.org
> Sent: Thursday, 31 October, 2013 6:35:23 AM
> Subject: Re: linux-next: build failure after merge of the tty tree
> 
> On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > Hi Greg,
> >
> > After merging the tty tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > before numeric constant
> > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > expects a matching 'int' argument [-Wformat]
> >
> > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > warnings").  There is a missing ',' in the dev_warn() ...
> >
> > I have used the version of the tty tree from next-20131030 for
> > today.
> >
> 
> [ Add CC to linux-serial ML ]
> 
> Happy HelloWien and WelcomeBackStephen!
> 
> That was only checkpatch-tested, eh :-)?
> 
> @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> platform_device *pdev)
> up->port.uartclk = omap_up_info->uartclk;
> if (!up->port.uartclk) {
> up->port.uartclk = DEFAULT_CLK_SPEED;
> - dev_warn(&pdev->dev, "No clock speed specified: using default:"
> - "%d\n", DEFAULT_CLK_SPEED);
> + dev_warn(&pdev->dev,
> + "No clock speed specified: using default: %d\n" <--- Comma missing
> here!

Oops, something obviously went wrong in my process. Sorry about this.

Do you want me to fix this commit?

> + DEFAULT_CLK_SPEED);
> }
> 
> - Sedat -
> 

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Oct 31, 2013 at 09:09:51AM -0400, Philippe Proulx wrote:
> ----- Original Message -----
> > From: "Sedat Dilek" <sedat.dilek@gmail.com>
> > To: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Philippe Proulx" <philippe.proulx@savoirfairelinux.com>
> > Cc: "Greg KH" <greg@kroah.com>, "linux-next" <linux-next@vger.kernel.org>, "LKML" <linux-kernel@vger.kernel.org>,
> > linux-serial@vger.kernel.org
> > Sent: Thursday, 31 October, 2013 6:35:23 AM
> > Subject: Re: linux-next: build failure after merge of the tty tree
> > 
> > On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> > <sfr@canb.auug.org.au> wrote:
> > > Hi Greg,
> > >
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > > before numeric constant
> > > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > > expects a matching 'int' argument [-Wformat]
> > >
> > > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > > warnings").  There is a missing ',' in the dev_warn() ...
> > >
> > > I have used the version of the tty tree from next-20131030 for
> > > today.
> > >
> > 
> > [ Add CC to linux-serial ML ]
> > 
> > Happy HelloWien and WelcomeBackStephen!
> > 
> > That was only checkpatch-tested, eh :-)?
> > 
> > @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> > platform_device *pdev)
> > up->port.uartclk = omap_up_info->uartclk;
> > if (!up->port.uartclk) {
> > up->port.uartclk = DEFAULT_CLK_SPEED;
> > - dev_warn(&pdev->dev, "No clock speed specified: using default:"
> > - "%d\n", DEFAULT_CLK_SPEED);
> > + dev_warn(&pdev->dev,
> > + "No clock speed specified: using default: %d\n" <--- Comma missing
> > here!
> 
> Oops, something obviously went wrong in my process. Sorry about this.
> 
> Do you want me to fix this commit?

Please send me a patch that I can apply.

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/tty/n_tty.c: In function 'n_tty_close':
drivers/tty/n_tty.c:1757:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(ldata);
  ^
drivers/tty/n_tty.c: In function 'n_tty_open':
drivers/tty/n_tty.c:1776:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
  ldata = vmalloc(sizeof(*ldata));
  ^
drivers/tty/n_tty.c:1776:8: warning: assignment makes pointer from integer without a cast [enabled by default]
  ldata = vmalloc(sizeof(*ldata));
        ^

Caused by commit 20bafb3d23d1 ("n_tty: Move buffers into n_tty_data").
Forgot to include linux/vmalloc.h?

I have used the tty tree from next-20130723 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Peter Hurley]

On 07/24/2013 12:42 AM, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:

Sorry. Patch coming.

Regards,
Peter Hurley

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3107 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/usb/misc/sisusbvga/sisusb_con.c: In function 'sisusb_console_init':
drivers/usb/misc/sisusbvga/sisusb_con.c:1493:2: error: implicit declaration of function 'take_over_console' [-Werror=implicit-function-declaration]
  ret = take_over_console(&sisusb_con, first - 1, last - 1, 0);
  ^
cc1: some warnings being treated as errors

Caused by commit dc9641895abb ("vt: delete unneeded functions
register_con_driver|take_over_console").  Grep is your friend!  There is
more to clean up here:

Documentation/console/console.txt:call take_over_console() will succeed in the takeover regardless of the type
Documentation/console/console.txt:	 take_over_console() - load and bind driver to console layer
Documentation/console/console.txt:take_over_console() is now broken up into:
Documentation/console/console.txt:   or take_over_console(). register_con_driver() will just add the driver to
Documentation/console/console.txt:   console. take_over_console(), as it name implies, will also take over (or
arch/alpha/kernel/console.c:	take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
arch/alpha/kernel/process.c:		take_over_console(&dummy_con, 0, MAX_NR_CONSOLES-1, 1);
arch/mips/pci/pci-bcm1480.c:	take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
arch/mips/pci/pci-sb1250.c:	take_over_console(&vga_con, 0, MAX_NR_CONSOLES - 1, 1);
arch/parisc/kernel/setup.c:	conswitchp = &dummy_con;	/* we use take_over_console() later ! */
drivers/tty/vt/vt.c: *	take_over_console is basically a register followed by unbind
drivers/usb/misc/sisusbvga/sisusb_con.c:	/* This is called by take_over_console(),
drivers/usb/misc/sisusbvga/sisusb_con.c:	/* This is called by take_over_console()
drivers/usb/misc/sisusbvga/sisusb_con.c:	ret = take_over_console(&sisusb_con, first - 1, last - 1, 0);
drivers/usb/misc/sisusbvga/sisusb_con.c:				take_over_console(&sisusb_dummy_con, i, i, 0);
drivers/usb/misc/sisusbvga/sisusb_con.c:				 * consoles is executed by take_over_console().
drivers/video/console/fbcon.c:/* NOTE: fbcon cannot be __init: it may be called from take_over_console later */
drivers/video/console/mdacon.c:	return take_over_console(&mda_con, mda_first_vc-1, mda_last_vc-1, 0);
drivers/video/console/newport_con.c:/* Can't be __init, take_over_console may call it later */
drivers/video/console/newport_con.c:	return take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1);
drivers/video/console/sticon.c:	return take_over_console(&sti_con, 0, MAX_NR_CONSOLES - 1, 1);

Documentation/console/console.txt:	 register_con_driver()
Documentation/console/console.txt:     register_con_driver()
Documentation/console/console.txt:1. All drivers, except system drivers, must call either register_con_driver()
Documentation/console/console.txt:   or take_over_console(). register_con_driver() will just add the driver to

I have used the version of the tty tree from next-20130520 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2532 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'

Caused by commits 53c5ee2cfb4d ("TTY: move ldisc data from tty_struct:
simple members") and ba2e68ac6157 ("TTY: move ldisc data from tty_struct:
read_* and echo_* and canon_* stuff") interacting with commit
0b52b7497271 ("staging: Add dgrp driver for Digi Realport devices") now
in Linus' tree.

I disabled building of the dgrp driver for now using this merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 24 Oct 2012 13:25:29 +1100
Subject: [PATCH] staging: disable dgrp driver since it is broken by tty
 changes

drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/dgrp/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/dgrp/Kconfig b/drivers/staging/dgrp/Kconfig
index 39f4bb6..7d378c2 100644
--- a/drivers/staging/dgrp/Kconfig
+++ b/drivers/staging/dgrp/Kconfig
@@ -2,6 +2,7 @@ config DGRP
        tristate "Digi Realport driver"
        default n
        depends on SYSFS
+	depends on BROKEN
        ---help---
        Support for Digi Realport devices.  These devices allow you to
        access remote serial ports as if they are local tty devices.  This
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Oct 24, 2012 at 01:28:27PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
> 
> Caused by commits 53c5ee2cfb4d ("TTY: move ldisc data from tty_struct:
> simple members") and ba2e68ac6157 ("TTY: move ldisc data from tty_struct:
> read_* and echo_* and canon_* stuff") interacting with commit
> 0b52b7497271 ("staging: Add dgrp driver for Digi Realport devices") now
> in Linus' tree.
> 
> I disabled building of the dgrp driver for now using this merge fix patch:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 24 Oct 2012 13:25:29 +1100
> Subject: [PATCH] staging: disable dgrp driver since it is broken by tty
>  changes
> 
> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/dgrp/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/dgrp/Kconfig b/drivers/staging/dgrp/Kconfig
> index 39f4bb6..7d378c2 100644
> --- a/drivers/staging/dgrp/Kconfig
> +++ b/drivers/staging/dgrp/Kconfig
> @@ -2,6 +2,7 @@ config DGRP
>         tristate "Digi Realport driver"
>         default n
>         depends on SYSFS
> +	depends on BROKEN

Thanks, that makes sense for now, hopefully Jiri will return from his
conference and fix this driver up.

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

In file included from drivers/tty/serial/sccnxp.c:20:0:
include/linux/serial_core.h: In function 'uart_handle_break':
include/linux/serial_core.h:543:30: error: dereferencing pointer to incomplete type

Caused by commit 1d65c0b12656 ("serial: New serial driver SCCNXP").  This
seems to be just exposing a preexisting problem with linux/serial_core.h:
when SUPPORT_SYSRQ is defined, this header depends on linux/console.h.  I
can only imagein that every other use of serial_core.h pre-includes
(maybe indirectly) console.h (or doesn't define SUPPORT_SYSRQ).

I have applied the following patch, but a better solution should be
figured out.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 6 Sep 2012 15:05:04 +1000
Subject: [PATCH] serial: serial_core.h needs console.h included first

Fixes these build errors:

In file included from drivers/tty/serial/sccnxp.c:20:0:
include/linux/serial_core.h: In function 'uart_handle_break':
include/linux/serial_core.h:543:30: error: dereferencing pointer to incomplete type

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/tty/serial/sccnxp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c
index 29dda9b..05d767c 100644
--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
@@ -17,12 +17,12 @@
 
 #include <linux/module.h>
 #include <linux/device.h>
+#include <linux/console.h>
 #include <linux/serial_core.h>
 #include <linux/serial.h>
 #include <linux/io.h>
 #include <linux/tty.h>
 #include <linux/tty_flip.h>
-#include <linux/console.h>
 #include <linux/platform_device.h>
 #include <linux/platform_data/sccnxp.h>
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 6 Sep 2012 15:10:14 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/tty/serial/sccnxp.c:20:0:
> include/linux/serial_core.h: In function 'uart_handle_break':
> include/linux/serial_core.h:543:30: error: dereferencing pointer to
> incomplete type
> 
> Caused by commit 1d65c0b12656 ("serial: New serial driver SCCNXP").
> This seems to be just exposing a preexisting problem with
> linux/serial_core.h: when SUPPORT_SYSRQ is defined, this header
> depends on linux/console.h.  I can only imagein that every other use
> of serial_core.h pre-includes (maybe indirectly) console.h (or
> doesn't define SUPPORT_SYSRQ).
> 
> I have applied the following patch, but a better solution should be
> figured out.


I think thats actually probably the right patch. Better to keep the
header explicit than try and build some tangled mess of recursive
includes.

Acked-by: Alan Cox <alan@linux.intel.com>

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/staging/serqt_usb2/serqt_usb2.c: In function 'qt_set_termios':
drivers/staging/serqt_usb2/serqt_usb2.c:1198:29: error: incompatible types when initializing type 'struct ktermios *' using type 'struct ktermios'
drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid type argument of '->' (have 'struct ktermios')

Presumably caused by commit adc8d746caa6 ("tty: move the termios object
into the tty").

Under previous instructions about staging drivers, I have added the
following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 Jul 2012 13:31:39 +1000
Subject: [PATCH] disable USB_SERIAL_QUATECH2 broken by tty update

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/serqt_usb2/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/serqt_usb2/Kconfig b/drivers/staging/serqt_usb2/Kconfig
index f4fed40..dc624a4 100644
--- a/drivers/staging/serqt_usb2/Kconfig
+++ b/drivers/staging/serqt_usb2/Kconfig
@@ -1,6 +1,7 @@
 config USB_SERIAL_QUATECH2
 	tristate "USB Quatech ESU-100 8 Port Serial Driver"
 	depends on USB_SERIAL
+	depends on BROKEN
 	help
 	  Say Y here if you want to use the Quatech ESU-100 8 port usb to
 	  serial adapter.
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

Hi Greg, Alan,

[Sorry, Alan, I forgot to cc you the first time around.]

On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/serqt_usb2/serqt_usb2.c: In function 'qt_set_termios':
> drivers/staging/serqt_usb2/serqt_usb2.c:1198:29: error: incompatible types when initializing type 'struct ktermios *' using type 'struct ktermios'
> drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid type argument of '->' (have 'struct ktermios')
> 
> Presumably caused by commit adc8d746caa6 ("tty: move the termios object
> into the tty").
> 
> Under previous instructions about staging drivers, I have added the
> following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 20 Jul 2012 13:31:39 +1000
> Subject: [PATCH] disable USB_SERIAL_QUATECH2 broken by tty update
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/serqt_usb2/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/serqt_usb2/Kconfig b/drivers/staging/serqt_usb2/Kconfig
> index f4fed40..dc624a4 100644
> --- a/drivers/staging/serqt_usb2/Kconfig
> +++ b/drivers/staging/serqt_usb2/Kconfig
> @@ -1,6 +1,7 @@
>  config USB_SERIAL_QUATECH2
>  	tristate "USB Quatech ESU-100 8 Port Serial Driver"
>  	depends on USB_SERIAL
> +	depends on BROKEN
>  	help
>  	  Say Y here if you want to use the Quatech ESU-100 8 port usb to
>  	  serial adapter.
> -- 
> 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 26 Jul 2012 08:51:27 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Greg, Alan,
> 
> [Sorry, Alan, I forgot to cc you the first time around.]
> 
> On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> >
> > After merging the tty tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/staging/serqt_usb2/serqt_usb2.c: In function
> > 'qt_set_termios': drivers/staging/serqt_usb2/serqt_usb2.c:1198:29:
> > error: incompatible types when initializing type 'struct ktermios
> > *' using type 'struct ktermios'
> > drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid
> > type argument of '->' (have 'struct ktermios')
> > 

I sent you a fix for that one (I've not done the ipoctal one yet)

Alan

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument of '->' (have 'struct ktermios')
drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument of '->' (have 'struct ktermios')
drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument of '->' (have 'struct ktermios')
drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument of '->' (have 'struct ktermios')
drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'

Presumably caused by commit adc8d746caa6 ("tty: move the termios object
into the tty").

Under previous instructions about staging drivers, I have added the
following patch for today:

From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 Jul 2012 13:25:12 +1000
Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/staging/ipack/devices/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/ipack/devices/Kconfig b/drivers/staging/ipack/devices/Kconfig
index 39f7188..8d69ce3 100644
--- a/drivers/staging/ipack/devices/Kconfig
+++ b/drivers/staging/ipack/devices/Kconfig
@@ -1,6 +1,7 @@
 config SERIAL_IPOCTAL
 	tristate "IndustryPack IP-OCTAL uart support"
 	depends on IPACK_BUS
+	depends on BROKEN
 	help
 	  This driver supports the IPOCTAL serial port device for the IndustryPack bus.
 	default n
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Jul 20, 2012 at 01:28:40PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
> drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Presumably caused by commit adc8d746caa6 ("tty: move the termios object
> into the tty").
> 
> Under previous instructions about staging drivers, I have added the
> following patch for today:
> 
> From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 20 Jul 2012 13:25:12 +1000
> Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/ipack/devices/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipack/devices/Kconfig b/drivers/staging/ipack/devices/Kconfig
> index 39f7188..8d69ce3 100644
> --- a/drivers/staging/ipack/devices/Kconfig
> +++ b/drivers/staging/ipack/devices/Kconfig
> @@ -1,6 +1,7 @@
>  config SERIAL_IPOCTAL
>  	tristate "IndustryPack IP-OCTAL uart support"
>  	depends on IPACK_BUS
> +	depends on BROKEN
>  	help
>  	  This driver supports the IPOCTAL serial port device for the IndustryPack bus.
>  	default n

Alan, care to send me a patch for this?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]

Hi Greg, Alan,

On Fri, 20 Jul 2012 13:28:40 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
> drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument is of type 'struct ktermios'
> 
> Presumably caused by commit adc8d746caa6 ("tty: move the termios object
> into the tty").
> 
> Under previous instructions about staging drivers, I have added the
> following patch for today:
> 
> From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 20 Jul 2012 13:25:12 +1000
> Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/staging/ipack/devices/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipack/devices/Kconfig b/drivers/staging/ipack/devices/Kconfig
> index 39f7188..8d69ce3 100644
> --- a/drivers/staging/ipack/devices/Kconfig
> +++ b/drivers/staging/ipack/devices/Kconfig
> @@ -1,6 +1,7 @@
>  config SERIAL_IPOCTAL
>  	tristate "IndustryPack IP-OCTAL uart support"
>  	depends on IPACK_BUS
> +	depends on BROKEN
>  	help
>  	  This driver supports the IPOCTAL serial port device for the IndustryPack bus.
>  	default n
> -- 
> 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/char/pcmcia/synclink_cs.c: In function 'shutdown':
drivers/char/pcmcia/synclink_cs.c:1347:27: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c: In function 'mgslpc_program_hw':
drivers/char/pcmcia/synclink_cs.c:1388:45: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c: In function 'mgslpc_change_params':
drivers/char/pcmcia/synclink_cs.c:1401:14: error: wrong type argument to unary exclamation mark
drivers/char/pcmcia/synclink_cs.c:1408:22: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c: In function 'mgslpc_throttle':
drivers/char/pcmcia/synclink_cs.c:1731:19: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c: In function 'mgslpc_unthrottle':
drivers/char/pcmcia/synclink_cs.c:1760:19: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c: In function 'mgslpc_set_termios':
drivers/char/pcmcia/synclink_cs.c:2296:19: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c:2297:10: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c:2305:20: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c:2314:18: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c:2316:22: error: invalid type argument of '->' (have 'struct ktermios')
drivers/char/pcmcia/synclink_cs.c:2327:20: error: invalid type argument of '->' (have 'struct ktermios')

Caused by commit adc8d746caa6 ("tty: move the termios object into the
tty").  Grep and build testing are your friends ...

I have used the tty tree from next-20120712 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty").  Grep and build testing are your friends ...
> 
> I have used the tty tree from next-20120712 again for today.

Doh, patch sent

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/tty/tty_ioctl.c: In function 'set_sgflags':
drivers/tty/tty_ioctl.c:741:9: error: request for member 'c_iflag' in something not a structure or union
drivers/tty/tty_ioctl.c:742:9: error: request for member 'c_oflag' in something not a structure or union
drivers/tty/tty_ioctl.c:743:9: error: request for member 'c_lflag' in something not a structure or union
drivers/tty/tty_ioctl.c:745:10: error: request for member 'c_iflag' in something not a structure or union
drivers/tty/tty_ioctl.c:746:10: error: request for member 'c_lflag' in something not a structure or union
drivers/tty/tty_ioctl.c:749:10: error: request for member 'c_lflag' in something not a structure or union
drivers/tty/tty_ioctl.c:753:10: error: request for member 'c_oflag' in something not a structure or union
drivers/tty/tty_ioctl.c:756:10: error: request for member 'c_iflag' in something not a structure or union
drivers/tty/tty_ioctl.c:757:10: error: request for member 'c_lflag' in something not a structure or union
drivers/tty/tty_ioctl.c:759:15: error: request for member 'c_lflag' in something not a structure or union
drivers/tty/tty_ioctl.c:760:10: error: request for member 'c_cc' in something not a structure or union
drivers/tty/tty_ioctl.c:761:10: error: request for member 'c_cc' in something not a structure or union

Caused by commit adc8d746caa6 ("tty: move the termios object into the
tty").  Did anyone build test this?  :-(

I have used the tty tree from next-20120712 again for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Tue, 17 Jul 2012 13:45:06 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/tty/tty_ioctl.c: In function 'set_sgflags':
> drivers/tty/tty_ioctl.c:741:9: error: request for member 'c_iflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:742:9: error: request for member 'c_oflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:743:9: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:745:10: error: request for member 'c_iflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:746:10: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:749:10: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:753:10: error: request for member 'c_oflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:756:10: error: request for member 'c_iflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:757:10: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:759:15: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:760:10: error: request for member 'c_cc' in something not a structure or union
> drivers/tty/tty_ioctl.c:761:10: error: request for member 'c_cc' in something not a structure or union
> 
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty").  Did anyone build test this?  :-(

It's known not to build. I sent Greg some patches but he wants them
versus a different tree. I hope to have that done and tested in the next
couple of days, until then I'd suggest you drop the tty tree - in
particular because the version you are currently using scribbles on other
bits of of memory.

Alan

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Jul 17, 2012 at 11:10:53AM +0100, Alan Cox wrote:
> On Tue, 17 Jul 2012 13:45:06 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi Greg,
> > 
> > After merging the tty tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/tty/tty_ioctl.c: In function 'set_sgflags':
> > drivers/tty/tty_ioctl.c:741:9: error: request for member 'c_iflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:742:9: error: request for member 'c_oflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:743:9: error: request for member 'c_lflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:745:10: error: request for member 'c_iflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:746:10: error: request for member 'c_lflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:749:10: error: request for member 'c_lflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:753:10: error: request for member 'c_oflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:756:10: error: request for member 'c_iflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:757:10: error: request for member 'c_lflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:759:15: error: request for member 'c_lflag' in something not a structure or union
> > drivers/tty/tty_ioctl.c:760:10: error: request for member 'c_cc' in something not a structure or union
> > drivers/tty/tty_ioctl.c:761:10: error: request for member 'c_cc' in something not a structure or union
> > 
> > Caused by commit adc8d746caa6 ("tty: move the termios object into the
> > tty").  Did anyone build test this?  :-(
> 
> It's known not to build. I sent Greg some patches but he wants them
> versus a different tree.

"different tree" == my tree, so I can apply them :)

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Jul 17, 2012 at 01:45:06PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/tty/tty_ioctl.c: In function 'set_sgflags':
> drivers/tty/tty_ioctl.c:741:9: error: request for member 'c_iflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:742:9: error: request for member 'c_oflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:743:9: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:745:10: error: request for member 'c_iflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:746:10: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:749:10: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:753:10: error: request for member 'c_oflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:756:10: error: request for member 'c_iflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:757:10: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:759:15: error: request for member 'c_lflag' in something not a structure or union
> drivers/tty/tty_ioctl.c:760:10: error: request for member 'c_cc' in something not a structure or union
> drivers/tty/tty_ioctl.c:761:10: error: request for member 'c_cc' in something not a structure or union
> 
> Caused by commit adc8d746caa6 ("tty: move the termios object into the
> tty").  Did anyone build test this?  :-(

It builds here for me just fine, this is odd.

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Tue, 17 Jul 2012 08:45:29 -0700
Greg KH <greg@kroah.com> wrote:

> On Tue, Jul 17, 2012 at 01:45:06PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the tty tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/tty/tty_ioctl.c: In function 'set_sgflags':
> > drivers/tty/tty_ioctl.c:741:9: error: request for member 'c_iflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:742:9: error: request for member 'c_oflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:743:9: error: request for member 'c_lflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:745:10: error: request for member 'c_iflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:746:10: error: request for member 'c_lflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:749:10: error: request for member 'c_lflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:753:10: error: request for member 'c_oflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:756:10: error: request for member 'c_iflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:757:10: error: request for member 'c_lflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:759:15: error: request for member 'c_lflag'
> > in something not a structure or union
> > drivers/tty/tty_ioctl.c:760:10: error: request for member 'c_cc' in
> > something not a structure or union drivers/tty/tty_ioctl.c:761:10:
> > error: request for member 'c_cc' in something not a structure or
> > union
> > 
> > Caused by commit adc8d746caa6 ("tty: move the termios object into
> > the tty").  Did anyone build test this?  :-(
> 
> It builds here for me just fine, this is odd.

Had me confused for a bit but while I couldn't find a config to test it
I could find the bug 8)

Alan

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/char/mwave/mwavedd.c: In function 'register_serial_portandirq':
drivers/char/mwave/mwavedd.c:472:2: error: implicit declaration of function 'serial8250_register_port' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
drivers/misc/ibmasm/uart.c: In function 'ibmasm_register_uart':
drivers/misc/ibmasm/uart.c:57:2: error: implicit declaration of function 'serial8250_register_port' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Caused by commit 2655a2c76f80 ("8250: use the 8250 register interface not
the legacy one").  Grep is your friend.

I have used the tty tree from next-20120712 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Fri, 13 Jul 2012 14:13:45 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/char/mwave/mwavedd.c: In function 'register_serial_portandirq':
> drivers/char/mwave/mwavedd.c:472:2: error: implicit declaration of function 'serial8250_register_port' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> drivers/misc/ibmasm/uart.c: In function 'ibmasm_register_uart':
> drivers/misc/ibmasm/uart.c:57:2: error: implicit declaration of function 'serial8250_register_port' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> 
> Caused by commit 2655a2c76f80 ("8250: use the 8250 register interface not
> the legacy one").  Grep is your friend.

My fault on that one not GregKH's. I'll wrap that into the updated patch
series. I thought I had them all but I forgot to grep off in drivers/misc.

Alan

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Alan, David,

On Fri, Jul 13, 2012 at 1:10 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Fri, 13 Jul 2012 14:13:45 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> drivers/char/mwave/mwavedd.c: In function 'register_serial_portandirq':
>> drivers/char/mwave/mwavedd.c:472:2: error: implicit declaration of function 'serial8250_register_port' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>> drivers/misc/ibmasm/uart.c: In function 'ibmasm_register_uart':
>> drivers/misc/ibmasm/uart.c:57:2: error: implicit declaration of function 'serial8250_register_port' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>>
>> Caused by commit 2655a2c76f80 ("8250: use the 8250 register interface not
>> the legacy one").  Grep is your friend.
>
> My fault on that one not GregKH's. I'll wrap that into the updated patch
> series. I thought I had them all but I forgot to grep off in drivers/misc.

Today's build failed because there's a new user in the MIPS tree:
arch/mips/cavium-octeon/serial.c

http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

> Today's build failed because there's a new user in the MIPS tree:
> arch/mips/cavium-octeon/serial.c
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/

The version in the tree I have registers a platform device rather than
calling into 8250 directly. That appears to be rather better mannered
than whatever you are building.

If someone has moved from the platform device could they kindly explain
*why* ?

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Alan,

On Fri, Jul 20, 2012 at 10:55 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>> Today's build failed because there's a new user in the MIPS tree:
>> arch/mips/cavium-octeon/serial.c
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/
>
> The version in the tree I have registers a platform device rather than
> calling into 8250 directly. That appears to be rather better mannered
> than whatever you are building.
>
> If someone has moved from the platform device could they kindly explain
> *why* ?

commit 7c507e6fe36d8e8f67a06d1f81ddde4d8ecf739f ("MIPS: Octeon: Use
device tree to register serial ports.") in linux-next.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: "isdn_tty_revision" [drivers/isdn/i4l/isdn.ko] undefined!

Presumably caused by commit 1ca6711ec001 ("ISDN: i4l, remove cvs crap").
That variable is still referenced in drivers/isdn/i4l/isdn_common.c.  Grep
is your friend.

I have used the tty tree from next-20120405 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `dw8250_handle_irq':
8250_dw.c:(.text+0xcad9c): undefined reference to `serial8250_handle_irq'

CONFIG_SERIAL_8250 is 'm' and CONFIG_SERIAL_8250_DW is 'y' ...

Caused by commit 6b1a98d1c485 ("tty: serial8250: add helpers for the
DesignWare 8250").

I have used the ttye tree form next-20110823 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Aug 24, 2011 at 02:33:54PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/built-in.o: In function `dw8250_handle_irq':
> 8250_dw.c:(.text+0xcad9c): undefined reference to `serial8250_handle_irq'
> 
> CONFIG_SERIAL_8250 is 'm' and CONFIG_SERIAL_8250_DW is 'y' ...
> 
> Caused by commit 6b1a98d1c485 ("tty: serial8250: add helpers for the
> DesignWare 8250").
> 
> I have used the ttye tree form next-20110823 for today.

Ick.

Jamie, can you please send me a patch that fixes this up?

thanks,

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

scripts/Makefile.modbuiltin:25: drivers/char/pcmcia/ipwireless/Makefile: No such file or directory
make[5]: *** No rule to make target `drivers/char/pcmcia/ipwireless/Makefile'.  Stop.

Caused by commit 282361a046edd9d58a134f358a3f65a7cb8655d9 ("tty: move
ipwireless driver from drivers/char/pcmcia/ to drivers/tty/") which
neglected to remove mention of ipwireless from
drivers/char/pcmcia/Makefile.

I have used the tty tree from next-20110223 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Feb 24, 2011 at 04:40:48PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> scripts/Makefile.modbuiltin:25: drivers/char/pcmcia/ipwireless/Makefile: No such file or directory
> make[5]: *** No rule to make target `drivers/char/pcmcia/ipwireless/Makefile'.  Stop.
> 
> Caused by commit 282361a046edd9d58a134f358a3f65a7cb8655d9 ("tty: move
> ipwireless driver from drivers/char/pcmcia/ to drivers/tty/") which
> neglected to remove mention of ipwireless from
> drivers/char/pcmcia/Makefile.
> 
> I have used the tty tree from next-20110223 for today.

Now fixed, thanks.

greg k-h

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function)

Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount
changeover for other main devices").

Please build test (especially the trivial "cut and paste" changes) ...

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Sep 23, 2010 at 02:20:18PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function)
> 
> Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount
> changeover for other main devices").
> 
> Please build test (especially the trivial "cut and paste" changes) ...
> 
> I have reverted that commit for today.

Ick, sorry about that.  Alan, care to send a fixup patch for this?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Randy Dunlap]

On Thu, 23 Sep 2010 07:14:33 -0700 Greg KH wrote:

> On Thu, Sep 23, 2010 at 02:20:18PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the tty tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function)
> > 
> > Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount
> > changeover for other main devices").
> > 
> > Please build test (especially the trivial "cut and paste" changes) ...
> > 
> > I have reverted that commit for today.
> 
> Ick, sorry about that.  Alan, care to send a fixup patch for this?


So developers and maintainers are not doing allmodconfig builds?
I can understand not doing randconfig builds.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 23 Sep 2010 08:13:50 -0700
Randy Dunlap <rdunlap@xenotime.net> wrote:

> On Thu, 23 Sep 2010 07:14:33 -0700 Greg KH wrote:
> 
> > On Thu, Sep 23, 2010 at 02:20:18PM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > After merging the tty tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function)
> > > 
> > > Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount
> > > changeover for other main devices").
> > > 
> > > Please build test (especially the trivial "cut and paste" changes) ...
> > > 
> > > I have reverted that commit for today.
> > 
> > Ick, sorry about that.  Alan, care to send a fixup patch for this?
> 
> 
> So developers and maintainers are not doing allmodconfig builds?

I try to make sure I build all the drivers I touch - I screwed that one
up. Lots of -next trees build for allmodconfig and not other configs so
all doing the same build isn't neccessarily good.

Alan

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 23 Sep 2010 08:13:50 -0700
Randy Dunlap <rdunlap@xenotime.net> wrote:

> On Thu, 23 Sep 2010 07:14:33 -0700 Greg KH wrote:
> 
> > On Thu, Sep 23, 2010 at 02:20:18PM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > After merging the tty tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function)
> > > 
> > > Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount
> > > changeover for other main devices").
> > > 
> > > Please build test (especially the trivial "cut and paste" changes) ...
> > > 
> > > I have reverted that commit for today.
> > 
> > Ick, sorry about that.  Alan, care to send a fixup patch for this?
> 
> 
> So developers and maintainers are not doing allmodconfig builds?
> I can understand not doing randconfig builds.

drivers/staging/ti-st/st_kim.c:34:20: error: st_kim.h: No such file or
directory

So there isn't actually much point trying allmodconfig builds (thats not
the only fail either).

Re: linux-next: build failure after merge of the tty tree

[Randy Dunlap]

On Thu, 23 Sep 2010 18:12:12 +0100 Alan Cox wrote:

> On Thu, 23 Sep 2010 08:13:50 -0700
> Randy Dunlap <rdunlap@xenotime.net> wrote:
> 
> > On Thu, 23 Sep 2010 07:14:33 -0700 Greg KH wrote:
> > 
> > > On Thu, Sep 23, 2010 at 02:20:18PM +1000, Stephen Rothwell wrote:
> > > > Hi Greg,
> > > > 
> > > > After merging the tty tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > > 
> > > > drivers/char/ip2/ip2main.c:459: error: 'ip2_get_icount' undeclared here (not in a function)
> > > > 
> > > > Caused by commit 157be28e51ed476aa357c8718aaef4832f4da66b ("tty: icount
> > > > changeover for other main devices").
> > > > 
> > > > Please build test (especially the trivial "cut and paste" changes) ...
> > > > 
> > > > I have reverted that commit for today.
> > > 
> > > Ick, sorry about that.  Alan, care to send a fixup patch for this?
> > 
> > 
> > So developers and maintainers are not doing allmodconfig builds?
> > I can understand not doing randconfig builds.
> 
> drivers/staging/ti-st/st_kim.c:34:20: error: st_kim.h: No such file or
> directory
> 
> So there isn't actually much point trying allmodconfig builds (thats not
> the only fail either).

True.  But linux-next is mostly to test the merger of lots of trees.


BTW, all{mod,yes}config sets CONFIG_STAGING=y and CONFIG_STAGING_EXCLUDE_BUILD=y,
so the above shouldn't show up in an all*config build.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/serial/mfd.c:37:30: error: linux/serial_mfd.h: No such file or directory
drivers/serial/mfd.c: In function 'port_show_regs':
drivers/serial/mfd.c:166: error: 'UART_FOR' undeclared (first use in this function)

... and on ... and on ...

Caused by commit c3190cf68dfc58c33de0fd59b919cbb864acbba4 ("hsu: driver
for Medfield High Speed UART device") and following.   Did it miss a file?

A little more care and testing, please.

I reverted that commit and the following three that depend on it.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Tue, 27 Jul 2010 15:18:43 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/serial/mfd.c:37:30: error: linux/serial_mfd.h: No such file or directory
> drivers/serial/mfd.c: In function 'port_show_regs':
> drivers/serial/mfd.c:166: error: 'UART_FOR' undeclared (first use in this function)
> 
> ... and on ... and on ...
> 
> Caused by commit c3190cf68dfc58c33de0fd59b919cbb864acbba4 ("hsu: driver
> for Medfield High Speed UART device") and following.   Did it miss a file?
> 
> A little more care and testing, please.

Yes although I had a local copy so it built and tested beautifully 8(

Will send Greg and updated set of those patches versus todays -next

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Jul 27, 2010 at 08:43:53AM +0100, Alan Cox wrote:
> On Tue, 27 Jul 2010 15:18:43 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Hi Greg,
> > 
> > After merging the tty tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/serial/mfd.c:37:30: error: linux/serial_mfd.h: No such file or directory
> > drivers/serial/mfd.c: In function 'port_show_regs':
> > drivers/serial/mfd.c:166: error: 'UART_FOR' undeclared (first use in this function)
> > 
> > ... and on ... and on ...
> > 
> > Caused by commit c3190cf68dfc58c33de0fd59b919cbb864acbba4 ("hsu: driver
> > for Medfield High Speed UART device") and following.   Did it miss a file?
> > 
> > A little more care and testing, please.
> 
> Yes although I had a local copy so it built and tested beautifully 8(
> 
> Will send Greg and updated set of those patches versus todays -next

Now fixed up, sorry for missing this.

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Hi Greg, Alan,

On Tue, 27 Jul 2010 09:47:17 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Tue, Jul 27, 2010 at 08:43:53AM +0100, Alan Cox wrote:
> > 
> > Will send Greg and updated set of those patches versus todays -next
> 
> Now fixed up, sorry for missing this.

Thanks guys.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]