archive mirror
 help / color / mirror / Atom feed
From: David Miller <>
Subject: Re: [PATCH -next] GRE: Use strlcat() for size checking
Date: Wed, 27 Mar 2013 16:10:15 -0400 (EDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Ben Hutchings <>
Date: Wed, 27 Mar 2013 20:06:16 +0000

> On Wed, 2013-03-27 at 19:48 +0100, Geert Uytterhoeven wrote:
>> On m68k, gcc tries to be smart and turns
>>     strncat(name, "%d", 2);
>> into a call to strlen() and a 16-bit store, causing a link failure,
>> as arch/m68k/include/asm/string.h provides strlen() using a macro:
>>     ERROR: "strlen" [net/ipv4/ip_tunnel.ko] undefined!
> Perhaps you should fix the string library for m68k, then!

Right, this symbol really must be provided.

You cannot merely provide inlines.

The off-by-one error is seperate, but that should be fixed

      reply	other threads:[~2013-03-27 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 18:48 [PATCH -next] GRE: Use strlcat() for size checking Geert Uytterhoeven
2013-03-27 20:06 ` Ben Hutchings
2013-03-27 20:10   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).