From: Kent Overstreet <koverstreet@google.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>
Date: Wed, 27 Mar 2013 12:50:50 -0700 [thread overview]
Message-ID: <20130327195050.GB22232@google.com> (raw)
In-Reply-To: <51533A2E.2000501@infradead.org>
On Wed, Mar 27, 2013 at 11:27:58AM -0700, Randy Dunlap wrote:
> On 03/27/13 11:21, Kent Overstreet wrote:
> > On Wed, Mar 27, 2013 at 06:56:28PM +0100, Geert Uytterhoeven wrote:
> >> m68k/allmodconfig:
> >>
> >> drivers/md/bcache/bset.c: In function ‘bset_search_tree’:
> >> drivers/md/bcache/bset.c:727: error: implicit declaration of function ‘prefetch’
> >>
> >> drivers/md/bcache/btree.c: In function ‘bch_btree_node_get’:
> >> drivers/md/bcache/btree.c:933: error: implicit declaration of function ‘prefetch’
> >
> > Thanks, applied! The other two I already have a patch queued up for.
>
>
> On i386 and x86_64, I also see this build problem:
>
> drivers/md/bcache/bset.c:885:4: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration]
>
>
> Do you also have a patch for it?
Nope - looks like __WARN() doesn't exist if CONFIG_BUG=n, whoops.
Adding this to the queue:
commit 796c213186b850b3e6e8d5fd5799b0fd74721ea3
Author: Kent Overstreet <koverstreet@google.com>
Date: Wed Mar 27 12:47:45 2013 -0700
bcache: Use WARN_ONCE() instead of __WARN()
Signed-off-by: Kent Overstreet <koverstreet@google.com>
diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
index d4f2164..cb4578a 100644
--- a/drivers/md/bcache/bset.c
+++ b/drivers/md/bcache/bset.c
@@ -883,7 +883,7 @@ struct bkey *bch_btree_iter_next(struct btree_iter *iter)
iter->data->k = bkey_next(iter->data->k);
if (iter->data->k > iter->data->end) {
- __WARN();
+ WARN_ONCE(1, "bset was corrupt!\n");
iter->data->k = iter->data->end;
}
next prev parent reply other threads:[~2013-03-27 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 17:56 [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h> Geert Uytterhoeven
2013-03-27 17:56 ` [PATCH -next 2/3] bcache: Add missing ULL suffix for 64-bit constants Geert Uytterhoeven
2013-03-27 17:56 ` [PATCH -next 3/3] bcache: Use %zu to format size_t Geert Uytterhoeven
[not found] ` <1364406990-20541-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2013-03-27 18:21 ` [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h> Kent Overstreet
[not found] ` <20130327182150.GB25906-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2013-03-27 18:27 ` Randy Dunlap
2013-03-27 19:50 ` Kent Overstreet [this message]
2013-04-07 21:15 ` David Rientjes
2013-04-08 21:00 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327195050.GB22232@google.com \
--to=koverstreet@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).