linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, Xiong Zhou <jencce.kernel@gmail.com>
Subject: Re: [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN
Date: Fri, 29 Mar 2013 17:12:29 +0000	[thread overview]
Message-ID: <20130329171229.GD18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1364566347-29941-1-git-send-email-peter@hurleysoftware.com>

[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]

On Fri, Mar 29, 2013 at 10:12:27AM -0400, Peter Hurley wrote:

> The linux-next tree has failed to build for last 7 days with these
> errors:

In some pretty specific and basically unrealistic configurations rather
than anything a human is likely to want to use or the core automatic
ones.

>   MODPOST 2490 modules
>   ERROR: "arizona_rate_text" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
>   ERROR: "arizona_rate_val" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined!
>   WARNING: modpost: Found 5 section mismatch(es).

> Patches submitted by Xiong Zhou <jencce.kernel@gmail.com> to fix this
> have been rejected.

> Until the author(s) resolve the situation, mark the offenders as BROKEN.

I'm not going to apply this, it's clearly not a constructive or helpful
effort to address the issue - it's not engaging with any of the
discussion about how to resolve the issue (there's no mention of the
suggested fix for example).

If you're going to run randconfigs that's great and the testing is
useful but if you're going to send patches as well as reports it would
be really helpful to look at what the code is doing so that the change
makes sense rather than just sending the first thing that springs to
mind.  The smarter the stuff that gets sent is the more likely it is to
either get merged or encourage people to work on the problem.

In this case it seems like Xiong is likely to fix things and it'd be
much better overall to get a fix from Xiong merged (which we seem to be
progressing towards).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-03-29 17:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 14:12 [PATCH -next] sound/soc/codecs: Mark snd-soc-wm2200 and snd-soc-wm-adsp as BROKEN Peter Hurley
2013-03-29 17:12 ` Mark Brown [this message]
2013-03-29 18:45   ` Peter Hurley
2013-03-29 18:50     ` Mark Brown
2013-03-30 12:30       ` Xiong Zhou
2013-03-30 13:52         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130329171229.GD18316@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=jencce.kernel@gmail.com \
    --cc=linux-next@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).