linux-next: build warning after merge of the wireless-next tree

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Hi John,

After merging the wireless-next tree, today's linux-next build (powerpc
allyesconfig) produced these warnings:

In file included from drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:38:0:
drivers/net/wireless/rtlwifi/rtl8188ee/trx.h:553:6: warning: "__LITTLE_ENDIAN" is not defined [-Wundef]
drivers/net/wireless/rtlwifi/rtl8188ee/trx.h:577:5: warning: "__LITTLE_ENDIAN" is not defined [-Wundef]
In file included from drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:37:0:
drivers/net/wireless/rtlwifi/rtl8188ee/trx.h:553:6: warning: "__LITTLE_ENDIAN" is not defined [-Wundef]
drivers/net/wireless/rtlwifi/rtl8188ee/trx.h:577:5: warning: "__LITTLE_ENDIAN" is not defined [-Wundef]
In file included from drivers/net/wireless/rtlwifi/rtl8188ee/sw.c:39:0:
drivers/net/wireless/rtlwifi/rtl8188ee/trx.h:553:6: warning: "__LITTLE_ENDIAN" is not defined [-Wundef]
drivers/net/wireless/rtlwifi/rtl8188ee/trx.h:577:5: warning: "__LITTLE_ENDIAN" is not defined [-Wundef]

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

After merging the wireless-next tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/driver-api/80211/mac80211-advanced:214: /home/sfr/next/next/net/mac80211/sta_info.h:628: ERROR: Unexpected indentation.

Introduced by commit

  fe4a6d2db3ba ("wifi: mac80211: implement support for yet another mesh A-MSDU format")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi all,

After merging the wireless-next tree, today's linux-next build (htmldocs)
produced this warning:

net/mac80211/sta_info.h:722: warning: Function parameter or member 'amsdu_mesh_control' not described in 'sta_info'

Introduced by commit

  6e4c0d0460bd ("wifi: mac80211: add a workaround for receiving non-standard mesh A-MSDU")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi all,

After merging the wireless-next tree, today's linux-next build (htmldocs)
produced this warning:

include/net/cfg80211.h:8958: warning: Excess function parameter 'gfp' description in 'cfg80211_obss_color_collision_notify'

Introduced by commit

  935ef47b16cc ("wifi: cfg80211: get rid of gfp in cfg80211_bss_color_notify")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

After merging the wireless-next tree, today's linux-next build (htmldocs)
produced this warning:

include/net/mac80211.h:1553: warning: Function parameter or member 'eht' not described in 'ieee80211_rx_status'

Introduced by commit

  f66c48af7a11 ("mac80211: support minimal EHT rate reporting on RX")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Hi all,

After merging the wireless-next tree, today's linux-next build (htmldocs)
produced this warning:

include/net/cfg80211.h:5741: warning: Function parameter or member 'u' not described in 'wireless_dev'
include/net/cfg80211.h:5741: warning: Function parameter or member 'links' not described in 'wireless_dev'
include/net/cfg80211.h:5741: warning: Function parameter or member 'valid_links' not described in 'wireless_dev'

Introduced by commit

  7b0a0e3c3a88 ("wifi: cfg80211: do some rework towards MLO link APIs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the wireless-next tree

[Kalle Valo]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> After merging the wireless-next tree, today's linux-next build (htmldocs)
> produced this warning:
>
> include/net/cfg80211.h:1188: warning: bad line: attribute is present
> in beacon data or not.
>
> Introduced by commit
>
>   3d48cb74816d ("nl80211: Parse NL80211_ATTR_HE_BSS_COLOR as a part of
> nl80211_parse_beacon")

Thanks for the report, Johannes fixed it in this commit:

https://git.kernel.org/wireless/wireless-next/c/ee0e2f51e211

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

After merging the wireless-next tree, today's linux-next build (htmldocs)
produced this warning:

include/net/cfg80211.h:1188: warning: bad line:         attribute is present in beacon data or not.

Introduced by commit

  3d48cb74816d ("nl80211: Parse NL80211_ATTR_HE_BSS_COLOR as a part of nl80211_parse_beacon")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the wireless-next tree

[Larry Finger]

On 09/30/2014 03:46 AM, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> WARNING: drivers/staging/rtl8192ee/r8192ee: 'rtl_evm_dbm_jaguar' exported twice. Previous export was in drivers/net/wireless/rtlwifi/rtlwifi.ko
>
> Introduced by commit f3a97e93814a ("rtlwifi: Finish modifying core
> routines for new drivers").
>
> I suspect that there is a staging driver that needs removing/updating?

A new version of the driver for the RTL8192EE has been submitted to the regular 
wireless tree; however, there is a bit of overlap before the staging version can 
be removed as the latter request must go through GregKH. Now that the new driver 
has reached linux-next, I will send the appropriate request to Greg.

Thanks,

Larry

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Hi John,

After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: drivers/staging/rtl8192ee/r8192ee: 'rtl_evm_dbm_jaguar' exported twice. Previous export was in drivers/net/wireless/rtlwifi/rtlwifi.ko

Introduced by commit f3a97e93814a ("rtlwifi: Finish modifying core
routines for new drivers").

I suspect that there is a staging driver that needs removing/updating?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning after merge of the wireless-next tree

[Larry Finger]

On 04/03/2013 09:36 PM, Stephen Rothwell wrote:
> Hi Larry,
>
> On Wed, 03 Apr 2013 20:17:01 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>> On 04/03/2013 08:04 PM, Stephen Rothwell wrote:
>>>
>>> On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>>
>>>> After merging the wireless-next tree, today's linux-next build (x86_64
>>>> allmodconfig) produced this warning:
>>>>
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>>>
>>>> I have no idea what caused that.
>>>
>>> Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
>>> of new driver") - I wonder if the gap between the "-I" and
>>> "drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?
>>>
>>> I am using gcc 4.6.3 if that matters.
>>
>> I use 4.7.2.
>>
>> I'll send a patch with the space removed to see if that helps.
>
> I just tested without the space and it fixes the problem for my Debian
> 4.7.2 compiler.  Removing the space also fixes the problem with finding
> include files (after I removed the "../" bits again).

Stephan,

Ah, that was the real error. Thanks for testing.

John: Please take my patch of this evening entitles "[PATCH] rtlwifi: rtl8188ee: 
Fix linker warnings" and drop the one by Chen, Chien-Chia entitled "[PATCH] 
rtlwifi: rtl8188ee: Fix wrong header path". If we put the ../ into the header 
paths, I'll just have to take them out later. We might as well leave them out.

Larry

Re: linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2291 bytes --]

Hi Larry,

On Wed, 03 Apr 2013 20:17:01 -0500 Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 04/03/2013 08:04 PM, Stephen Rothwell wrote:
> >
> > On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> After merging the wireless-next tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> >>
> >> I have no idea what caused that.
> >
> > Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
> > of new driver") - I wonder if the gap between the "-I" and
> > "drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?
> >
> > I am using gcc 4.6.3 if that matters.
> 
> I use 4.7.2.
> 
> I'll send a patch with the space removed to see if that helps.

I just tested without the space and it fixes the problem for my Debian
4.7.2 compiler.  Removing the space also fixes the problem with finding
include files (after I removed the "../" bits again).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the wireless-next tree

[Larry Finger]

On 04/03/2013 08:04 PM, Stephen Rothwell wrote:
> Hi John,
>
> On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the wireless-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
>>
>> I have no idea what caused that.
>
> Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
> of new driver") - I wonder if the gap between the "-I" and
> "drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?
>
> I am using gcc 4.6.3 if that matters.

I use 4.7.2.

I'll send a patch with the space removed to see if that helps.

Larry

Re: linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]

Hi John,

On Thu, 4 Apr 2013 12:00:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
> 
> I have no idea what caused that.

Though I suspect commit 8b138d4898a0 ("rtlwifi: rtl8188ee: Enable build
of new driver") - I wonder if the gap between the "-I" and
"drivers/net/wireless/rtlwifi" added to ccflags-y is the cause?

I am using gcc 4.6.3 if that matters.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]

Hi John,

After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done
x86_64-linux-gcc: warning: drivers/net/wireless/rtlwifi: linker input file unused because linking not done

I have no idea what caused that.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the wireless-next tree

[Stanislaw Gruszka]

On Tue, Nov 22, 2011 at 02:25:02PM +1100, Stephen Rothwell wrote:
> After merging the wireless-next tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> 
> drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: data definition has no type or storage class [enabled by default]
> drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
> drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: parameter names (without types) in function declaration [enabled by default]
> 
> This indicates that this file needs to include export.h.

I think adding export.h to debug.c should be part of current
wireless-next manual merge (debug.c include old iwl-debugfs.c,
which was modified with export.h). If not, I'm posting patch
with fix in the following email.

Thanks
Stanislaw

linux-next: build warning after merge of the wireless-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Hi John,

After merging the wireless-next tree, today's linux-next build
(x86_64_allmodconfig) produced this warning:

drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: data definition has no type or storage class [enabled by default]
drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int]
drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: parameter names (without types) in function declaration [enabled by default]

This indicates that this file needs to include export.h.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]