From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chanho Min <chanho.min@lge.com>,
"Darrick J. Wong" <djwong@us.ibm.com>,
Bob Pearson <rpearson@systemfabricworks.com>,
Richard Weinberger <richard@nod.at>,
Herbert Xu <herbert@gondor.hengli.com.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org,
Yann Collet <yann.collet.73@gmail.com>,
Kyungsik Lee <kyungsik.lee@lge.com>,
Linux/m68k <linux-m68k@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [PATCH 1/2] lib: Add lz4 compressor module
Date: Mon, 22 Apr 2013 14:29:05 -0700 [thread overview]
Message-ID: <20130422142905.3e4fff72671bb3e245055eee@linux-foundation.org> (raw)
In-Reply-To: <CAMuHMdUv=GR6s=BYXHR7KyaKCUSxmkJO8dzZJMRktu3cUCTbsw@mail.gmail.com>
On Mon, 22 Apr 2013 11:24:21 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Apr 22, 2013 at 11:22 AM, Chanho Min <chanho.min@lge.com> wrote:
> >>> +#define HTYPE const u8*
> >>> +
> >>> +#ifdef __BIG_ENDIAN
> >>> +#define LZ4_NBCOMMONBYTES(val) (__builtin_clz(val) >> 3)
> >>> +#else
> >>> +#define LZ4_NBCOMMONBYTES(val) (__builtin_ctz(val) >> 3)
> >>> +#endif
> >>
> >>It seems at least m68k and sparc don't have the __builtin_clz() functions:
> >>
> >>m68k-allmodconfig (http://kisskb.ellerman.id.au/kisskb/buildresult/8572593/):
> >>
> >>ERROR: "__clzsi2" [lib/lz4/lz4hc_compress.ko] undefined!
> >>ERROR: "__clzsi2" [lib/lz4/lz4_compress.ko] undefined!
> >
> > gcc seems to define __builtin_clz as __clzsi2 in some architecture.
> > But, kernel doesn't link libgcc.a.
> > If kernel should use gcc's built-in function without libgcc.a,
> > do we need to port __clzsi2 to 'arch/*/lib/*'?
>
> That's another option.
Without having seen the patch .... Yes, if we fix it this way then we
also fix it for future callers of __builtin_clz().
next prev parent reply other threads:[~2013-04-22 21:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAOAMb1D8rokZpQpp6mEJw6KXcQq8fJUWBJoC5+ZfkNaE6WvAZA@mail.gmail.com>
2013-04-18 9:50 ` [PATCH 1/2] lib: Add lz4 compressor module Geert Uytterhoeven
[not found] ` <51750159.07d70e0a.5461.ffffec64SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-22 9:24 ` Geert Uytterhoeven
2013-04-22 21:29 ` Andrew Morton [this message]
[not found] ` <5175014e.487a420a.4c58.ffffe0b9SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-25 22:42 ` Andrew Morton
2013-04-26 5:02 ` Chanho Min
2013-04-26 5:51 ` Stephen Rothwell
2013-04-26 19:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422142905.3e4fff72671bb3e245055eee@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chanho.min@lge.com \
--cc=djwong@us.ibm.com \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.hengli.com.au \
--cc=kyungsik.lee@lge.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=richard@nod.at \
--cc=rpearson@systemfabricworks.com \
--cc=sparclinux@vger.kernel.org \
--cc=yann.collet.73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).