linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Chanho Min" <chanho.min@lge.com>,
	"'Geert Uytterhoeven'" <geert@linux-m68k.org>,
	"'Bob Pearson'" <rpearson@systemfabricworks.com>,
	"'Richard Weinberger'" <richard@nod.at>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	"'Yann Collet'" <yann.collet.73@gmail.com>,
	이경식 <kyungsik.lee@lge.com>,
	'Linux/m68k' <linux-m68k@vger.kernel.org>,
	'sparclinux' <sparclinux@vger.kernel.org>,
	'Linux-Next' <linux-next@vger.kernel.org>
Subject: Re: [PATCH 1/2] lib: Add lz4 compressor module
Date: Fri, 26 Apr 2013 12:46:25 -0700	[thread overview]
Message-ID: <20130426124625.60bee0e2bcd255c62528e621@linux-foundation.org> (raw)
In-Reply-To: <20130426155105.337d821415d8bfa845bf23f5@canb.auug.org.au>

On Fri, 26 Apr 2013 15:51:05 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi,
> 
> On Fri, 26 Apr 2013 14:02:01 +0900 "Chanho Min" <chanho.min@lge.com> wrote:
> >
> > 
> > @@ -0,0 +1,23 @@
> > +#include <linux/kernel.h>
> > +
> > +int __attribute__((weak)) __clzsi2(int val)
> 
> We have __weak in <linux/compiler.h>

And lib/clz.c needs a few more includes, for EXPORT_SYMBOL,
BITS_PER_LONG maybe.

Plus a changelog and a signed-off-by, please.


      reply	other threads:[~2013-04-26 19:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOAMb1D8rokZpQpp6mEJw6KXcQq8fJUWBJoC5+ZfkNaE6WvAZA@mail.gmail.com>
2013-04-18  9:50 ` [PATCH 1/2] lib: Add lz4 compressor module Geert Uytterhoeven
     [not found]   ` <51750159.07d70e0a.5461.ffffec64SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-22  9:24     ` Geert Uytterhoeven
2013-04-22 21:29       ` Andrew Morton
     [not found]   ` <5175014e.487a420a.4c58.ffffe0b9SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-25 22:42     ` Andrew Morton
2013-04-26  5:02     ` Chanho Min
2013-04-26  5:51       ` Stephen Rothwell
2013-04-26 19:46         ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426124625.60bee0e2bcd255c62528e621@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=chanho.min@lge.com \
    --cc=geert@linux-m68k.org \
    --cc=kyungsik.lee@lge.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=rpearson@systemfabricworks.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sparclinux@vger.kernel.org \
    --cc=yann.collet.73@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).