From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/2] lib: Add lz4 compressor module Date: Fri, 26 Apr 2013 12:46:25 -0700 Message-ID: <20130426124625.60bee0e2bcd255c62528e621@linux-foundation.org> References: <5175014e.487a420a.4c58.ffffe0b9SMTPIN_ADDED_BROKEN@mx.google.com> <20130426155105.337d821415d8bfa845bf23f5@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130426155105.337d821415d8bfa845bf23f5@canb.auug.org.au> Sender: sparclinux-owner@vger.kernel.org To: Stephen Rothwell Cc: Chanho Min , 'Geert Uytterhoeven' , 'Bob Pearson' , 'Richard Weinberger' , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, 'Yann Collet' , =?UTF-8?Q?=EC=9D=B4=EA=B2=BD=EC=8B=9D?= , 'Linux/m68k' , 'sparclinux' , 'Linux-Next' List-Id: linux-next.vger.kernel.org On Fri, 26 Apr 2013 15:51:05 +1000 Stephen Rothwell wrote: > Hi, > > On Fri, 26 Apr 2013 14:02:01 +0900 "Chanho Min" wrote: > > > > > > @@ -0,0 +1,23 @@ > > +#include > > + > > +int __attribute__((weak)) __clzsi2(int val) > > We have __weak in And lib/clz.c needs a few more includes, for EXPORT_SYMBOL, BITS_PER_LONG maybe. Plus a changelog and a signed-off-by, please.