linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton@enomsg.org>
To: Xiong Zhou <jencce.kernel@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	dwmw2@infradead.org, linux-next@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] power: fix bq27x00_battery kconfig
Date: Fri, 10 May 2013 11:05:27 -0700	[thread overview]
Message-ID: <20130510180527.GA32333@teo> (raw)
In-Reply-To: <alpine.DEB.2.02.1305071013410.9830@M2420>

On Tue, May 07, 2013 at 10:15:56AM +0800, Xiong Zhou wrote:
> From: Xiong Zhou <jencce.kernel@gmail.com>
> 
> This patch fixes build failure(randconfig) of next-20130501.
> When config I2C as m, BATTERY_BQ27x00 as y, here comes the failure.
> The driver depends on I2C only if I2C is not disabled, as Lars
> commented. Last version of this patch make the driver depend on I2C
> unconditionally.
> 
> Failure message:
> drivers/built-in.o: In function `bq27x00_read_i2c':
> bq27x00_battery.c:(.text+0x1082a7): undefined reference to `i2c_transfer'
> drivers/built-in.o: In function `bq27x00_battery_init':
> bq27x00_battery.c:(.init.text+0x6085): undefined reference to `i2c_register_driver'
> bq27x00_battery.c:(.init.text+0x60c7): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `bq27x00_battery_exit':
> bq27x00_battery.c:(.exit.text+0xbf0): undefined reference to `i2c_del_driver'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> ---

Applied, thanks!

> drivers/power/Kconfig |    1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 0d0b5d7..f11bacd 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -152,6 +152,7 @@ config BATTERY_SBS
>  
>  config BATTERY_BQ27x00
>  	tristate "BQ27x00 battery driver"
> +	depends on I2C || I2C=n
>  	help
>  	  Say Y here to enable support for batteries with BQ27x00 (I2C/HDQ) chips.
>  

      reply	other threads:[~2013-05-10 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03  9:56 [PATCH -next] power: fix bq27x00_battery kconfig Xiong Zhou
2013-05-03 10:06 ` Lars-Peter Clausen
2013-05-04 10:11   ` zhou jencce
2013-05-04 10:28     ` Lars-Peter Clausen
2013-05-07  2:15       ` Xiong Zhou
2013-05-10 18:05         ` Anton Vorontsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130510180527.GA32333@teo \
    --to=anton@enomsg.org \
    --cc=dwmw2@infradead.org \
    --cc=jencce.kernel@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).