From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH -next] ashmem: Fix ashmem_shrink deadlock. Date: Mon, 13 May 2013 17:42:16 -0400 Message-ID: <20130513214216.GA23743@kroah.com> References: <1367416573-5430-1-git-send-email-rlove@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f42.google.com ([209.85.160.42]:55232 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754448Ab3EMXqW (ORCPT ); Mon, 13 May 2013 19:46:22 -0400 Received: by mail-pb0-f42.google.com with SMTP id up7so4854884pbc.1 for ; Mon, 13 May 2013 16:46:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1367416573-5430-1-git-send-email-rlove@google.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Robert Love Cc: Shankar Brahadeeswaran , Dan Carpenter , LKML , Bjorn Bringert , devel , Hugh Dickins , Anjana V Kumar , Dad , linux-next On Wed, May 01, 2013 at 09:56:13AM -0400, Robert Love wrote: > Don't acquire ashmem_mutex in ashmem_shrink if we've somehow recursed into the > shrinker code from within ashmem. Just bail out, avoiding a deadlock. This is > fine, as ashmem cache pruning is advisory anyhow. > > Signed-off-by: Robert Love > --- > drivers/staging/android/ashmem.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Based on Andrew's review comments, I'll drop this from my queue and wait for a "better" fix for this. thanks, greg k-h