From: Borislav Petkov <bp@alien8.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH -next v3] thermal: fix x86_pkg_temp_thermal.c build and Kconfig
Date: Mon, 17 Jun 2013 21:45:24 +0200 [thread overview]
Message-ID: <20130617194524.GD8197@pd.tnic> (raw)
In-Reply-To: <51BF6315.9020501@infradead.org>
On Mon, Jun 17, 2013 at 12:27:17PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error in x86_pkg_temp_thermal.c. It requires that
> X86_MCE & X86_THERMAL_VECTOR be enabled, so depend on the latter symbol,
> since it depends on X86_MCE (indirectly).
>
> Also, X86_PKG_TEMP_THERMAL is already inside an "if THERMAL" block,
> so remove that duplicated dependency.
>
> ERROR: "platform_thermal_package_rate_control" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
> ERROR: "platform_thermal_package_notify" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/thermal/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-next-20130617.orig/drivers/thermal/Kconfig
> +++ linux-next-20130617/drivers/thermal/Kconfig
> @@ -171,8 +171,7 @@ config INTEL_POWERCLAMP
>
> config X86_PKG_TEMP_THERMAL
> tristate "X86 package temperature thermal driver"
> - depends on THERMAL
> - depends on X86
> + depends on X86_THERMAL_VECTOR
> select THERMAL_GOV_USER_SPACE
> default m
> help
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-06-17 19:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 8:51 linux-next: Tree for Jun 17 Stephen Rothwell
2013-06-17 10:04 ` Geert Uytterhoeven
2013-06-18 0:06 ` Stephen Rothwell
2013-06-17 17:03 ` linux-next: Tree for Jun 17 (x86_pkg_temp_thermal.c) Randy Dunlap
2013-06-17 17:26 ` Srinivas Pandruvada
2013-06-17 17:55 ` [PATCH -next] thermal: fix x86_pkg_temp_thermal.c build and Kconfig Randy Dunlap
2013-06-17 18:09 ` Srinivas Pandruvada
2013-06-17 18:12 ` [PATCH -next v2] " Randy Dunlap
2013-06-17 18:17 ` Borislav Petkov
2013-06-17 18:31 ` Srinivas Pandruvada
2013-06-17 19:27 ` [PATCH -next v3] " Randy Dunlap
2013-06-17 19:45 ` Borislav Petkov [this message]
2013-06-17 23:28 ` Zhang Rui
2013-06-17 17:15 ` linux-next: Tree for Jun 17 (compat_binfmt_elf.c) Randy Dunlap
2013-06-18 0:24 ` Stephen Rothwell
2013-06-18 19:33 ` [PATCH -next] x86: fix build error and kconfig for ia32_emulation and binfmt Randy Dunlap
2013-06-17 17:26 ` linux-next: Tree for Jun 17 (media/usb/uvc) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617194524.GD8197@pd.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
--cc=sfr@canb.auug.org.au \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).