From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Steven Rostedt <rostedt@goodmis.org>,
Kevin Hilman <khilman@linaro.org>,
sedat.dilek@gmail.com, Theodore Ts'o <tytso@mit.edu>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux kbuild ML <linux-kbuild@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the ext4 tree
Date: Fri, 16 Aug 2013 20:02:40 +0200 [thread overview]
Message-ID: <20130816180240.GA2715@free.fr> (raw)
In-Reply-To: <20130816171448.GA13841@merkur.ravnborg.org>
Sam, Michal, All,
On 2013-08-16 19:14 +0200, Sam Ravnborg spake thusly:
> On Fri, Aug 16, 2013 at 03:10:38PM +0200, Michal Marek wrote:
> > On 11.8.2013 23:39, Yann E. MORIN wrote:
> > > On 2013-08-09 13:42 +0200, Sam Ravnborg spake thusly:
> > >> If we drop the special handling of "MODULES" and introduced
> > >> the following in we may fix it - hopefully:
> > >>
> > >> config MODULES
> > >> option modules
> > >>
> > >> The option handling is already in place. It is even documented :-)
> > >
> > > Yes, indeed, that one is pretty easy! :-)
> > >
> > >> At least we could then drop the sym_lookup here (zconf.y):
> > >> if (!modules_sym->prop) {
> > >> struct property *prop;
> > >>
> > >> prop = prop_alloc(P_DEFAULT, modules_sym);
> > >> prop->expr = expr_alloc_symbol(sym_lookup("MODULES", 0));
> > >> }
> > >> Without the sym_lookup I think the symbol will not be defined and tus not marked valid.
> > >
> > > Sorry, I don't understand what we should do here.
> > >
> > > From what I understand, here's what happens:
> > > - there's no symbol that declared the 'modules' option, so the
> > > modules_sym->prop is NULL;
> > > - so we look for the symbol 'MODULES' and use that as the symbol used
> > > to evaluate if tristates are enabled.
> > >
> > > So, now we have 'option modules' added to MODULES, we never enter this
> > > if() condition.
> > >
> > > But what would happen to other projects that do not have a symbol set
> > > with 'option modules' and no 'MODULES' symbol? Surely, those projects do
> > > not need tristates, but what should the code do in this case?
> > >
> > > So, I don't know what to replace this 'sym_lookup("MODULES", 0)' with.
> >
> > If the Kconfig files do not provide any symbol with 'option modules',
> > then set modules_sym to a dummy bool with the value 'n'?
> This is my thinking too - to use the symbol "n".
> But I wanted to try it out - but so far have not had time for it.
OK, I'll tackle this. Thanks for the info. :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-08-16 18:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 1:08 linux-next: build failure after merge of the ext4 tree Stephen Rothwell
2013-07-31 1:27 ` Stephen Rothwell
2013-08-07 5:16 ` Sedat Dilek
2013-08-07 5:38 ` Stephen Rothwell
2013-08-07 5:43 ` Sedat Dilek
2013-08-07 5:59 ` Stephen Rothwell
2013-08-07 15:28 ` Kevin Hilman
2013-08-08 0:22 ` Stephen Rothwell
2013-08-08 0:36 ` Stephen Rothwell
2013-08-08 19:16 ` Yann E. MORIN
2013-08-08 21:54 ` Yann E. MORIN
2013-08-08 23:58 ` Stephen Rothwell
2013-08-09 11:42 ` Sam Ravnborg
2013-08-11 21:39 ` Yann E. MORIN
2013-08-16 13:10 ` Michal Marek
2013-08-16 17:14 ` Sam Ravnborg
2013-08-16 18:02 ` Yann E. MORIN [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-08 23:51 Stephen Rothwell
2018-10-09 5:23 ` Theodore Y. Ts'o
2016-02-07 23:50 Stephen Rothwell
2016-01-03 23:34 Stephen Rothwell
2016-01-04 13:49 ` Theodore Ts'o
2015-07-23 0:56 Stephen Rothwell
2015-07-23 16:49 ` Theodore Ts'o
2015-07-23 17:23 ` Theodore Ts'o
2015-07-23 17:41 ` Tejun Heo
2015-05-07 1:14 Stephen Rothwell
2013-04-03 23:43 Stephen Rothwell
2013-04-04 13:18 ` Lukáš Czerner
2013-04-04 13:20 ` Theodore Ts'o
2013-04-04 13:27 ` Lukáš Czerner
2012-07-10 1:23 Stephen Rothwell
2012-07-10 1:48 ` Aditya Kali
2012-01-03 0:35 Stephen Rothwell
2012-01-05 21:06 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816180240.GA2715@free.fr \
--to=yann.morin.1998@free.fr \
--cc=khilman@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).