Hi Mark, After merging the spi tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/spi/spi-ti-qspi.c:19:0: include/linux/module.h:87:32: error: '__mod_of_device_table' aliased to undefined symbol 'dra7xxx_qspi_match' extern const struct gtype##_id __mod_##gtype##_table \ ^ include/linux/module.h:145:3: note: in expansion of macro 'MODULE_GENERIC_TABLE' MODULE_GENERIC_TABLE(type##_device,name) ^ drivers/spi/spi-ti-qspi.c:458:1: note: in expansion of macro 'MODULE_DEVICE_TABLE' MODULE_DEVICE_TABLE(of, dra7xxx_qspi_match); ^ Caused by commit 505a14954e2d ("spi/qspi: Add qspi flash controller"). Clearly not build tested as a module. :-( I have used the spi tree from next-20130822 for today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au