From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sarah Sharp Subject: Re: linux-next: Tree for Aug 28 [ xhci build breakage ] Date: Wed, 28 Aug 2013 10:37:15 -0700 Message-ID: <20130828173715.GE26483@xanatos> References: <521DD43D.7070605@samsung.com> <521DD6BD.4030700@samsung.com> <20130828165938.GA26483@xanatos> <20130828171824.GA5012@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130828171824.GA5012@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Dmitry Kasatkin , sedat.dilek@gmail.com, Stephen Rothwell , linux-next , LKML , linux-usb@vger.kernel.org List-Id: linux-next.vger.kernel.org On Wed, Aug 28, 2013 at 10:18:24AM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote: > > Please trim your replies. > > > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > > > >>> That change seems to cause the problems: > > > >>> > > > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f > > > >>> "xhci:prevent "callbacks suppressed" when debug is not enabled" > > > >>> > > > >>> - Sedat - > > > >>> > > > >>> [1] http://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/host/xhci-ring.c?h=usb-next&id=0730d52a86919300a39a2be37f6c140997dfb82f > > > >>> > > > >> Hello, > > > >> > > > >> [PATCHv2 1/2] was not applied before. > > > >> I pointed this out few hours ago... > > > > So commit 0730d52a86919300a39a2be37f6c140997dfb82f 'xhci:prevent > > "callbacks suppressed" when debug is not enabled' needed to be applied > > after your first patch? And basically applying that patch alone breaks > > the build? > > > > Ugh. Sorry about this. Greg, how do you want to handle this? > > See my other response about your pull request, how about tacking it onto > there? Yeah, you could take the first patch and apply it to the usb-next tree. There would still be a few patches where build breakage occurs, but that will be there regardless of whether we revert that patch, apply the first one, and then re-apply the second one. So just applying the first patch seems to be the better option. Sarah Sharp