From: Tony Lindgren <tony@atomide.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
"pinctl-single.c" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Olof Johansson <olof@lixom.net>
Subject: Re: linux-next: Tree for Oct 17 (pinctrl-single.c)
Date: Fri, 18 Oct 2013 17:39:26 -0700 [thread overview]
Message-ID: <20131019003925.GW15154@atomide.com> (raw)
In-Reply-To: <20131018234914.GV15154@atomide.com>
* Tony Lindgren <tony@atomide.com> [131018 16:49]:
> * Randy Dunlap <rdunlap@infradead.org> [131018 16:41]:
> > On 10/18/13 16:39, Tony Lindgren wrote:
> > >
> > > Looks like we need a little bit of arch specific handling
> > > with the generic IRQ. Fix the issue with an ifdef the
> > > same way as other drivers do.
> > >
> > > ARM needs things set to IRQF_VALID, which also then sets
> > > noprobe. Others seem to use just irq_set_noprobe().
> > >
> > > Otherwise we can get:
> > >
> > > drivers/pinctrl/pinctrl-single.c: In function 'pcs_irqdomain_map':
> > > drivers/pinctrl/pinctrl-single.c:1750:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
> >
> > Did you address this error? I don't see a fix for it...
>
> Yes set_irq_flags() is defined for ARM archs in
> arch/arm/include/asm/hw_irq.h which is included from
> include/linux/irq.h as <asm/hw_irq.h>. So the ifdef
> below takes care of that too.
>
> > > +#ifdef CONFIG_ARM
> > > + set_irq_flags(irq, IRQF_VALID);
> > > +#else
> > > + irq_set_noprobe(irq);
> > > +#endif
OK I've sent the pull request and Olof has now pulled the fix
into arm-soc next/dt branch.
Tony
next prev parent reply other threads:[~2013-10-19 0:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 0:38 linux-next: Tree for Oct 17 Mark Brown
2013-10-18 7:45 ` Olof Johansson
2013-10-18 8:22 ` Thierry Reding
2013-10-18 16:22 ` Kevin Hilman
2013-10-18 17:01 ` Kevin Hilman
2013-10-18 17:55 ` Olof Johansson
2013-10-18 11:33 ` Guenter Roeck
2013-10-18 18:08 ` linux-next: Tree for Oct 17 (pinctrl-single.c) Randy Dunlap
2013-10-18 19:43 ` Linus Walleij
2013-10-18 23:39 ` Tony Lindgren
2013-10-18 23:41 ` Randy Dunlap
2013-10-18 23:49 ` Tony Lindgren
2013-10-19 0:39 ` Tony Lindgren [this message]
2013-10-19 0:41 ` Randy Dunlap
2013-10-18 18:14 ` linux-next: Tree for Oct 17 (drm: panel-simple) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131019003925.GW15154@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rdunlap@infradead.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).