From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>
Subject: linux-next: build failure after merge of the final tree (gpio tree related)
Date: Tue, 29 Oct 2013 20:10:13 +1100 [thread overview]
Message-ID: <20131029201013.cc93b7f5eca956bf6ff04e68@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
Hi all,
After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:
In file included from drivers/spi/spi.c:33:0:
include/linux/of_gpio.h: In function 'of_get_named_gpio_flags':
include/linux/of_gpio.h:93:3: error: implicit declaration of function 'desc_to_gpio' [-Werror=implicit-function-declaration]
Caused by commit af8b6375a829 ("gpiolib: port of_ functions to use
gpiod") from the gpio tree.
I have applied the following patch for today (it should go into the gpio
tree if it is considered correct):
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 Oct 2013 20:05:12 +1100
Subject: [PATCH] gpiolib: include gpio/consumer.h in of_gpio.h for
desc_to_gpio()
Fixes this build error on sparc:
In file included from drivers/spi/spi.c:33:0:
include/linux/of_gpio.h: In function 'of_get_named_gpio_flags':
include/linux/of_gpio.h:93:3: error: implicit declaration of function 'desc_to_gpio' [-Werror=implicit-function-declaration]
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/of_gpio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h
index d71f2cc141ae..f14123a5a9df 100644
--- a/include/linux/of_gpio.h
+++ b/include/linux/of_gpio.h
@@ -19,9 +19,9 @@
#include <linux/errno.h>
#include <linux/gpio.h>
#include <linux/of.h>
+#include <linux/gpio/consumer.h>
struct device_node;
-struct gpio_desc;
/*
* This is Linux-specific flags. By default controllers' and Linux' mapping
--
1.8.4.rc3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2013-10-29 9:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 9:10 Stephen Rothwell [this message]
2013-10-29 13:25 ` linux-next: build failure after merge of the final tree (gpio tree related) Linus Walleij
2013-10-30 0:56 ` Alex Courbot
-- strict thread matches above, loose matches on Subject: below --
2014-03-05 6:35 Stephen Rothwell
2014-03-05 7:16 ` Linus Walleij
2014-03-05 16:42 ` Fabian Vogt
2013-12-23 4:54 Stephen Rothwell
2013-10-28 14:12 Stephen Rothwell
2013-10-29 13:28 ` Linus Walleij
2012-02-06 4:23 Stephen Rothwell
2012-02-06 6:07 ` Grant Likely
2012-02-06 14:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029201013.cc93b7f5eca956bf6ff04e68@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=acourbot@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).