From: Tejun Heo <tj@kernel.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kay Sievers <kay@vrfy.org>,
linux-next@vger.kernel.org
Subject: Re: [BUG -next] sysfs change breaks userspace
Date: Thu, 31 Oct 2013 13:25:06 -0400 [thread overview]
Message-ID: <20131031172506.GE11698@mtj.dyndns.org> (raw)
In-Reply-To: <20131031114358.GA5551@osiris>
Hello, Heiko.
On Thu, Oct 31, 2013 at 12:43:58PM +0100, Heiko Carstens wrote:
> Hi Tejun,
>
> I just tried out linux-next and my network doesn't come up anymore.
> Userspace fails like this:
>
> network[2211]: Bringing up interface eth0: sysfs read broadcast value: Invalid argument
>
> I bisected that down to:
>
> commit 13c589d5b0ac654d9da7e490a2dd548e6b86b4a5
> Author: Tejun Heo <tj@kernel.org>
> Date: Tue Oct 1 17:42:02 2013 -0400
>
> sysfs: use seq_file when reading regular files
Heh, intereting. The content doesn't change over multiple show
invocations, so the behavior shouldn't change at all for the attribute
and seq_file handles seeking and partial reads correctly. No idea
what could go wrong there. It probably was reading
/sys/devices/BLAHBLAH/net/NETIF/broadcast file. Can you please locate
the file and do "ls -l" and "cat" on it? If that looks normal, can
you please strace the network interface config program / script /
whatever? BTW, what are you running on the system?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-10-31 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 11:43 [BUG -next] sysfs change breaks userspace Heiko Carstens
2013-10-31 17:25 ` Tejun Heo [this message]
2013-11-01 14:13 ` Heiko Carstens
2013-11-01 14:35 ` Tejun Heo
2013-11-01 15:04 ` Greg Kroah-Hartman
2013-11-01 15:08 ` Tejun Heo
2013-11-01 16:14 ` Greg Kroah-Hartman
2013-11-01 17:16 ` [PATCH driver-core-next] sysfs: use generic_file_llseek() for sysfs_file_operations Tejun Heo
2013-11-01 17:19 ` Greg Kroah-Hartman
2013-11-01 18:40 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031172506.GE11698@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kay@vrfy.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).