From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Anton Tikhomirov <av.tikhomirov@samsung.com>
Subject: Re: linux-next: build failure after merge of the usb-gadget tree
Date: Mon, 9 Dec 2013 13:40:32 -0600 [thread overview]
Message-ID: <20131209194032.GC28441@saruman.home> (raw)
In-Reply-To: <20131209041152.GC20608@saruman.home>
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
Hi Stephen,
On Sun, Dec 08, 2013 at 10:11:52PM -0600, Felipe Balbi wrote:
> On Mon, Dec 09, 2013 at 02:58:03PM +1100, Stephen Rothwell wrote:
> > Hi Felipe,
> >
> > After merging the usb-gadget tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/built-in.o: In function `otg_set_state':
> > (.text+0x14f7de): undefined reference to `usb_bus_start_enum'
> >
> > CONFIG_USB is 'm' in this build.
> >
> > I am not sure what changed to cause this, maybe e1d2e31975e1 ("usb: phy:
> > Add OTG FSM configuration option")?
> >
> > I have used the usb-gadget tree from next-20131206 for today.
>
> I see what caused it, will fix it up with a patch which should probably
> be backported a few kernels back. Thanks for letting me know.
Do you still have the .config which caused that build error ? I couldn't
reproduce with CONFIG_USB=m && CONFIG_USB_OTG=y.
In any case, I believe this will help:
diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index fed7f68..03cc86c 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -51,6 +51,7 @@ config USB_DYNAMIC_MINORS
config USB_OTG
bool "OTG support"
+ depends on USB && USB_GADGET
depends on PM_RUNTIME
default n
help
It makes no sense to allow OTG without having both host and gadget
support.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-09 19:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 3:58 linux-next: build failure after merge of the usb-gadget tree Stephen Rothwell
2013-12-09 4:11 ` Felipe Balbi
2013-12-09 19:40 ` Felipe Balbi [this message]
2013-12-09 20:43 ` Stephen Rothwell
2013-12-09 21:01 ` Felipe Balbi
2013-12-09 21:42 ` Felipe Balbi
2013-12-17 4:36 ` Stephen Rothwell
2013-12-17 5:08 ` Felipe Balbi
2013-12-17 5:13 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2020-03-16 3:37 Stephen Rothwell
2020-03-16 17:42 ` John Stultz
2020-03-16 18:11 ` John Stultz
2020-03-16 19:46 ` Greg KH
2015-05-29 8:32 Stephen Rothwell
2015-05-29 15:19 ` Felipe Balbi
2013-12-16 4:40 Stephen Rothwell
2013-12-16 19:41 ` Felipe Balbi
2013-12-16 23:10 ` Stephen Rothwell
2013-12-16 23:38 ` Felipe Balbi
2013-12-17 4:27 ` Stephen Rothwell
2013-07-30 4:34 Stephen Rothwell
2013-07-30 5:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209194032.GC28441@saruman.home \
--to=balbi@ti.com \
--cc=av.tikhomirov@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).