From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: linux-next: build failure after merge of the tip tree Date: Mon, 20 Jan 2014 11:13:45 +0100 Message-ID: <20140120101345.GC3694@twins.programming.kicks-ass.net> References: <20140116145829.5e4fcab103b1c5c77501ee77@canb.auug.org.au> <20140120083021.GC30183@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140120083021.GC30183@twins.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Len Brown Cc: Stephen Rothwell , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-next@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-next.vger.kernel.org On Mon, Jan 20, 2014 at 09:30:21AM +0100, Peter Zijlstra wrote: > Then make them so. The fact was that most of the mwait idle sites > were bloody broken. And the single mwait_idle_with_hints() function > presents a single nice function that does all the required magics. To stress this a bit more; have a look see at mwwait_idle_with_hints(); it does a whole lot of subtle magic. - current_{set,clr}_polling*(), these are crucial in not missing and wrecking NEED_RESCHED state. - X86_FEATURE_CLFLUSH_MONTIOR quirk - Does the monitor(); if (!need_resched()) mwait() thing. All of those are required for a correct and functional idle loop. And I've seen sites where any or all of the above were missing/broken. Not unifying the lot into a simple usable function is just stupid -- history has shown people simply cannot be trusted to get this right.