linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "J. Bruce Fields" <bfields@fieldses.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Linus <torvalds@linux-foundation.org>
Subject: linux-next: manual merge of the nfsd tree with Linus' tree
Date: Wed, 29 Jan 2014 12:42:38 +1100	[thread overview]
Message-ID: <20140129124238.6e1667abab08be8be2dafe01@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

Hi all,

Today's linux-next merge of the nfsd tree got a conflict in
fs/nfsd/nfs4acl.c between commit 4ac7249ea5a0 ("nfsd: use get_acl and
->set_acl") from Linus' tree and commit 3554116d3aae ("nfsd4: simplify
xdr encoding of nfsv4 names") from the nfsd tree.

I fixed it up (see below) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc fs/nfsd/nfs4acl.c
index 649ad7cf2204,eea24c9a561d..000000000000
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@@ -37,13 -37,9 +37,14 @@@
  #include <linux/slab.h>
  #include <linux/nfs_fs.h>
  #include <linux/export.h>
 +#include "nfsfh.h"
+ #include "nfsd.h"
  #include "acl.h"
 +#include "vfs.h"
  
 +#define NFS4_ACL_TYPE_DEFAULT	0x01
 +#define NFS4_ACL_DIR		0x02
 +#define NFS4_ACL_OWNER		0x04
  
  /* mode bit translations: */
  #define NFS4_READ_MODE (NFS4_ACE_READ_DATA)
@@@ -916,17 -849,26 +917,22 @@@ nfs4_acl_get_whotype(char *p, u32 len
  	return NFS4_ACL_WHO_NAMED;
  }
  
- int
- nfs4_acl_write_who(int who, char *p)
+ __be32 nfs4_acl_write_who(int who, __be32 **p, int *len)
  {
  	int i;
+ 	int bytes;
  
  	for (i = 0; i < ARRAY_SIZE(s2t_map); i++) {
- 		if (s2t_map[i].type == who) {
- 			memcpy(p, s2t_map[i].string, s2t_map[i].stringlen);
- 			return s2t_map[i].stringlen;
- 		}
+ 		if (s2t_map[i].type != who)
+ 			continue;
+ 		bytes = 4 + (XDR_QUADLEN(s2t_map[i].stringlen) << 2);
+ 		if (bytes > *len)
+ 			return nfserr_resource;
+ 		*p = xdr_encode_opaque(*p, s2t_map[i].string,
+ 					s2t_map[i].stringlen);
+ 		*len -= bytes;
+ 		return 0;
  	}
- 	BUG();
+ 	WARN_ON_ONCE(1);
  	return -1;
  }
 -
 -EXPORT_SYMBOL(nfs4_acl_new);
 -EXPORT_SYMBOL(nfs4_acl_get_whotype);
 -EXPORT_SYMBOL(nfs4_acl_write_who);

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2014-01-29  1:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29  1:42 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-07-30  1:23 linux-next: manual merge of the nfsd tree with Linus' tree Stephen Rothwell
2015-07-30  1:35 ` Trond Myklebust
2015-07-30  2:12   ` J. Bruce Fields
2013-04-03  0:01 Stephen Rothwell
2013-03-01  0:49 Stephen Rothwell
2011-01-06  0:47 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140129124238.6e1667abab08be8be2dafe01@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).